ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Petr Ivanov <mr.wei...@gmail.com>
Subject Re: Code inspection
Date Fri, 26 Oct 2018 14:51:14 GMT
Also, let me note that currently only modules/core/** is under inspection.
And in spite of the fact that core is the “heaviest" module in project. it seems that adding
new inspections should be 2-way: new inspections and new modules (builds).


> On 26 Oct 2018, at 17:41, Yakov Zhdanov <yzhdanov@apache.org> wrote:
> 
> Agree with Petr.
> 
> Maxim, what are our next steps? Can we add check for
> - line length
> - indents (tabs vs spaces)

Should not we start adding new inspections after current errors all have been eliminated?


> 
> This may require some efforts (will it and how much?), but can we add check
> for:
> - log messages structure
> - log.warn() vs U.warn()
> - abbreviations for local variables and fields.
> 
> And last question
> 
>> - the new configuration ignite_inspections_teamcity.xml added to PR;
> 
> Can this be installed locally by every contributor to check the code? Can
> we add this to setup steps we have on wiki?
> 
> --Yakov


Mime
View raw message