ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] SomeFire commented on a change in pull request #40: IGNITE-9939 BuildObserver UNKNOWN build state handling added
Date Tue, 30 Oct 2018 13:43:55 GMT
SomeFire commented on a change in pull request #40: IGNITE-9939 BuildObserver UNKNOWN build
state handling added
URL: https://github.com/apache/ignite-teamcity-bot/pull/40#discussion_r229275815
 
 

 ##########
 File path: ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/observer/BuildsInfo.java
 ##########
 @@ -40,37 +54,68 @@
     /** JIRA ticket full name. */
     public final String ticket;
 
+    /** */
+    public final Date date;
+
     /** Finished builds. */
-    private final Map<Build, Boolean> finishedBuilds = new HashMap<>();
+    private final Map<Integer, Boolean> finishedBuilds = new HashMap<>();
 
     /**
      * @param srvId Server id.
      * @param prov Prov.
      * @param ticket Ticket.
      * @param builds Builds.
      */
-    public BuildsInfo(String srvId, ICredentialsProv prov, String ticket, Build[] builds)
{
+    public BuildsInfo(String srvId, ICredentialsProv prov, String ticket, String branchName,
Build... builds) {
 
 Review comment:
   Rename `branchName` to `branchForTc`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message