ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] SomeFire commented on a change in pull request #40: IGNITE-9939 BuildObserver UNKNOWN build state handling added
Date Tue, 30 Oct 2018 13:43:55 GMT
SomeFire commented on a change in pull request #40: IGNITE-9939 BuildObserver UNKNOWN build
state handling added
URL: https://github.com/apache/ignite-teamcity-bot/pull/40#discussion_r229276186
 
 

 ##########
 File path: ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/observer/BuildObserver.java
 ##########
 @@ -58,10 +63,16 @@ public void stop() {
     /**
      * @param srvId Server id.
      * @param prov Credentials.
+     * @param ticket Ticket.
+     * @param branch Branch.
      * @param ticket JIRA ticket name.
      */
-    public void observe(String srvId, ICredentialsProv prov, String ticket, Build... builds)
{
-        observerTask.addBuild(new BuildsInfo(srvId, prov, ticket, builds));
+    public void observe(String srvId, ICredentialsProv prov, String ticket, String branch,
Build... builds) {
 
 Review comment:
   Rename `branch` to `branchForTc`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message