ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] SomeFire commented on a change in pull request #40: IGNITE-9939 BuildObserver UNKNOWN build state handling added
Date Tue, 23 Oct 2018 08:40:09 GMT
SomeFire commented on a change in pull request #40: IGNITE-9939 BuildObserver UNKNOWN build
state handling added
URL: https://github.com/apache/ignite-teamcity-bot/pull/40#discussion_r227284241
 
 

 ##########
 File path: ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/tcmodel/hist/BuildRef.java
 ##########
 @@ -181,4 +181,8 @@ public boolean isQueued() {
     public boolean isRunning() {
         return STATE_RUNNING.equals(state());
     }
+
+    public boolean isUnknown() {
+        return STATUS_UNKNOWN.equals(state());
 
 Review comment:
   State can't be unknown, it can be queued, running or finished. But status can be unknown
when build is cancelled.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message