ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] asfgit closed pull request #29: IGNITE-9815: Muted tests shouldn't considered as blocker
Date Wed, 10 Oct 2018 10:33:43 GMT
asfgit closed pull request #29: IGNITE-9815: Muted tests shouldn't considered as blocker
URL: https://github.com/apache/ignite-teamcity-bot/pull/29
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/current/TestFailure.java
b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/current/TestFailure.java
index dcd18fb..7e49ec0 100644
--- a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/current/TestFailure.java
+++ b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/current/TestFailure.java
@@ -241,6 +241,9 @@ public void initStat(@Nullable final Function<TestInBranch, RunStat>
runStatSupp
     public boolean isNewFailedTest() {
         FailureSummary recent = histBaseBranch.recent;
 
+        if (!Strings.isNullOrEmpty(webIssueUrl))
+            return false;
+
         boolean lowFailureRate = recent != null && recent.failureRate != null &&
             Float.valueOf(recent.failureRate.replace(',', '.')) < 4.;
 
diff --git a/ignite-tc-helper-web/src/main/webapp/js/testfails-2.1.js b/ignite-tc-helper-web/src/main/webapp/js/testfails-2.1.js
index b61189b..e1c995c 100644
--- a/ignite-tc-helper-web/src/main/webapp/js/testfails-2.1.js
+++ b/ignite-tc-helper-web/src/main/webapp/js/testfails-2.1.js
@@ -627,8 +627,12 @@ function isNewFailedTest(testFail) {
     if(!isDefinedAndFilled(testFail.histBaseBranch))
         return true;
 
+    if (testFail.webIssueUrl)
+        return false;
+
     var hist = testFail.histBaseBranch;
-    if(!isDefinedAndFilled(hist.recent))
+
+    if (!isDefinedAndFilled(hist.recent))
         return true;
 
     var flakyCommentsInBase =


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message