ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] SomeFire commented on a change in pull request #27: IGNITE-9770 Add 'Re-run possible blockers' button
Date Thu, 04 Oct 2018 12:18:18 GMT
SomeFire commented on a change in pull request #27: IGNITE-9770 Add 'Re-run possible blockers'
button
URL: https://github.com/apache/ignite-teamcity-bot/pull/27#discussion_r222642202
 
 

 ##########
 File path: ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/rest/TriggerBuild.java
 ##########
 @@ -167,7 +167,8 @@ private String observeJira(
 
         BuildObserver observer = CtxListener.getInjector(context).getInstance(BuildObserver.class);
 
-        observer.observe(build, srvId, prov, "ignite-" + ticketId);
+        for (Build build : builds)
 
 Review comment:
   We shouldn't observe builds for the same PR separately, because in such case we Bot will
comment same ticket for every build. We should wait while all of the builds will be finished
and comment only once.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message