From dev-return-39898-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Sat Sep 29 02:16:17 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id B3A6A180627 for ; Sat, 29 Sep 2018 02:16:16 +0200 (CEST) Received: (qmail 65634 invoked by uid 500); 29 Sep 2018 00:16:15 -0000 Mailing-List: contact dev-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list dev@ignite.apache.org Received: (qmail 65621 invoked by uid 99); 29 Sep 2018 00:16:15 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 29 Sep 2018 00:16:15 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id A22F6C1FB9 for ; Sat, 29 Sep 2018 00:16:14 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.898 X-Spam-Level: * X-Spam-Status: No, score=1.898 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id wULNvuEh4WLj for ; Sat, 29 Sep 2018 00:16:13 +0000 (UTC) Received: from mail-it1-f170.google.com (mail-it1-f170.google.com [209.85.166.170]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 4D3875F381 for ; Sat, 29 Sep 2018 00:16:12 +0000 (UTC) Received: by mail-it1-f170.google.com with SMTP id h6-v6so1407299ith.0 for ; Fri, 28 Sep 2018 17:16:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=ojhoZ2R7Tpjwr2q3kkaXNxzPMJrm0kXQu3G4h+bhrVo=; b=bglhBgMBlVFHYLCE30uRU4IgEmY5iNlgKzIU354thGHhsUODLHmU0wFkcbhl5c9J2c uwMAfEd/5pDvovhQyzJ1CysD/xZEYMeAyyKzNiXunM0RCmiwSnC5OICHnoEI3Yq9F7Zk hyIWgyWqQqILl5xEwuPG55onCshGfUg1qH2dgJYQtPF0XAPrNxAt3fQAnI8tQXgDLqVm vprjyotg15cV+OwLzB3/R3vfvToWAhR07OGYqoBW82KcAZkbhFfGq5DmzD8rlnOXlaIi 203/8cyT12/oFLGjWFSF+C3Tg5sb24imMQNyfixmeHNSRofTQEHCeTOnLGdqEf7qJw4H X+lQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=ojhoZ2R7Tpjwr2q3kkaXNxzPMJrm0kXQu3G4h+bhrVo=; b=FFjVDooOqAZrUhOrKzfG1AGnLENmeHr2qJ1zDYXXLk6NNwhBnGZEKJQPUXR4Z5ecn1 7vwe2f0mMsshGZaMdrv6ThvqKFqMAAoCD4VI+c/7q1lNIPl5nQui2mGoBgipgQr4y6LQ o7H8wyy2MiiVJj2orVZt6c4DwOmoXrr94WY7W8l5ROZqRiu1bbMuc/uOxJx2vw7lJoWC 2nVk6MxtojeJGKuN8OB2tdHRv1sr2wqffEGJGdT1Z3JtWE8m7Bs2jyeaKqJd/39+A8G8 G2MuoOlBdc7lxVLud1UW79powk0T+LG8qLQwuT//wMeQVVQt4pJTs63xfXPB16+hOnpg rKsg== X-Gm-Message-State: ABuFfoiwLhMNZeJ0IIgL81bvgEA+WBYaWUi79Z0HVyi7oA3Vi0A9d9yL vglF3m8Kze4LluQdBQr2y0mq45iypCSvwIGN04JOHg== X-Google-Smtp-Source: ACcGV600/wsBG+BXRFVHqU/JPAQXYx814H0Vv/dBgsNzla5+gO+dFWnJZXZNDvXkdc1MWKSs0l+tgyq+utPktYq3vKs= X-Received: by 2002:a24:6c8a:: with SMTP id w132-v6mr3600318itb.141.1538180164811; Fri, 28 Sep 2018 17:16:04 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Saikat Maitra Date: Fri, 28 Sep 2018 19:15:53 -0500 Message-ID: Subject: Re: Request for review : IGNITE-3303 Apache Flink Integration - Flink source To: dev@ignite.apache.org Content-Type: multipart/alternative; boundary="0000000000005300720576f77a8e" --0000000000005300720576f77a8e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thank you Andrew Regards, Saikat On Fri, Sep 28, 2018 at 7:00 PM Andrey Mashenkov wrote: > Hi Saikat, > > Sorry for late answer. I've checked changes a day ago. Now, looks good. > Hope, it will be merged soon. > > Alex, would you please merge PR to master. > > =D1=81=D0=B1, 29 =D1=81=D0=B5=D0=BD=D1=82. 2018 =D0=B3., 2:29 Saikat Mait= ra : > > > Hi Andrew, > > > > I have updated the changes. > > > > Can you please review and share feedback. > > > > Regards > > Saikat > > > > On Sat, Sep 22, 2018 at 2:23 PM Saikat Maitra > > wrote: > > > > > Hi Andrew > > > > > > > > > I have updated the changes. > > > > > > > > > Can you please review and share feedback. > > > > > > > > > Regards > > > Saikat > > > > > > > > > On Wed, Sep 19, 2018 at 8:11 PM, Saikat Maitra < > saikat.maitra@gmail.com> > > > wrote: > > > > > >> Hi Andrew, > > >> > > >> I have updated the tests and also added java docs. > > >> > > >> Can you please review and share feedback. > > >> > > >> > > >> Regards > > >> Saikat > > >> > > >> > > >> > > >> > > >> On Sun, Sep 16, 2018 at 11:53 AM, Saikat Maitra < > > saikat.maitra@gmail.com> > > >> wrote: > > >> > > >>> Hi Andrew, > > >>> > > >>> I have updated the tests and also added java docs. > > >>> > > >>> Please review and share feedback. > > >>> > > >>> Regards > > >>> Saikat > > >>> > > >>> > > >>> On Sat, Sep 8, 2018 at 2:09 PM, Saikat Maitra < > saikat.maitra@gmail.com > > > > > >>> wrote: > > >>> > > >>>> Hi Andrew, Alexey > > >>>> > > >>>> I have incorporated the review changes. > > >>>> > > >>>> I have also refactored the CacheEventSerializer class and moved it > to > > >>>> test folder because it is used only in the > > FlinkIgniteSourceSelfExample and > > >>>> not required for IgniteSource. > > >>>> > > >>>> Build links > > https://ci.ignite.apache.org/viewLog.html?buildId=3D1821778& > > >>>> > > >>>> https://ci.ignite.apache.org/viewLog.html?buildId=3D1821774& > > >>>> > > >>>> Please review and share feedback. > > >>>> > > >>>> Regards > > >>>> Saikat > > >>>> > > >>>> On Tue, Sep 4, 2018 at 9:57 PM, Saikat Maitra < > > saikat.maitra@gmail.com> > > >>>> wrote: > > >>>> > > >>>>> Hi Alexey, > > >>>>> > > >>>>> Thank you for reviewing the changes and sharing feedback, I am > > >>>>> updating the PR. I will share the changes shortly. > > >>>>> > > >>>>> Regards, > > >>>>> Saikat > > >>>>> > > >>>>> On Tue, Sep 4, 2018 at 10:59 AM, Alexey Goncharuk < > > >>>>> alexey.goncharuk@gmail.com> wrote: > > >>>>> > > >>>>>> Hello Saikat, > > >>>>>> > > >>>>>> I see a few fellow Igniters added some comments to your PR > > (including > > >>>>>> me). > > >>>>>> I believe the PR can be merged after you address them. > > >>>>>> > > >>>>>> Thanks, > > >>>>>> AG > > >>>>>> > > >>>>>> =D0=BF=D1=82, 31 =D0=B0=D0=B2=D0=B3. 2018 =D0=B3. =D0=B2 3:11, S= aikat Maitra < > saikat.maitra@gmail.com > > >: > > >>>>>> > > >>>>>> > Thank you, Denis > > >>>>>> > > > >>>>>> > Regards, > > >>>>>> > Saikat > > >>>>>> > > > >>>>>> > On Thu, Aug 30, 2018 at 7:01 PM, Denis Magda > > > >>>>>> wrote: > > >>>>>> > > > >>>>>> > > Hello Saikat, > > >>>>>> > > > > >>>>>> > > Hopefully, someone from the community will review the change= s > in > > >>>>>> the > > >>>>>> > > nearest time. > > >>>>>> > > > > >>>>>> > > -- > > >>>>>> > > Denis > > >>>>>> > > > > >>>>>> > > On Thu, Aug 30, 2018 at 4:37 PM Saikat Maitra < > > >>>>>> saikat.maitra@gmail.com> > > >>>>>> > > wrote: > > >>>>>> > > > > >>>>>> > > > Hello, > > >>>>>> > > > > > >>>>>> > > > The changes for IGNITE-3303 for IgniteSource is complete. > This > > >>>>>> will > > >>>>>> > help > > >>>>>> > > is > > >>>>>> > > > streaming data from Ignite cluster and process, filter, > > >>>>>> transform and > > >>>>>> > > > publish it back to Ignite using IgniteSink or in any other > > data > > >>>>>> sink. > > >>>>>> > > > > > >>>>>> > > > I was hoping if the changes can be approved I can go ahead > > >>>>>> merge the > > >>>>>> > > > changes. > > >>>>>> > > > > > >>>>>> > > > > > >>>>>> > > > Regards, > > >>>>>> > > > Saikat > > >>>>>> > > > > > >>>>>> > > > > > >>>>>> > > > > > >>>>>> > > > On Tue, Aug 28, 2018 at 12:56 AM, Saikat Maitra < > > >>>>>> > saikat.maitra@gmail.com > > >>>>>> > > > > > >>>>>> > > > wrote: > > >>>>>> > > > > > >>>>>> > > > > Hi Andrew, > > >>>>>> > > > > > > >>>>>> > > > > As discussed I have incorporated the changes. Please > review > > >>>>>> and let > > >>>>>> > me > > >>>>>> > > > > know if any changes required. > > >>>>>> > > > > > > >>>>>> > > > > Regards, > > >>>>>> > > > > Saikat > > >>>>>> > > > > > > >>>>>> > > > > On Mon, Aug 27, 2018 at 1:45 AM, Saikat Maitra < > > >>>>>> > > saikat.maitra@gmail.com> > > >>>>>> > > > > wrote: > > >>>>>> > > > > > > >>>>>> > > > >> Hi, > > >>>>>> > > > >> > > >>>>>> > > > >> I have updated the PR with additional tests. > > >>>>>> > > > >> > > >>>>>> > > > >> Please review and share feedback. > > >>>>>> > > > >> > > >>>>>> > > > >> This PR is related to IgniteSink but allows to stream > data > > >>>>>> from > > >>>>>> > > Ignite. > > >>>>>> > > > >> > > >>>>>> > > > >> PR https://github.com/apache/ignite/pull/870/files > > >>>>>> > > > >> > > >>>>>> > > > >> Review > > >>>>>> https://reviews.ignite.apache.org/ignite/review/IGNT-CR-135 > > >>>>>> > > > >> > > >>>>>> > > > >> Regards, > > >>>>>> > > > >> Saikat > > >>>>>> > > > >> > > >>>>>> > > > > > > >>>>>> > > > > > > >>>>>> > > > > > >>>>>> > > > > >>>>>> > > > >>>>>> > > >>>>> > > >>>>> > > >>>> > > >>> > > >> > > > > > > --0000000000005300720576f77a8e--