From dev-return-39850-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Fri Sep 28 13:22:37 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id C54FC180627 for ; Fri, 28 Sep 2018 13:22:36 +0200 (CEST) Received: (qmail 84878 invoked by uid 500); 28 Sep 2018 11:22:35 -0000 Mailing-List: contact dev-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list dev@ignite.apache.org Received: (qmail 84865 invoked by uid 99); 28 Sep 2018 11:22:35 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 28 Sep 2018 11:22:35 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id B1A3E1A07E2 for ; Fri, 28 Sep 2018 11:22:34 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.389 X-Spam-Level: *** X-Spam-Status: No, score=3.389 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_REPLY=1, HTML_MESSAGE=2, KAM_NUMSUBJECT=0.5, SPF_PASS=-0.001, T_DKIMWL_WL_MED=-0.01] autolearn=disabled Authentication-Results: spamd2-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id KPY3psbqnZ0T for ; Fri, 28 Sep 2018 11:22:32 +0000 (UTC) Received: from mail-oi1-f178.google.com (mail-oi1-f178.google.com [209.85.167.178]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id A5A3C5F3B2 for ; Fri, 28 Sep 2018 11:22:31 +0000 (UTC) Received: by mail-oi1-f178.google.com with SMTP id j68-v6so5033738oib.7 for ; Fri, 28 Sep 2018 04:22:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=yI79daTbvqjrUz4T+Iw9Yc6+TrNBnEnwZfqqoDhCWNQ=; b=T1RNMKztoR6MHlgJNoeAKD0gBq560kCZOj8XTfEEeEphY3EAC++r4LPwTXM2t0Ea3n OW6PMUWlfW6SetA1IQJ+SXUUxEeVuKcloE0p9YpQDDurc5qZVve7nAVfnTKyQRzG2KNQ Hxgq4xolkvbSDNkk0jC27E5y0Ll33SxBfH9lKLHof/dm3aqmQvhs1tuqN9hJ3ZzQGyT6 LjztzlgoNAm15MmHxfHbsDI2fARd+57po/WmaR2cCCHhielmcjs66XEiem/I4mFiGxFS Vlhf3tMgSmzn63dQjGF9p72Fm7o/Wf0rlzFsGLLU8c29pHsK0if2ipD4U3PDoakcL71R sIVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=yI79daTbvqjrUz4T+Iw9Yc6+TrNBnEnwZfqqoDhCWNQ=; b=SQGaCVUKxb6Q9nR9DyPonhHuyPBNTrXfO0V/syydBczMnKQVzb0xrT2E187H2lvUgq zs/cQE9/TLm5FhJESprHUTOY9xyqEcf57QrqlgnAyYtyqhK7KOjEG96ItYBHk8birX78 UrBj/crYyIBCKk9pz6MBZs1sAXAj/UgqXMiojbiKe2oo8QMz5t/ol9q4/mf6PX3YIWGH Q+/4cnhixsfw8uDQOpLdmqa8XOMiOxy+C+zALuedxZqIWEGfbY5UCXyB6v8hd3ck9VHx E5v0qKBykC0q0l0beJSGe6UsbBzFG4WgVMD4shuLRs0kp7AgqTgO4Y8QQ1ErXpQdSMBV yipw== X-Gm-Message-State: ABuFfohwLWymGYphRm9+wUAa7fZN4HuZAUZgj669qKuUf6qtrhtMGqfi DGrzYCVf0mB7+WHVPB2+QHSbE9TaicuvZ5Hibx7BLA== X-Google-Smtp-Source: ACcGV62D5ImY/XJUGSrcQ7D4suA8ZtIxe9Dim/LjSe75OUSxejtG4H9JQzhW6eoAz3qzPhq4q/0jyWrxUfL4PJbB33E= X-Received: by 2002:aca:d489:: with SMTP id l131-v6mr275268oig.15.1538133749998; Fri, 28 Sep 2018 04:22:29 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Dmitriy Pavlov Date: Fri, 28 Sep 2018 14:22:18 +0300 Message-ID: Subject: Re: [Discussion] revert of commit MVCC, ignite-9320 To: dev@ignite.apache.org Content-Type: multipart/alternative; boundary="000000000000c9286a0576ecab93" --000000000000c9286a0576ecab93 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Dmitriy S., I really prefer avoiding reverts, which why I've started this topic. If I were reverting-fan, I could just write: "Vetoing commit NNNN because of test failures TTTT, commit reverted, ticket IGNITE-KKKK reopened." But some time ago I several times asked newbie contributors to fix missed test failures and they managed to do it in 1-2 days, I'm waiting these test to be fixed by Ignite veteran(s) for 11 days. Sincerely, Dmitriy Pavlov =D0=BF=D1=82, 28 =D1=81=D0=B5=D0=BD=D1=82. 2018 =D0=B3. =D0=B2 13:16, Vladi= mir Ozerov : > Andrey, > > This is not a fix, but a hack, which covers real state of affairs. > > =D0=BF=D1=82, 28 =D1=81=D0=B5=D0=BD=D1=82. 2018 =D0=B3. =D0=B2 13:00, And= rey Mashenkov >: > > > Hi, > > > > Fix is trivial and ready. > > Hope, it will be merged within IGNITE-7764 today. > > > > https://issues.apache.org/jira/browse/IGNITE-7764 > > > > On Fri, Sep 28, 2018 at 12:26 PM Dmitriy Setrakyan < > dsetrakyan@apache.org> > > wrote: > > > > > Guys, let's just fix the tests without reverting commits. Reverting a > > > commit may trigger a time machine, where all following commits may be > > > broken because of it. Fixing that scenario will be much harder. > > > > > > Going forward, I would agree that we should not merge anything that > > breaks > > > tests. This is about following a basic engineering discipline. We > should > > > all do it. > > > > > > D. > > > > > > > > > On Fri, Sep 28, 2018 at 12:47 AM Dmitriy Pavlov > > > > wrote: > > > > > > > Yep, we're humans and we constantly make mistakes. It is a very hum= an > > > thing > > > > to do mistakes. > > > > > > > > So I suggest we will be under the control and protection of robot t= o > > > avoid > > > > mistakes, I suggest robot will revert such commits in 72h without i= ts > > own > > > > personal attitudes, emotions, etc. > > > > > > > > Someone who is interested in contribution usually can find time to > make > > > > contribution perfect. > > > > > > > > I'm not aware of project priorities, please share it. I believe > > different > > > > priorities can co-exist. A number of contributors are fixing tests, > so > > it > > > > is a priority for them, isn't it? So why to add work to that guys > > because > > > > of you have other priorities? > > > > > > > > =D0=BF=D1=82, 28 =D1=81=D0=B5=D0=BD=D1=82. 2018 =D0=B3. =D0=B2 10:3= 9, Vladimir Ozerov >: > > > > > > > > > Because a lot of other activities depended on configuration in > Java, > > > and > > > > we > > > > > didn't have expertise to fix .NET immediately. > > > > > > > > > > If you want to revert it - please go ahead. But I'd better sugges= t > > you > > > to > > > > > think about the impact and project priorities first, instead of > > trying > > > to > > > > > apply the some sort rules blindly. We are not robots. > > > > > > > > > > On Fri, Sep 28, 2018 at 10:19 AM Dmitriy Pavlov < > > dpavlov.spb@gmail.com > > > > > > > > > wrote: > > > > > > > > > > > Hi Vladimir, > > > > > > > > > > > > https://issues.apache.org/jira/browse/IGNITE-9320 is named > > > > configuration > > > > > > finalization. > > > > > > > > > > > > Why finalization was considered as done without tests passing? > > > > > > > > > > > > Why can't ve revert finalization change, re-do finalization wit= h > > > > passing > > > > > > tests and merge changes? > > > > > > > > > > > > Sincerely, > > > > > > Dmitriy Pavlov > > > > > > > > > > > > =D0=BF=D1=82, 28 =D1=81=D0=B5=D0=BD=D1=82. 2018 =D0=B3. =D0=B2 = 8:16, Vladimir Ozerov < > vozerov@gridgain.com > > >: > > > > > > > > > > > > > Test is going to be fixed in the scope of AI 2.7 [1]. This is > not > > > > > > > one-minute fix as there are multiple places where configurati= on > > > > should > > > > > be > > > > > > > passed, and changes should be covered with tests. I muted the > > test > > > > for > > > > > > now. > > > > > > > > > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-9390 > > > > > > > > > > > > > > On Fri, Sep 28, 2018 at 2:40 AM Dmitriy Setrakyan < > > > > > dsetrakyan@apache.org > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > Let's not revert any commits yet. Can we find out who did t= he > > > > commit > > > > > > and > > > > > > > > why he/she is not fixing the test? > > > > > > > > > > > > > > > > D. > > > > > > > > > > > > > > > > On Thu, Sep 27, 2018 at 4:21 PM Vyacheslav Daradur < > > > > > > daradurvs@gmail.com> > > > > > > > > wrote: > > > > > > > > > > > > > > > > > Hi, > > > > > > > > > > > > > > > > > > Are you talking about > > > > > > > > > 'IgniteConfigurationParityTest#TestIgniteConfiguration'? > > > > > > > > > > > > > > > > > > Seems it's not hard to fix this test, it's necessary just > to > > > > > > implement > > > > > > > > > missing members (at least as stubs) on .NET side in > > > > > > > > > IgniteConfiguration class. > > > > > > > > > > > > > > > > > > Is there a Jira issue? > > > > > > > > > > > > > > > > > > On Fri, Sep 28, 2018 at 2:12 AM Dmitriy Pavlov < > > > > > > dpavlov.spb@gmail.com> > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > Hi, > > > > > > > > > > > > > > > > > > > > I'm grateful for contributions made in that area, but i= t > > > seems > > > > > > folks > > > > > > > > > don't > > > > > > > > > > have time to fix the test. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Tomorrow I'm going to revert commit. > > > > > > > > > > > > > > > > > > > > It seems it is the only way we can keep master more or > less > > > > > green. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://ci.ignite.apache.org/viewLog.html?buildId=3D1888723&tab=3DbuildCh= angesDiv&buildTypeId=3DIgniteTests24Java8_PlatformNet > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Sincerely > > > > > > > > > > Dmitry Pavlov > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > Best Regards, Vyacheslav D. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > Best regards, > > Andrey V. Mashenkov > > > --000000000000c9286a0576ecab93--