From dev-return-39101-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Fri Sep 14 12:22:47 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id C40F0180647 for ; Fri, 14 Sep 2018 12:22:46 +0200 (CEST) Received: (qmail 82390 invoked by uid 500); 14 Sep 2018 10:22:45 -0000 Mailing-List: contact dev-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list dev@ignite.apache.org Received: (qmail 82378 invoked by uid 99); 14 Sep 2018 10:22:45 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 14 Sep 2018 10:22:45 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id A38AF1A0709 for ; Fri, 14 Sep 2018 10:22:44 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.869 X-Spam-Level: * X-Spam-Status: No, score=1.869 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, T_DKIMWL_WL_MED=-0.01] autolearn=disabled Authentication-Results: spamd2-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id YD5hkOc1d16l for ; Fri, 14 Sep 2018 10:22:42 +0000 (UTC) Received: from mail-qt0-f196.google.com (mail-qt0-f196.google.com [209.85.216.196]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 251435F3BA for ; Fri, 14 Sep 2018 10:22:42 +0000 (UTC) Received: by mail-qt0-f196.google.com with SMTP id r37-v6so8231351qtc.0 for ; Fri, 14 Sep 2018 03:22:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=chSjms0Cb1O98WXKJMnk3xn+BTLpsIGEONm/vJ1FYMc=; b=T2HxPTP5eQ08d8efM+TeY5+qdhKSQY28IPgAnEA7QcUvW5NL3l78aRhkmyTwlaqvH2 Uzgbehlz8cM+DBJFgyLq2/7Tk6cEEjC2DqV33NjAuESRtolbNNa1QMYORV7RrcaL790M cR0ZKs3Tgwh+9k9876lEDsjkUOQWy2njsfnhhKeeXg1QfHsWK3AtsrCjwwpKPvtJztZ5 nSXEwFfGdTtW6hJeHSlqp5ts5qojfN9WoH8A2xoG4cphUEpwoJ9oO6Y80w0iLDbRrHMZ oNb2qT3Tll2mnN5erHRUpN2J563Y7FN5lt5FrTjRHfseQFva18rYVrgD7g3xTuI/OdPW IXsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=chSjms0Cb1O98WXKJMnk3xn+BTLpsIGEONm/vJ1FYMc=; b=HBwMmazZFecFx0hI0RXdjU/TgpKhSb6wd6TdTXig97VxTxfY3zGxrHnzzl9SiHN2PT qV4A/GAJ3E3yn0C60TaD7g45byHzlgAdj8Lg5LMIwXHM4rLX8svIDPL6YfVoLJCMqR0/ 7OYlowmuwxHZ1pUZ28rgdQDrrwRP1MSg0qFurTmRXxtpOANHcjcdk0ZUshr9w6WwIimM snD1kYvn4ecHQnbTklSPL7SFQMCXCWmKfY9twgE4+g0U21pvHDgFKIMHJ4x48L2AD0Fh HXzm7tXEDneHXT+UBscp4j7YqF0E/zZ2yNaiRg30S3qlRc72UcsFV7pi5iE+W4NKoLLC wbuQ== X-Gm-Message-State: APzg51BhyBkPWn7yK7BaizWhQ/R6ZQgmNrXUPbAmBrZE5hAlDKZxegZz wMiuXEtVU1xQv8QqauIHGoLNCLZXRG3xfFYlP6LykuBc X-Google-Smtp-Source: ANB0Vdaf2yn8tewWWJAMw5WZ3xElFTeWquMUHOdB+lelDzo25xmcaADAUxEX5ORdQgGFDYelBD2vPKelp8hiOmiEito= X-Received: by 2002:ac8:23b1:: with SMTP id q46-v6mr7993633qtq.322.1536920561576; Fri, 14 Sep 2018 03:22:41 -0700 (PDT) MIME-Version: 1.0 References: <69d4fd793e7f8680a3e248658b3ca161131e8969.camel@gmail.com> <275005893.615706.1536032897519@mail.yahoo.com> <258170694.702110.1536057728946@mail.yahoo.com> <501405532.921769.1536213400079@mail.yahoo.com> <2143237922.2315546.1536461261471@mail.yahoo.com> <1020950433.3295913.1536634384580@mail.yahoo.com> In-Reply-To: <1020950433.3295913.1536634384580@mail.yahoo.com> From: Ilya Kasnacheev Date: Fri, 14 Sep 2018 13:22:30 +0300 Message-ID: Subject: Re: Apache Ignite 2.7 release To: dev@ignite.apache.org Content-Type: multipart/alternative; boundary="0000000000001ef0290575d23409" --0000000000001ef0290575d23409 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello! So now there's an issue that this script makes source change after every build, show up in git status. What we could do to it: - Commit the changes after the build, once. In hopes that it won't change very often. With benefit that we could do that right now, before the code freeze. - Move these values to a properties file from both pom.xml and IgniteProvider.java. Any problems with this approach? We'll just read them from classpath properties file. - Update the links in the file once and remove them from build process. Why were they added to build process in the first place - to make them configurable during build? Regards, --=20 Ilya Kasnacheev =D0=B2=D1=82, 11 =D1=81=D0=B5=D0=BD=D1=82. 2018 =D0=B3. =D0=B2 5:53, Roman = Shtykh : > Ilya, > > The "latest" version is the default, and resolved by > https://ignite.apache.org/latest which is used by our web site when a > user download the latest Ignite version. And I think this is the authorit= y > to judge of the latest official release (pom.xml you suggest can have > SNAPSHOTs etc.). > Also, as I explained during our review sessions, ignite-mesos-2.6.0 is a > driver and doesn't mean you need to have Ignite 2.6.0. User can run any > version of Ignite he/she specifies. By default, it's "latest" but a user > can specify any version needed, even from a non-archive URL. > > In short, what we have now > 1. mesos driver (ignite-mesos-x.x.x) will use "latest" version by default > -> it will try to resolve the latest officially releases version of Apach= e > Ignite, find the closest mirror and download Ignite in a minute. If the > version resolution fails, we fall back to the slow apache archive (as you > suggest; in my opinion we better fail-fast instead of waiting for hours t= o > download, so the user can choose another download option (3)) > 2. If the user specifies the version explicitly, it goes to the slow > apache archive. > 3. The user can put ignite zip file on his/her http server and provide th= e > URL as a parameter to the driver, if options 1 and 2 don't work. > > As you see, there are 3 options. And I just fix the 1st one with > https://issues.apache.org/jira/browse/IGNITE-9388 and don't change the > original logic (which I find reasonable) documented on our site -- I don'= t > see how it blocks anything. > > Roman Shtykh > > > On Monday, September 10, 2018, 6:16:15 p.m. GMT+9, Ilya Kasnacheev < > ilya.kasnacheev@gmail.com> wrote: > > > Hello! > > There's still two issues with the submission. > > The first one is that we're downloading "latest" version from preferred > mirror but a specified version, such as "2.6", we're also going to downlo= ad > from "slow" archive.apache.org/dist. > That's a great limitation for this change, since most real deployments of > Apache Ignite will have their Ignite version pegged to a specific release= . > But in this case there's no win in download speed. > *In my opinion it is a blocker.* > > The second one is that we can't download anything when we failed to > resolve "latest". My idea is that we should try and download last known > version in this case, which can be pushed to source from pom.xml, as we > already do with URLs. So if you could not resolve "latest" you will > download 2.7.0. > > Buuut, maybe it's not necessary, maybe we should just *discourage > "latest"*, which is in my opinion almost always a bad idea. > > WDYT? > > Regards, > -- > Ilya Kasnacheev > > > =D0=B2=D1=81, 9 =D1=81=D0=B5=D0=BD=D1=82. 2018 =D0=B3. =D0=B2 5:47, Roman= Shtykh : > > Hi Ilya, > > Sorry, missed that. > Added now. > > -- > Roman Shtykh > > > On Thursday, September 6, 2018, 6:16:58 p.m. GMT+9, Ilya Kasnacheev < > ilya.kasnacheev@gmail.com> wrote: > > > Hello! > > The last of my requests still standing is that we should fall-back to > single URL download in case of error with 'latest' version. Everything el= se > looks good to me. > > Can we do that? I'm really worried that Apache API will go sour. > > Regards, > -- > Ilya Kasnacheev > > > =D1=87=D1=82, 6 =D1=81=D0=B5=D0=BD=D1=82. 2018 =D0=B3. =D0=B2 8:56, Roman= Shtykh : > > Hi Ilya, > > Thanks again. > > 1) Done. > 2) Used catch() for latest version. > > Please see my comments on github. > -- > Roman Shtykh > > > On Wednesday, September 5, 2018, 11:30:10 p.m. GMT+9, Ilya Kasnacheev < > ilya.kasnacheev@gmail.com> wrote: > > > Hello! > > I've left a new wave of replies. > > Basically, 1) let's keep DOWNLOAD_URL_PATTERN string value inlined so > that it will work even if build process is broken (would be useful for e.= g. > developing out of IDE) > And also I urge you to catch() around new fragile Apache JSON API > resolving, and download the 'current' version instead, as defined by > ignite-mesos version. > > This is because this module is not under continuouos scrutiny so extra > care should be applied. > -- > Ilya Kasnacheev > > > =D0=B2=D1=82, 4 =D1=81=D0=B5=D0=BD=D1=82. 2018 =D0=B3. =D0=B2 13:42, Roma= n Shtykh : > > Thanks, Ilya! > I will check your comments, and discuss it at JIRA. > > -- > Roman Shtykh > > > On Tuesday, September 4, 2018, 7:17:53 p.m. GMT+9, Ilya Kasnacheev < > ilya.kasnacheev@gmail.com> wrote: > > > Hello! > > IGNITE-9408 looks > good to me and may be merged right away. > > IGNITE-9388 needs > more work in my opinion, I have commented the PR. I also advice having te= st > for this functionality. > > Regards, > -- > Ilya Kasnacheev > > > =D0=B2=D1=82, 4 =D1=81=D0=B5=D0=BD=D1=82. 2018 =D0=B3. =D0=B2 6:52, Roman= Shtykh : > > Igniters, > I would like Mesos integration update be included in the upcoming > release.Can anyone review prs for the following issues? > IGNITE-9388: mesos IgniteProvider tries to access obsolete ignite.run or > download from slow archiveIGNITE-9408: Update mesos version > > Roman Shtykh > > On Thursday, August 30, 2018, 9:25:43 p.m. GMT+9, Vyacheslav Daradur = < > daradurvs@gmail.com> wrote: > > Hi Igniters! > > I'm working on the following Service Grid tasks: > - IGNITE-8361 Use discovery messages for service deployment > - IGNITE-8362 Collect service deployment results asynchronously on > coordinator > - IGNITE-8363 Handle topology changes during service deployment > - IGNITE-8364 Propagate deployed services to joining nodes > - IGNITE-8365 Introduce service failure events > - IGNITE-3392 Propagate service deployment results from assigned nodes > to initiator > > Let's call them *phase 1* because the should be implemented together > (atomically). > > I do my best to finish phase 1 for including to 2.7 release. > > But I'm not sure that the solution will be fully completed till the > beginning of October. > > On Wed, Aug 29, 2018 at 7:18 PM Nikolay Izhikov > wrote: > > > > Hell, Yakov > > > > I'm ok with your proposal. > > > > * Scope freeze - September 17 - We should have a full list of > tickets for 2.7 here. > > * Code freeze - October 01 - We should merge all 2.7 tickets to > master here. > > * Vote on RC1 - October 11. > > * Vote on release - October 15. > > > > =D0=92 =D0=A1=D1=80, 29/08/2018 =D0=B2 12:39 +0300, Yakov Zhdanov =D0= =BF=D0=B8=D1=88=D0=B5=D1=82: > > > Nikolay, > > > > > > I think we should have 2 weeks after code freeze which by the way may > > > include RC1 voting stage. This way I would like us to agree that > release > > > candidate should be sent to vote on Oct, 11th and we can release on > Oct, > > > 15th. > > > > > > What do you think? > > > > > > --Yakov > > > > -- > Best Regards, Vyacheslav D. > > --0000000000001ef0290575d23409--