From dev-return-39490-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Fri Sep 21 16:03:18 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id C2B65180656 for ; Fri, 21 Sep 2018 16:03:17 +0200 (CEST) Received: (qmail 69876 invoked by uid 500); 21 Sep 2018 14:03:16 -0000 Mailing-List: contact dev-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list dev@ignite.apache.org Received: (qmail 69864 invoked by uid 99); 21 Sep 2018 14:03:16 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 21 Sep 2018 14:03:16 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id B691AC1CDD for ; Fri, 21 Sep 2018 14:03:15 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.888 X-Spam-Level: ** X-Spam-Status: No, score=2.888 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_REPLY=1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, T_DKIMWL_WL_MED=-0.01] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id O2kw90P8qHip for ; Fri, 21 Sep 2018 14:03:14 +0000 (UTC) Received: from mail-io1-f52.google.com (mail-io1-f52.google.com [209.85.166.52]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id CF8705F23D for ; Fri, 21 Sep 2018 14:03:13 +0000 (UTC) Received: by mail-io1-f52.google.com with SMTP id y10-v6so12282745ioa.10 for ; Fri, 21 Sep 2018 07:03:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=Ei9aC4zZXgtVgtv8WYT/C270WrHKdtJnDQwM/RLTcow=; b=h2Zdz5FoYYHWl15ngNjPa+vCBK3Hryx0M4Im0Op5zcxC0K9QaNIj3AeYdu6YfnHKNp lcKi8clMHb7GEsUtGxWr7vzCvVwBVUS3gAklS6Qs2Cfdu060HM4+U4Jg0bi9n57lLRQd l+JMW69MMDTyGdRMw5128z1EaZ8921Oc8l48NY9dFUFTUMdjZ6WZxNxXQwFg2YHnFjN9 efZglDeFM11faWbHvrKPPzDDhIp+qOwfR6e33GPrQjP9kiobAuQDhYNtvfRSf7dxt6L+ NqYCHG4W4pttYNHiKuWuodTrIR0yaiTwIPevjKvAlfGSWDPDWs+a9I5j+HxRwqKia88j 0n5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=Ei9aC4zZXgtVgtv8WYT/C270WrHKdtJnDQwM/RLTcow=; b=reeKBtgm7xBqxKUCqewEyPCT7JAN7QCNPv5zta1/XFGj0arVA+HgpO0sOoInRFGW7L HC9AmFZ8YZUoFMFLmLovYTFx8cixzn3BL56HVu6E2btRovOc3NhR6mtlEPu8inu8dshe d8KMMrnI8gGLMUh3gdMhPYcRtlv/ERkXZtcFW8HAhpIIPs0+Ys1WP+jmrT8Q7fBSKG5X Lld0AL4fpp4qS11WLGkk/J0+P1QcNyJzeee5+aGUuORchKbxxZoMzK77JnmHfWl41ape OQeVk+ruKHaLx30GkgXj2RiGegM8qDNTDARzA4HvSz2BIGWl0o2H0/mNUvO9IU8SsBei GeXQ== X-Gm-Message-State: APzg51Cs3hLQtWWETozA7QPsTQckMcTv0L2Pvg3RP50r1jBCUB4VFnEM /DYlHrlnDoF58WavKw/yX7S25w4AcdH4Rlw/5gy++g== X-Google-Smtp-Source: ANB0VdaQR9OLDNZ5RQRUNRmLBp70ptDVEuxtPQpGI3lGFPWjbe36i3Z2uEuTd1cXzozXmyeNPW3I51VN7TanaHfESn4= X-Received: by 2002:a5e:c10b:: with SMTP id v11-v6mr37168354iol.262.1537538593010; Fri, 21 Sep 2018 07:03:13 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Andrey Kuznetsov Date: Fri, 21 Sep 2018 17:03:01 +0300 Message-ID: Subject: Re: Switching to real FailureHandler in tests To: dev Content-Type: multipart/alternative; boundary="000000000000aa3848057662190d" --000000000000aa3848057662190d Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thanks to all for participating the discussion. I've updated [1]: now it requires new handler from [2] for completion. [1] https://issues.apache.org/jira/browse/IGNITE-9660 [2] https://issues.apache.org/jira/browse/IGNITE-8227 =D1=87=D1=82, 20 =D1=81=D0=B5=D0=BD=D1=82. 2018 =D0=B3. =D0=B2 21:56, Vladi= mir Ozerov : > Stop node handler is not very good choice. Some test will continue work a= s > usual even if some node failed. E.g. SQL queries with backups may continu= e > function in some cases, especially if these are test with REPLICATED cach= e. > > New test-scope handler looks like a better candidate to me. > > =D1=87=D1=82, 20 =D1=81=D0=B5=D0=BD=D1=82. 2018 =D0=B3. =D0=B2 21:22, And= rey Kuznetsov : > > > I meant the first comment in [1]. We are to decide first whether we'll = do > > it or not. > > > > [1] https://issues.apache.org/jira/browse/IGNITE-8227 > > < > > > https://issues.apache.org/jira/browse/IGNITE-8227?focusedCommentId=3D1643= 5298&page=3Dcom.atlassian.jira.plugin.system.issuetabpanels:comment-tabpane= l#comment-16435298 > > > > > > > =D1=87=D1=82, 20 =D1=81=D0=B5=D0=BD=D1=82. 2018 =D0=B3. =D0=B2 21:18, D= mitriy Pavlov : > > > > > Sorry, incomplete message. > > > > > > Why do you think there is no consensus? > > > > > > I have no clue what can be a reason for another approach. > > > By default failure handler should fail all test. > > > > > > Failure handlers test will be always a minority of tests, so fail > handler > > > call is something abnormal. > > > > > > =D1=87=D1=82, 20 =D1=81=D0=B5=D0=BD=D1=82. 2018 =D0=B3. =D0=B2 21:15,= Dmitriy Pavlov : > > > > > > > Why do you think there is no consensus? > > > > > > > > I have no clue that by default failure handler should fail all test= . > > > > > > > > =D1=87=D1=82, 20 =D1=81=D0=B5=D0=BD=D1=82. 2018 =D0=B3. =D0=B2 21:1= 0, Andrey Kuznetsov : > > > > > > > >> I've created [1] to address this. > > > >> > > > >> Dmitriy, I like your idea of creating special test-scope handler. > But > > > >> there > > > >> is no consensus about it, so I don't want to rely on that potentia= l > > > >> handler > > > >> right now. We can switch to it later, of course. > > > >> > > > >> [1] https://issues.apache.org/jira/browse/IGNITE-9660 > > > >> > > > >> =D1=87=D1=82, 20 =D1=81=D0=B5=D0=BD=D1=82. 2018 =D0=B3. =D0=B2 20:= 03, Maxim Muzafarov : > > > >> > > > >> > Andrey, > > > >> > > > > >> > I like your idea. > > > >> > > > > >> > After changing the default node failure handler to the new one w= e > > > should > > > >> > carefully review the whole new test failures. For instance, > calling > > > this > > > >> > method in tests should not lead test to the node being stopped: > > > >> > > > > >> > FOR TEST ONLY!!! > > > >> > TcpDiscoverySpi#simulateNodeFailure > > > >> > > > > >> > BTW, I would like to remove this method at all from production > code. > > > >> > > > > >> > On Thu, 20 Sep 2018 at 19:43 Dmitriy Pavlov < > dpavlov.spb@gmail.com> > > > >> wrote: > > > >> > > > > >> > > But the totally ideal situation would be finding a way to fail > the > > > >> test > > > >> > by > > > >> > > default, not only stopping a node. > > > >> > > > > > >> > > Some time ago I've created > > > >> > > https://issues.apache.org/jira/browse/IGNITE-8227 to > > > >> > > find out a way to do so. > > > >> > > > > > >> > > =D1=87=D1=82, 20 =D1=81=D0=B5=D0=BD=D1=82. 2018 =D0=B3. =D0=B2= 19:40, Dmitriy Pavlov < > > dpavlov.spb@gmail.com > > > >: > > > >> > > > > > >> > > > ++1 > > > >> > > > > > > >> > > > =D1=87=D1=82, 20 =D1=81=D0=B5=D0=BD=D1=82. 2018 =D0=B3. =D0= =B2 19:39, Andrey Kuznetsov < > > stkuzma@gmail.com > > > >: > > > >> > > > > > > >> > > >> Igniters, > > > >> > > >> > > > >> > > >> While running tests I see a lot of ignored critical failure= s > > > >> caused by > > > >> > > >> {{NoOpFailureHandler}} that we use by default. In some test= s, > > of > > > >> > cource, > > > >> > > >> critical failures are the part of normal workflow, but in t= he > > > >> majority > > > >> > > of > > > >> > > >> tests they indicate bugs. By using {{NoOpFailureHandler}} w= e > > just > > > >> hide > > > >> > > >> these bugs from ourselves. > > > >> > > >> > > > >> > > >> What do you think about changing default handler to > > > >> > > >> {{StopNodeFailureHandler}} at {{GridAbstractTest}} level? > This > > > >> could > > > >> > be > > > >> > > >> overridden in subclasses. > > > >> > > >> > > > >> > > >> -- > > > >> > > >> Best regards, > > > >> > > >> Andrey Kuznetsov. > > > >> > > >> > > > >> > > > > > > >> > > > > > >> > -- > > > >> > -- > > > >> > Maxim Muzafarov > > > >> > > > > >> > > > >> > > > >> -- > > > >> Best regards, > > > >> Andrey Kuznetsov. > > > >> > > > > > > > > > > > > > -- > > Best regards, > > Andrey Kuznetsov. > > > --=20 Best regards, Andrey Kuznetsov. --000000000000aa3848057662190d--