ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexey Kosenchuk <alexey.kosenc...@nobitlost.com>
Subject Re: PHP thin client
Date Thu, 13 Sep 2018 14:07:46 GMT
11.09.2018 14:46, Igor Sapego пишет:
> 1) I meant auto-generated doc, this page: [1]. By the way,
>      many methods do not have any description as well.

Updated - introduction sentences placed on the main page of the 
autogenerated API spec.
All public methods have description, except setters for cache 
configuration which do not need it.

> 2) You can, for example, print object as you generate and
>      then get them from cache.

Done.

> 3) Yes, 10800 should be the default port.

Done.

All changes are in the updated PR.

> 4) You are right, I've just used server with SSL enabled.
>      Everything works now.

Good.

> 5) Ok, can you just provide a list of directories/files, that
>      should be copied to binary release?

ignite/modules/platforms/php/composer.json
ignite/modules/platforms/php/src
ignite/modules/platforms/php/examples

If cfg file to generate the API spec should be in the release
ignite/modules/platforms/php/api_docs/Doxyfile

If tests should be in the release
ignite/modules/platforms/php/tests

Regards,
-Alexey

> 
> [1] -
> https://rawgit.com/nobitlost/ignite/ignite-7783-docs/modules/platforms/php/api_docs/html/index.html
> 
> Best Regards,
> Igor
> 
> 
> On Tue, Sep 11, 2018 at 1:31 AM Alexey Kosenchuk <
> alexey.kosenchuk@nobitlost.com> wrote:
> 
>> Hi Igor,
>>
>> thanks for the review.
>>
>> Pls see below...
>>
>>   >> 1. Main page for documentation is empty.
>>
>> What is the main page for documentation?
>>
>> As wrote,
>> the auto-generated API spec is here:
>>
>> https://rawgit.com/nobitlost/ignite/ignite-7783-docs/modules/platforms/php/api_docs/html/index.html
>>
>> All other docs are here:
>>
>> https://github.com/nobitlost/ignite/blob/ignite-7783-docs/modules/platforms/php/README.md
>> Going to be placed on readme.io by Prachi (thanks!)
>> https://issues.apache.org/jira/browse/IGNITE-9523
>>
>>   >> 2. More output for Auth example is needed. This is not a test, after
>> all, but example.
>>
>> Will add a log when a connection happens with the details of the
>> connection. Nothing else to output in this trivial example.
>> In fact, the real profit for a user here is the source code with an
>> example of TLS/auth cfg for the client.
>>
>>   >> 3. If I try run test with APACHE_IGNITE_CLIENT_ENDPOINTS=127.0.0.1,
>> they fail
>>
>> Do you mean 10800 should be the default port when not specified by a user?
>> Will add.
>>
>>   >> 4. If I try run test with
>> APACHE_IGNITE_CLIENT_ENDPOINTS=127.0.0.1:10800, they fail
>>
>> Double checked exactly in the same environment you have. It works.
>>
>> Please try again.
>> Do you use a server with all default settings? Did not you try with the
>> server after the Auth example?
>> Do other examples work with the same server?
>> If you still see the problem with the tests, please send the server's
>> log to us. And/or switch the client's debug on - call setDebug(true) -
>> and share the client's output.
>>
>>   >> 5. When "maven package" command is executed on Ignite, no php
>> directory appears
>>
>> Need a help from experts / release engineer.
>>
>> Thanks,
>> -Alexey
>>
>> 10.09.2018 15:34, Igor Sapego пишет:
>>> By the way, I used Ubuntu 18.04, PHP 7.2.7 and what seems
>>> to be PhpUnit 7.3 (not sure here).
>>>
>>> Best Regards,
>>> Igor
>>>
>>>
>>> On Mon, Sep 10, 2018 at 3:28 PM Igor Sapego <isapego@apache.org> wrote:
>>>
>>>> Guys, I've reviewed the API (which looks good), run tests and examples
>> and
>>>> here are my commments:
>>>>
>>>> 1. Main page for documentation is empty.
>>>>
>>>> 2. More output for Auth example is needed. This is not a test, after
>> all,
>>>> but example.
>>>>
>>>> 3. If I try run test with APACHE_IGNITE_CLIENT_ENDPOINTS=127.0.0.1, they
>>>> fail with the following message:
>>>> Apache\Ignite\Exception\NoConnectionException: [127.0.0.1] Failed to
>> parse
>>>> address "127.0.0.1" in
>>>>
>> /home/isapego/work/ignite/modules/platforms/php/src/Apache/Ignite/Internal/Connection/ClientFailoverSocket.php:107
>>>> Stack trace:
>>>> #0
>>>>
>> /home/isapego/work/ignite/modules/platforms/php/src/Apache/Ignite/Internal/Connection/ClientFailoverSocket.php(54):
>>>>
>> Apache\Ignite\Internal\Connection\ClientFailoverSocket->failoverConnect()
>>>> #1
>>>>
>> /home/isapego/work/ignite/modules/platforms/php/src/Apache/Ignite/Client.php(61):
>>>>
>> Apache\Ignite\Internal\Connection\ClientFailoverSocket->connect(Object(Apache\Ignite\ClientConfiguration))
>>>> #2
>>>>
>> /home/isapego/work/ignite/modules/platforms/php/tests/TestingHelper.php(52):
>>>> Apache\Ignite\Client->connect(Object(Apache\Ignite\ClientConfiguration))
>>>> #3
>>>>
>> /home/isapego/work/ignite/modules/platforms/php/tests/SqlQueryTest.php(49):
>>>> Apache\Ignite\Tests\TestingHelper::init()
>>>> #4
>>>>
>> /home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/src/Framework/TestSuite.php(703):
>>>> Apache\Ignite\Tests\SqlQueryTestCase::setUpBeforeClass()
>>>> #5
>>>>
>> /home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/src/Framework/TestSuite.php(750):
>>>> PHPUnit\Framework\TestSuite->run(Object(PHPUnit\Framework\TestResult))
>>>> #6
>>>>
>> /home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/src/TextUI/TestRunner.php(587):
>>>> PHPUnit\Framework\TestSuite->run(Object(PHPUnit\Framework\TestResult))
>>>> #7
>>>>
>> /home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/src/TextUI/Command.php(203):
>>>> PHPUnit\TextUI\TestRunner->doRun(Object(PHPUnit\Framework\TestSuite),
>>>> Array, true)
>>>> #8
>>>>
>> /home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/src/TextUI/Command.php(159):
>>>> PHPUnit\TextUI\Command->run(Array, true)
>>>> #9
>>>>
>> /home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/phpunit(53):
>>>> PHPUnit\TextUI\Command::main()
>>>> #10 {main}
>>>>
>>>> 4. If I try run test with APACHE_IGNITE_CLIENT_ENDPOINTS=
>> 127.0.0.1:10800,
>>>> they fail with the following message:
>>>> Apache\Ignite\Exception\OperationStatusUnknownException: Error while
>>>> reading data from the server in
>>>>
>> /home/isapego/work/ignite/modules/platforms/php/src/Apache/Ignite/Internal/Connection/ClientSocket.php:168
>>>> Stack trace:
>>>> #0
>>>>
>> /home/isapego/work/ignite/modules/platforms/php/src/Apache/Ignite/Internal/Connection/ClientSocket.php(178):
>>>>
>> Apache\Ignite\Internal\Connection\ClientSocket->receive(Object(Apache\Ignite\Internal\Binary\MessageBuffer),
>>>> 4)
>>>> #1
>>>>
>> /home/isapego/work/ignite/modules/platforms/php/src/Apache/Ignite/Internal/Connection/ClientSocket.php(159):
>>>>
>> Apache\Ignite\Internal\Connection\ClientSocket->processResponse(Object(Apache\Ignite\Internal\Binary\Request))
>>>> #2
>>>>
>> /home/isapego/work/ignite/modules/platforms/php/src/Apache/Ignite/Internal/Connection/ClientSocket.php(107):
>>>>
>> Apache\Ignite\Internal\Connection\ClientSocket->processRequest(Object(Apache\Ignite\Internal\Binary\Request))
>>>> #3
>>>>
>> /home/isapego/work/ignite/modules/platforms/php/src/Apache/Ignite/Internal/Connection/ClientFailoverSocket.php(96):
>>>> Apache\Ignite\Internal\Connection\ClientSocket->connect()
>>>> #4
>>>>
>> /home/isapego/work/ignite/modules/platforms/php/src/Apache/Ignite/Internal/Connection/ClientFailoverSocket.php(54):
>>>>
>> Apache\Ignite\Internal\Connection\ClientFailoverSocket->failoverConnect()
>>>> #5
>>>>
>> /home/isapego/work/ignite/modules/platforms/php/src/Apache/Ignite/Client.php(61):
>>>>
>> Apache\Ignite\Internal\Connection\ClientFailoverSocket->connect(Object(Apache\Ignite\ClientConfiguration))
>>>> #6
>>>>
>> /home/isapego/work/ignite/modules/platforms/php/tests/TestingHelper.php(52):
>>>> Apache\Ignite\Client->connect(Object(Apache\Ignite\ClientConfiguration))
>>>> #7
>>>>
>> /home/isapego/work/ignite/modules/platforms/php/tests/SqlQueryTest.php(49):
>>>> Apache\Ignite\Tests\TestingHelper::init()
>>>> #8
>>>>
>> /home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/src/Framework/TestSuite.php(703):
>>>> Apache\Ignite\Tests\SqlQueryTestCase::setUpBeforeClass()
>>>> #9
>>>>
>> /home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/src/Framework/TestSuite.php(750):
>>>> PHPUnit\Framework\TestSuite->run(Object(PHPUnit\Framework\TestResult))
>>>> #10
>>>>
>> /home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/src/TextUI/TestRunner.php(587):
>>>> PHPUnit\Framework\TestSuite->run(Object(PHPUnit\Framework\TestResult))
>>>> #11
>>>>
>> /home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/src/TextUI/Command.php(203):
>>>> PHPUnit\TextUI\TestRunner->doRun(Object(PHPUnit\Framework\TestSuite),
>>>> Array, true)
>>>> #12
>>>>
>> /home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/src/TextUI/Command.php(159):
>>>> PHPUnit\TextUI\Command->run(Array, true)
>>>> #13
>>>>
>> /home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/phpunit(53):
>>>> PHPUnit\TextUI\Command::main()
>>>> #14 {main}
>>>>       Am I doing something wrong?
>>>>
>>>> 5. When "maven package" command is executed on Ignite, no php directory
>>>> appears
>>>>       in target/release-package-fabric/platforms directory. You need to
>> edit
>>>>       ignite/assembly/release-fabric-base.xml file and add appropriate
>>>> "copy" commands.
>>>>       Search "cpp" or "dotnet" for example.
>>>>
>>>> Best Regards,
>>>> Igor
>>>>
>>>>
>>>> On Tue, Sep 4, 2018 at 3:21 PM Igor Sapego <isapego@apache.org> wrote:
>>>>
>>>>> Great,
>>>>>
>>>>> I'll take a look
>>>>>
>>>>> Best Regards,
>>>>> Igor
>>>>>
>>>>>
>>>>> On Wed, Aug 29, 2018 at 10:37 PM Alexey Kosenchuk <
>>>>> alexey.kosenchuk@nobitlost.com> wrote:
>>>>>
>>>>>> Hi folks,
>>>>>>
>>>>>> PHP thin client is ready for review.
>>>>>>
>>>>>> Jira with the scope of work - [1].
>>>>>>
>>>>>> Implementation, examples, tests:
>>>>>>      PR - [2],
>>>>>>      repository - [3].
>>>>>>
>>>>>> API spec - [4].
>>>>>>
>>>>>> Readme (how to for the client, instructions for the examples and
>> tests,
>>>>>> etc.) - [5].
>>>>>>
>>>>>> Regards,
>>>>>> -Alexey
>>>>>>
>>>>>> [1] https://issues.apache.org/jira/browse/IGNITE-7783
>>>>>> [2] https://github.com/apache/ignite/pull/4649
>>>>>> [3]
>>>>>>
>>>>>>
>> https://github.com/nobitlost/ignite/tree/ignite-7783/modules/platforms/php
>>>>>> [4]
>>>>>>
>>>>>>
>> https://rawgit.com/nobitlost/ignite/ignite-7783-docs/modules/platforms/php/api_docs/html/index.html
>>>>>> [5]
>>>>>>
>>>>>>
>> https://github.com/nobitlost/ignite/blob/ignite-7783-docs/modules/platforms/php/README.md
>>>>>>
>>>>>
>>>
>>
> 

Mime
View raw message