ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dmitriy Pavlov <dpavlov....@gmail.com>
Subject Re: [GitHub] SomeFire commented on a change in pull request #14: Performance
Date Wed, 19 Sep 2018 17:51:04 GMT
Hi Dmitriy Ryabov,

could you please create and share INFRA ticket to disable comment
forwarding to the dev list?

Sincerely,
Dmitriy Pavlov

ср, 19 сент. 2018 г. в 19:02, GitBox <git@apache.org>:

> SomeFire commented on a change in pull request #14: Performance
> URL:
> https://github.com/apache/ignite-teamcity-bot/pull/14#discussion_r218863424
>
>
>
>  ##########
>  File path:
> ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/issue/IssueDetector.java
>  ##########
>  @@ -386,15 +386,17 @@ private void checkFailures() {
>      private void checkFailuresEx() {
>          int buildsToQry =
> EventTemplates.templates.stream().mapToInt(EventTemplate::cntEvents).max().getAsInt();
>
> +        ExecutorService executor =
> MoreExecutors.newDirectExecutorService();
> +
>
>  GetTrackedBranchTestResults.getTrackedBranchTestFailures(FullQueryParams.DEFAULT_BRANCH_NAME,
> -            false, buildsToQry, backgroundOpsTcHelper,
> backgroundOpsCreds);
> +            false, buildsToQry, backgroundOpsTcHelper,
> backgroundOpsCreds, executor);
>
>          TestFailuresSummary failures =
>
>  GetTrackedBranchTestResults.getTrackedBranchTestFailures(FullQueryParams.DEFAULT_BRANCH_NAME,
>                  false,
>                  1,
>                  backgroundOpsTcHelper,
> -                backgroundOpsCreds);
> +                backgroundOpsCreds, executor);
>
>  Review comment:
>    Move executor to a new line.
>
> ----------------------------------------------------------------
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on GitHub and use the
> URL above to go to the specific comment.
>
> For queries about this service, please contact Infrastructure at:
> users@infra.apache.org
>
>
> With regards,
> Apache Git Services
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message