ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Maxim Muzafarov <maxmu...@gmail.com>
Subject Re: Switching to real FailureHandler in tests
Date Thu, 20 Sep 2018 17:03:00 GMT
Andrey,

I like your idea.

After changing the default node failure handler to the new one we should
carefully review the whole new test failures. For instance, calling this
method in tests should not lead test to the node being stopped:

<strong>FOR TEST ONLY!!!</strong>
TcpDiscoverySpi#simulateNodeFailure

BTW, I would like to remove this method at all from production code.

On Thu, 20 Sep 2018 at 19:43 Dmitriy Pavlov <dpavlov.spb@gmail.com> wrote:

> But the totally ideal situation would be finding a way to fail the test by
> default, not only stopping a node.
>
> Some time ago I've created
> https://issues.apache.org/jira/browse/IGNITE-8227 to
> find out a way to do so.
>
> чт, 20 сент. 2018 г. в 19:40, Dmitriy Pavlov <dpavlov.spb@gmail.com>:
>
> > ++1
> >
> > чт, 20 сент. 2018 г. в 19:39, Andrey Kuznetsov <stkuzma@gmail.com>:
> >
> >> Igniters,
> >>
> >> While running tests I see a lot of ignored critical failures caused by
> >> {{NoOpFailureHandler}} that we use by default. In some tests, of cource,
> >> critical failures are the part of normal workflow, but in the majority
> of
> >> tests they indicate bugs. By using {{NoOpFailureHandler}} we just hide
> >> these bugs from ourselves.
> >>
> >> What do you think about changing default handler to
> >> {{StopNodeFailureHandler}} at {{GridAbstractTest}} level? This could be
> >> overridden in subclasses.
> >>
> >> --
> >> Best regards,
> >>   Andrey Kuznetsov.
> >>
> >
>
-- 
--
Maxim Muzafarov

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message