ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Eduard Shangareev <eduard.shangar...@gmail.com>
Subject Re: ignite PureJavaCrc32 vs java.util.zip.CRC32 bench.
Date Mon, 13 Aug 2018 21:19:59 GMT
Evgeniy,

Could you share benchmark code? And please share what version of JVM
you have used.

On Mon, Aug 13, 2018 at 10:44 PM Zhenya <arzamas123@mail.ru.invalid> wrote:

> I think it would break backward compatibility, as Nikolay mentioned above
> we would take exception here:
>
> [1]
>
> https://github.com/apache/ignite/blob/master/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/file/FilePageStore.java#L372
>
> thats why i question for community thoughts here.
>
> > Hi Evgeniy,
> >
> > would you like to submit a patch with CRC32 implementation change?
> >
> > Sincerely,
> > Dmitriy Pavlov
> >
> > пн, 13 авг. 2018 г. в 22:08, Евгений Станиловский
> > <arzamas123@mail.ru.invalid>:
> >
> >> Hi, igniters, i wrote a simple bench, looks like PureJavaCrc32 has
> >> performance problems in compatible with zip.CRC32.
> >>
> >> Benchmark Mode Cnt Score Error Units
> >> BenchmarkCRC.Crc32 avgt 5 1088914.540 ± 368851.822 ns/op
> >> BenchmarkCRC.pureJavaCrc32 avgt 5 6619408.049 ± 3746712.210 ns/op
> >>
> >> thoughts?
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message