From dev-return-36760-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Fri Jul 20 12:27:17 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id CF8DE180663 for ; Fri, 20 Jul 2018 12:27:16 +0200 (CEST) Received: (qmail 64231 invoked by uid 500); 20 Jul 2018 10:27:15 -0000 Mailing-List: contact dev-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list dev@ignite.apache.org Received: (qmail 64219 invoked by uid 99); 20 Jul 2018 10:27:15 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 20 Jul 2018 10:27:15 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id BB28DC00C7 for ; Fri, 20 Jul 2018 10:27:14 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.869 X-Spam-Level: * X-Spam-Status: No, score=1.869 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, T_DKIMWL_WL_MED=-0.01] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id DvZ-hVY3JMIp for ; Fri, 20 Jul 2018 10:27:13 +0000 (UTC) Received: from mail-oi0-f46.google.com (mail-oi0-f46.google.com [209.85.218.46]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id A533E5F401 for ; Fri, 20 Jul 2018 10:27:12 +0000 (UTC) Received: by mail-oi0-f46.google.com with SMTP id s198-v6so20447849oih.11 for ; Fri, 20 Jul 2018 03:27:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=KKqYP2IzloB5AYPpJN+25AQ/Kk2UnVyv3S3n1r3bvK4=; b=Bx32e+KFhYG5SKvsql+qvGAJg+WUePXD/DLm1LBgHlRoCkWT65GEVWl0TVcQyYUx6n qQT2KoetI+HvbVh20+hRVakDmwEleVkLMGLpX8lre7b6Gl6MC4JIbZaqJwMomc2The90 xD2gDdImAysO1w+7SJ87uU+EO3E99GbHzKegWASdBVYeyjc2iPQoJa9yRwMZp/kM/8mK rJiJMPyYRqpVfaywp/DQE1lQoEjJkM/NoBT7JWZYbkROAhtJikmccPELWTJO9vcrTHLv 9Vh1tj/LAukeE546tBITFKCWvNbR50lvvq4MtgunwYZD9KhgC00AkfgrO/tm3XmJFeQT OzWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=KKqYP2IzloB5AYPpJN+25AQ/Kk2UnVyv3S3n1r3bvK4=; b=IkV+eooS76dcNOPL5QfVZJQhgzaBGUrKE3urZFpU43HKpcf6PT3qQ4mqIcwPqHFcoA B+rVvxxeSujCRDPlchDgf+fNhN2gCb74A5H+WwuWXaOYDAPpZN5GUgScY9Le8/AZKlPy n5SPUotgZ+DneSgywIWwT+lwj984Oo1Lq3RzwhMrFVyn8PFkA8lb2KSoAzyQ2f45iaLE ngMQtfrXHpZGX7a9Gwly/+p18yLFTzo8uqZ02ucFr5NfiMji1M1hr+7T/UvA/vW/TJ/b 2QkTNe9ZR67J1irhSAqhID0+mDUsgOdFuohGhb88xFcwXQGmJBbHreReiV7Fr4KTasjA Tpmg== X-Gm-Message-State: AOUpUlHhzFeKJ9m9oTJzx4owedclFScMtW9cZrwAAu52dXGerDABH/H4 QTbdve0BkkwDxAqC3Sej/TWy80/aWV2FkjKyY+mPnQ== X-Google-Smtp-Source: AAOMgpfq5P7WRwcFhrEdn6W5VEa+UaCmZ804ANoFjD7KPZOCCBQkoh9V/Q34FaFgoVpTYiVZJJNKBDfA0eKlsFLPqxg= X-Received: by 2002:aca:bbc4:: with SMTP id l187-v6mr1296922oif.278.1532082431053; Fri, 20 Jul 2018 03:27:11 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Dmitry Pavlov Date: Fri, 20 Jul 2018 13:27:01 +0300 Message-ID: Subject: Re: GridCacheReplicatedFullApiMultithreadedSelfTest1 not used, not compile. Remove? To: dev@ignite.apache.org, Ilya Kasnacheev Content-Type: multipart/alternative; boundary="00000000000011d47005716bbd29" --00000000000011d47005716bbd29 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Maxim, I think we should remove such code. And if nobody objects I can apply PR on Monday. Ilya, please confirm you're agree. Sincerely, Dmitriy Pavlov =D0=BF=D1=82, 20 =D0=B8=D1=8E=D0=BB. 2018 =D0=B3. =D0=B2 13:16, Maxim Muzaf= arov : > Ignites, > > I've faced with test in Ignite code base that is fully commented. You can > check it > by yoursefl [1]. As it not used since 2014 and not even compile I'm > suggesting > to remove it. > > What do you think about it? Please, share your thoughts. > > Full name: > > org.apache.ignite.internal.processors.cache.distributed.replicated.GridCa= cheReplicatedFullApiMultithreadedSelfTest1 > > [1] > > https://github.com/apache/ignite/blob/master/modules/core/src/test/java/o= rg/apache/ignite/internal/processors/cache/distributed/replicated/GridCache= ReplicatedFullApiMultithreadedSelfTest1.java > -- > -- > Maxim Muzafarov > --00000000000011d47005716bbd29--