From dev-return-37037-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Thu Jul 26 16:42:01 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 7EF43180621 for ; Thu, 26 Jul 2018 16:42:00 +0200 (CEST) Received: (qmail 9248 invoked by uid 500); 26 Jul 2018 14:41:59 -0000 Mailing-List: contact dev-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list dev@ignite.apache.org Received: (qmail 9236 invoked by uid 99); 26 Jul 2018 14:41:58 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 26 Jul 2018 14:41:58 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 5E568C0918 for ; Thu, 26 Jul 2018 14:41:58 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.869 X-Spam-Level: * X-Spam-Status: No, score=1.869 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, T_DKIMWL_WL_MED=-0.01] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 6aTK66EwAKjF for ; Thu, 26 Jul 2018 14:41:57 +0000 (UTC) Received: from mail-qt0-f171.google.com (mail-qt0-f171.google.com [209.85.216.171]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 2B2BF5F260 for ; Thu, 26 Jul 2018 14:41:57 +0000 (UTC) Received: by mail-qt0-f171.google.com with SMTP id b15-v6so1765698qtp.11 for ; Thu, 26 Jul 2018 07:41:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=PxnUUajwt1LajGHwl26I9jFgecvGrunBJ1fAplAG/0U=; b=SkCxEd1QF9UJ4s8obFu8c/+GHHWyjju19kKTFCtwz2noPebYinZC8LntsWESEBKNpq 2qnYNslu7jvVJimODn6f7653tMffyW8yDtbIp+xpKwgx4mdnifYGliho0JdIzyv5gmc2 /Zmui5b1puxnFAQgIjt2s1NB3GtILS4VCek6oO3Sr2LBHtrePstIP8xZoaNF2KjuB/V6 +Sjc84TCpubEcTkAc+M7xxzgFyCZOFtgMD1uIqH3OMdruKGP7fQxajuPSIixcge7DoNv 1aepQhdD/Ttc9sd0T+X/dSet0yeueT8dFB5ZPdHmhP6lAp/l09Z8+BwDBRy0lcjdoSQB U1mQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=PxnUUajwt1LajGHwl26I9jFgecvGrunBJ1fAplAG/0U=; b=KDZ4QFGA2IbuMtrKp7cCD/9b5B1/0lZIXAhYN7fnUNrwSMI01ZH/KHH65UxphSx83O D34cKAqox38FW4IuV0uFbpnlNkLqdpMcemejlsgw2lijh3uClUGDxeaEslyDZpekW9/O NdnCtw6MLd4u4Md6Akj7Vr2PcW/EaZQtE0uUFlzu7UPnyNOu0iLMlLMBARaDLBTDOJFC VNCehHRbhQZddhfGQad3psjaP4ke8/TXvrblGMurWZhGNHo1w/Wz6/ECXgUY8h3/mwKi fPzu33xf80+CvQmvmfMlFRRUFEhp0OHAzk4hyb9ZNkC98WdPzY7naWdCLzGTw34FkU+C Z3GQ== X-Gm-Message-State: AOUpUlH4wKzpJ69RyBCNqD8Bjn+nc1uyjWPQWmKWY7GA6NPnYGzMXYas sWuNdGyIS8sIEVLOqQMr5nkifwvyp8rRDU74GkpkkA== X-Google-Smtp-Source: AAOMgpejo6Itd6FAG8Rg5/kN22oOHVBaIloBE2ehJiHY8961Drts+dbAYomrpbzUD4EGMG47AejP+Vi+lVLQlIzIG3g= X-Received: by 2002:ac8:2a61:: with SMTP id l30-v6mr2121053qtl.238.1532616115708; Thu, 26 Jul 2018 07:41:55 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:ac8:3214:0:0:0:0:0 with HTTP; Thu, 26 Jul 2018 07:41:55 -0700 (PDT) In-Reply-To: References: <1d708cb7-b645-1f49-384f-d0859c6cd539@nobitlost.com> <88c0cd6a-82cc-9658-fb21-1455be38e0e8@nobitlost.com> <43a89828-7e5a-2098-9646-fd594e541c26@nobitlost.com> <91e9fdb3-435f-2b6b-9de1-9eb96e5a4d19@nobitlost.com> <6f4fdc75-f765-d7c8-08da-454ce7174131@nobitlost.com> <5b64ea37-862e-0ddd-73f7-ec46d1b488de@nobitlost.com> From: Ilya Kasnacheev Date: Thu, 26 Jul 2018 17:41:55 +0300 Message-ID: Subject: Re: Thin Client lib: Python To: dev@ignite.apache.org Content-Type: multipart/alternative; boundary="00000000000027680e0571e7ff81" --00000000000027680e0571e7ff81 Content-Type: text/plain; charset="UTF-8" Hello! I expect the effect to be neligible, and UX gain is well worth it. In case it will ever become a sensitive issue, hashcode-based operation might be retained as mentioned earlier. Regards, -- Ilya Kasnacheev 2018-07-26 17:39 GMT+03:00 Igor Sapego : > Ilya, > > This may affect performance in a negative way, as it requires > additional hashcode calculation on every cache operation. > > Best Regards, > Igor > > > On Thu, Jul 26, 2018 at 5:02 PM Ilya Kasnacheev > > wrote: > > > Hello! > > > > I think that having both options is indeed preferable. > > > > Regards, > > > > -- > > Ilya Kasnacheev > > > > 2018-07-26 16:51 GMT+03:00 Dmitry Melnichuk < > > dmitry.melnichuk@nobitlost.com> > > : > > > > > Hi, Ilya! > > > > > > I considered this option. Indeed, the code would look cleaner if only > one > > > kind of identifier (preferably the human-readable name) was used. But > > there > > > can be a hypothetical situation, when the user is left with hash code > > only. > > > (For example, obtained from some other API.) It would be sad to have an > > > identifier and not be able to use it. > > > > > > Now I really think about using hash codes and names interchangeably, so > > > both > > > > > > ``` > > > cache_put(conn, 'my-cache', value=1, key='a') > > > ``` > > > > > > and > > > > > > > > > ``` > > > cache_put(conn, my_hash_code, value=1, key='a') > > > ``` > > > > > > will be allowed. > > > > > > This will be a minor complication on my side, and quite reasonable one. > > > > > > > > > On 07/26/2018 10:44 PM, Ilya Kasnacheev wrote: > > > > > >> Hello! > > >> > > >> Why not use cache name as string here, instead of cache_id()? > > >> > > >> cache_put(conn, 'my-cache', value=1, key='a') > > >> > > >> Regards, > > >> > > >> > > > --00000000000027680e0571e7ff81--