From dev-return-36563-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Mon Jul 16 14:47:33 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id AF9F5180657 for ; Mon, 16 Jul 2018 14:47:32 +0200 (CEST) Received: (qmail 76948 invoked by uid 500); 16 Jul 2018 12:47:31 -0000 Mailing-List: contact dev-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list dev@ignite.apache.org Received: (qmail 76935 invoked by uid 99); 16 Jul 2018 12:47:30 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Jul 2018 12:47:30 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 081ABD0E1A for ; Mon, 16 Jul 2018 12:47:30 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.031 X-Spam-Level: X-Spam-Status: No, score=-0.031 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, T_DKIMWL_WL_MED=-0.01] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gridgain-com.20150623.gappssmtp.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 7rw7puumA6v8 for ; Mon, 16 Jul 2018 12:47:29 +0000 (UTC) Received: from mail-lf0-f68.google.com (mail-lf0-f68.google.com [209.85.215.68]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id E0AF55F366 for ; Mon, 16 Jul 2018 12:47:28 +0000 (UTC) Received: by mail-lf0-f68.google.com with SMTP id u14-v6so32149708lfu.0 for ; Mon, 16 Jul 2018 05:47:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gridgain-com.20150623.gappssmtp.com; s=20150623; h=from:to:subject:references:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding; bh=mbkRO4uempcj0uG/4YG5rWlWnI11Lm8Y7G0RC1FFmFg=; b=iEHy+rIb7DJXgPQQi2bzFOA+xx4OvTLnUDwtzRn6fsDjohqahVYJXCx9ALOFr7EC2V pZvfxVWor2uEnKF/5UmJrm1E4V1sYiUoePVs1VEu1JdhPA1qd7Z294QTkGuw13AjrnI4 sY8/8/UX0xa4Dwo7iBtQ6vii0OT94nkGHQtBHP+HsSgyGZXbRfPHSgapTKvH6qLhQOia ineR6bGTNaTiNAl3Obbr7PyK36ErrM0iztFaO7RTO8sm7yoxPQOs2k9aQmREFEJq9yuH B+oOm3slIqjZBRI4eyVdMQBKEvYZ7u3Kss2wmC0igze36YcoXHJMXgkIGA/NXjBgkcbC MV6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:references:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=mbkRO4uempcj0uG/4YG5rWlWnI11Lm8Y7G0RC1FFmFg=; b=VPjLi8tEJpQWE4R+R4ulZgm/9+tUcglu2tTTgQb0byc0ZgruJ36AsE/NrucTTBJmQ3 +h7gPZE8ld2UsxKOrRZQZvyFCEjFHHOlSvEurZLZWSq5UiUNwarakr5xG1+Jkmx5MIgi gOqIjjUDKQF/s4+Z3UNcxMLGXWuNq5Q++1wpU3B6xJ+L2D6LkjMmb6SZiNGhKNCcUPW/ Hg4LwjnYPbgGXukIlmFIkPg+fp+tcYf0q2FBqXXnwVVtWfy6QByTJydc0i5MRvHnu9l6 8DZhJE+tran04Vc83ZF+cver4BFvvY/2XzWehEAZFVWFX3Iib2qfI3EciJNDL/8qb7Rn L8wA== X-Gm-Message-State: AOUpUlHHEPjiwKEOdqqqbu1QK0kFzs9m1hmAoS752YNQqvYlqIgRVCQQ pqeTc5gFRNr9Ki6EPJXJRYaKv91za34= X-Google-Smtp-Source: AAOMgpc32Fyz6PRcs7mei6O0Zgg/sHyzeqpP/D2+WSSxdK+f/SSeuMYe+wfBoyvDlCa8H91geGCqZg== X-Received: by 2002:a19:93d2:: with SMTP id w79-v6mr12485912lfk.20.1531745242126; Mon, 16 Jul 2018 05:47:22 -0700 (PDT) Received: from [172.25.4.98] ([195.239.208.174]) by smtp.gmail.com with ESMTPSA id m8-v6sm3343047ljj.10.2018.07.16.05.47.21 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 16 Jul 2018 05:47:21 -0700 (PDT) From: Dmitry Karachentsev To: dev@ignite.apache.org Subject: Re: Neighbors exclusion References: <9b9e6567-aa9c-90f1-861a-6ca9f85f454e@gridgain.com> Message-ID: <2b2d6bc5-cd71-a081-b4cf-26cfbfedb1ef@gridgain.com> Date: Mon, 16 Jul 2018 15:47:20 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Created a ticket and mapped to 3.0 version, as it changes basic default behavior: https://issues.apache.org/jira/browse/IGNITE-9011 Thanks! 13.07.2018 22:10, Valentin Kulichenko пишет: > Dmitry, > > Good point. I think it makes sense to even remove (deprecate) the > excludeNeighbors property and always distribute primary and backups to > different physical hosts in this scenario. Because why would anyone ever > set this to false if we switch default to true? This also automatically > fixes the confusing behavior of backupFilter - it should never be ignored > if it's set. > > -Val > > On Fri, Jul 13, 2018 at 8:05 AM Dmitry Karachentsev < > dkarachentsev@gridgain.com> wrote: > >> Hi folks, >> >> Why RendezvousAffinityFunction.excludeNeighbors [1] is false by default? >> It's not obvious that if user wants to run more than one node per >> machine it has also set this flag to true explicitly. Maybe it would be >> better to set it to true by default? >> >> At the same time if excludeNeighbors is true, it ignores backupFilter. >> Why it's not vice-versa? For example: >> >> 1) if backupFilter is set - it will be used, >> >> 2) if there are not enough backup nodes (or no backupFilter) - try to >> distribute according to excludeNeighbors = true, >> >> 3) if this is not possible too (or excludeNeighbors) = false - assign >> partitions as possible. >> >> [1] >> >> https://ignite.apache.org/releases/latest/javadoc/org/apache/ignite/cache/affinity/rendezvous/RendezvousAffinityFunction.html#setExcludeNeighbors-boolean- >> >> Are there any drawbacks in such approach? >> >> Thanks! >> >>