From dev-return-35332-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Tue Jun 5 23:50:10 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 327CA180625 for ; Tue, 5 Jun 2018 23:50:09 +0200 (CEST) Received: (qmail 83785 invoked by uid 500); 5 Jun 2018 21:50:08 -0000 Mailing-List: contact dev-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list dev@ignite.apache.org Received: (qmail 83773 invoked by uid 99); 5 Jun 2018 21:50:07 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Jun 2018 21:50:07 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 10E72C00C8 for ; Tue, 5 Jun 2018 21:50:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.489 X-Spam-Level: ** X-Spam-Status: No, score=2.489 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=2, KAM_NUMSUBJECT=0.5, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_DKIMWL_WL_MED=-0.01] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gridgain-com.20150623.gappssmtp.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id G72IAgZ29t1F for ; Tue, 5 Jun 2018 21:50:01 +0000 (UTC) Received: from mail-lf0-f44.google.com (mail-lf0-f44.google.com [209.85.215.44]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 5D6165F124 for ; Tue, 5 Jun 2018 21:50:01 +0000 (UTC) Received: by mail-lf0-f44.google.com with SMTP id g21-v6so3929708lfb.4 for ; Tue, 05 Jun 2018 14:50:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gridgain-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=nSZMcZwzwUC5DkHXcFBtSUBVkAa2ErfTTkfXiVl2NRI=; b=XS65CF+zG/If1W4zxB3b5yRg5UBP5gIwOYKTF/Ww9Kg2iFCKAp5gVmTSwEeHOON4jK GXZ2fry6idrrKf9AIzI17P/M7sjo9uqGVgRy45on0qcDb14QrzQpSFdeFGw2cpJtz0wI ajvyU+bEczlOsz9A56gSaButA/3oCGvvgX/yX6QQTSDByFAA2pcCpEPKsjE9saFrluSo Jm1sZuG+vvzfL3MexIYKGLmfbOJ+UTEF8Xx5EGOQM2cVwQyPP+6XIXbBhVR34B1xBwft d499DKUT3TJW6p1uvHNiyvIZxbGDhsXftC0K+61wLWPOlnc+ZL9VWa9eK78WmthixWp7 vM8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=nSZMcZwzwUC5DkHXcFBtSUBVkAa2ErfTTkfXiVl2NRI=; b=CJYPI2tbBLXAsy9ajVLMQNx21srpbBTCobyj0sNZpDjDMukuCFtZejsFw7oySp/BRZ vfgGX18LdajDxYpZwX6ghQZX54Qn4M5HMxSepCg/NBVWo/HWWn1PhJcwPLlrBOVabJTo sHCSRuxCIvEq5lZSjzVzw1NVB+iY6oEM4/ZG+jx+sc33Ye0XsXuXr1yDlBM4cMI7eqIA PZuGM6ROnaeFO2FnSu1APeevPHRKDAEzSzM+Lo+/Sqd/KPmauf9x792IDPVQMCVyzEvc MdK3gWI0ALSPlf7m2z7tBYmGknpATUBGojIE0PbPBbk6LhK8L3fXRc123aQL7tS7lFGG aqqw== X-Gm-Message-State: APt69E2hSHHA4SQ4nFZ1I3E1lwviwGTFqWnbDMcmrix1g6CieusQ2BOa h1x6hGfkF/xank9ulC9V1+fVc+y2BJNXLDdg+SIldvJZ X-Google-Smtp-Source: ADUXVKJ60H+6YkrSrVuiiEOprg99HgU8LYVBrbSKAa+oOIT4hcKb8Jg2pjavdZYJNezlRU09Y/7MVbTTbrISMPutrPc= X-Received: by 2002:a19:f71a:: with SMTP id z26-v6mr178050lfe.137.1528235394580; Tue, 05 Jun 2018 14:49:54 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a2e:89c6:0:0:0:0:0 with HTTP; Tue, 5 Jun 2018 14:49:54 -0700 (PDT) In-Reply-To: References: <9a6c63c256ac1aabd3cea79d9dbfda3bf2dbe535.camel@gmail.com> <67ce92a73507f5b3ce8917e20267da616e4e608a.camel@gmail.com> <6bc70c0eba487c4eb9c24cdde830fe26a0ffd0d0.camel@gmail.com> From: Denis Magda Date: Tue, 5 Jun 2018 14:49:54 -0700 Message-ID: Subject: Re: Upgrading Ignite to JCache 1.1 To: "dev@ignite.apache.org" Cc: Dmitry Pavlov , "nizhikov@apache.org" Content-Type: multipart/alternative; boundary="000000000000d3db92056dec0712" --000000000000d3db92056dec0712 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Agree, I see zero benefits of being compliant with both specification versions. Let=E2=80=99s just focus on the latest one. Denis On Tuesday, June 5, 2018, Dmitriy Setrakyan wrote: > Alex, > > I think it is OK to break TCK 1.0.1 tests in favor of TCK 1.1. Once we > finish the migration, I would remove the TCK 1.0.1 test suite altogether. > > D. > > On Tue, Jun 5, 2018 at 11:13 AM, =D0=90=D0=BB=D0=B5=D0=BA=D1=81=D0=B0=D0= =BD=D0=B4=D1=80 =D0=9C=D0=B5=D0=BD=D1=8C=D1=88=D0=B8=D0=BA=D0=BE=D0=B2 > > wrote: > > > Okay. There are tests results: > > > > https://ci.ignite.apache.org/viewLog.html?buildId=3D1361493& > > tab=3DbuildResultsDiv&buildTypeId=3DIgniteTests24Java8_JCacheTck11 > > > > It's the same as locally. > > > > Also, I have created sub-tasks for all problems we have: > > > > 1) CacheManagerTest.getUnsafeTypedCacheRequest failed. > > https://issues.apache.org/jira/browse/IGNITE-8704 > > > > 2) CacheMBStatisticsBeanTest.testClear failed. > > https://issues.apache.org/jira/browse/IGNITE-8705 > > > > 3) CacheManagerTest.close_cachesEmpty failed. > > https://issues.apache.org/jira/browse/IGNITE-8708 > > > > 4) CacheMBStatisticsBeanTest.testPutIfAbsent failed. > > https://issues.apache.org/jira/browse/IGNITE-8709 > > > > 5) CacheEntryEvent.getOldValue should be available. > > Two tests fail because of it. > > > > Looks like a bug. > > > > https://issues.apache.org/jira/browse/IGNITE-8714 > > > > 6) Problems with Closeable objects from Factory > > > > *98* tests fail because of it. > > > > https://issues.apache.org/jira/browse/IGNITE-8715 > > > > > > For first 4 problems, I already have PRs. > > Problems 2) and 3) will break tests for TCK 1.0.1 because these tests > work > > wrong in 1.0.1, > > and were fixed in 1.1.0. > > > > 2018-06-05 14:37 GMT+03:00 Dmitry Pavlov : > > > > > Agree with Nikolay we should create build plan, and we can use this > build > > > plan in developement branch. > > > > > > Merge to master is not necessary before issue is ready. > > > > > > =D0=B2=D1=82, 5 =D0=B8=D1=8E=D0=BD. 2018 =D0=B3. =D0=B2 14:04, Nikola= y Izhikov : > > > > > >> Alex, please try to run this build plan for your branch > > >> > > >> https://ci.ignite.apache.org/viewType.html?buildTypeId=3D > > >> IgniteTests24Java8_JCacheTck11 > > >> > > >> =D0=92 =D0=92=D1=82, 05/06/2018 =D0=B2 13:56 +0300, Nikolay Izhikov = =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > > >> > Guys, we had a private talk with Vyacheslav and Dmitriy Pavlov. > > >> > Here are its resulst: > > >> > > > >> > 1. I will create JCache1.1 build plan. > > >> > I will be able to run tests with Alex new profile enabled. > > >> > > > >> > So, Alex can run and share with community tests results both for > > jcache > > >> 1.0 and jcache 1.1. > > >> > > > >> > 2. Alex, please, create tickets for a JCache 1.1. issues. > > >> > > > >> > > > >> > =D0=92 =D0=92=D1=82, 05/06/2018 =D0=B2 13:36 +0300, Vyacheslav Dar= adur =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > > >> > > AFAIK TeamCity is not able to create such build-plan on the fly. > > >> > > Moreover, we will not be able to test master branch in both > profiles > > >> > > in this case. > > >> > > > > >> > > Am I miss something? > > >> > > > > >> > > On Tue, Jun 5, 2018 at 1:31 PM, Nikolay Izhikov < > > nizhikov@apache.org> > > >> wrote: > > >> > > > Vyacheslav, > > >> > > > > > >> > > > Let's create build plan on TC for this profile. > > >> > > > Why we need to merge it in master now? > > >> > > > > > >> > > > =D0=92 =D0=92=D1=82, 05/06/2018 =D0=B2 13:29 +0300, Vyacheslav= Daradur =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > > >> > > > > Nikolay, there isn't anything broken in PR. > > >> > > > > > > >> > > > > The PR is needed to add new build-plan on TC. > > >> > > > > > > >> > > > > We need tools to check that fixes for 1.1 don't break > > >> compatibility with 1.0. > > >> > > > > > > >> > > > > On Tue, Jun 5, 2018 at 1:21 PM, =D0=9A=D1=83=D0=B7=D0=BD=D0= =B5=D1=86=D0=BE=D0=B2 =D0=90=D0=BB=D0=B5=D0=BA=D1=81=D0=B5=D0=B9 =D0=9B=D1= =8C=D0=B2=D0=BE=D0=B2=D0=B8=D1=87 > > >> > > > > wrote: > > >> > > > > > Hi > > >> > > > > > > > >> > > > > > After Alexander create separate tickets for failed tests, > > >> everybody is free > > >> > > > > > to fix them. > > >> > > > > > So we can proceed faster issue resolving. > > >> > > > > > > > >> > > > > > > Hello, Igniters. > > >> > > > > > > > > >> > > > > > > Actually, I don't understand why we should merge in mast= er > > >> something > > >> > > > > > > broken. > > >> > > > > > > Currently, Ignite is not ready for JCache 1.1. > > >> > > > > > > > > >> > > > > > > Only change I see in PR is new profile [1]. > > >> > > > > > > Is it required to have it to continue jcache 1.1 support > > >> implementation? > > >> > > > > > > > > >> > > > > > > I think Alexandex can proceed with current profile and > > change > > >> it to run > > >> > > > > > > tests for JCache 1.1 his own branch. > > >> > > > > > > > > >> > > > > > > Am I miss something? > > >> > > > > > > > > >> > > > > > > [1] https://github.com/apache/ignite/pull/4114 > > >> > > > > > > > > >> > > > > > > =D0=92 =D0=92=D1=82, 05/06/2018 =D0=B2 12:50 +0300, Dmit= ry Pavlov =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > > >> > > > > > > > > > >> > > > > > > > Hi Alexander, > > >> > > > > > > > > > >> > > > > > > > https://issues.apache.org/jira/browse/IGNITE-8687 is > 'In > > >> progress'. Is it > > >> > > > > > > > expected? > > >> > > > > > > > > > >> > > > > > > > Nikolay, have you some time to apply patch, if it pass= es > > >> review? > > >> > > > > > > > > > >> > > > > > > > Sincerely, > > >> > > > > > > > Dmitriy Pavlov > > >> > > > > > > > > > >> > > > > > > > =D0=B2=D1=82, 5 =D0=B8=D1=8E=D0=BD. 2018 =D0=B3. =D0= =B2 5:09, Dmitriy Setrakyan < > > >> dsetrakyan@apache.org>: > > >> > > > > > > > > > >> > > > > > > > > Thanks, Alex! Sounds like a good plan. > > >> > > > > > > > > > > >> > > > > > > > > On Mon, Jun 4, 2018 at 5:52 AM, =D0=90=D0=BB=D0=B5= =D0=BA=D1=81=D0=B0=D0=BD=D0=B4=D1=80 =D0=9C=D0=B5=D0=BD=D1=8C=D1=88=D0=B8= =D0=BA=D0=BE=D0=B2 > > >> > > > > > > > > > > >> > > > > > > > > wrote: > > >> > > > > > > > > > > >> > > > > > > > > > Hi, > > >> > > > > > > > > > Igniters! > > >> > > > > > > > > > > > >> > > > > > > > > > I have taken a look at the jcache 1.1 spec and TCK= . > > >> > > > > > > > > > And I can write a brief summary of my plan to solv= e > > the > > >> task. > > >> > > > > > > > > > > > >> > > > > > > > > > I have found 6 problems in current master with TCK > 1.1 > > >> (104 failed > > >> > > > > > > > > > > >> > > > > > > > > tests). > > >> > > > > > > > > > > > >> > > > > > > > > > Of course, we should run this TCK on CI to be > > >> absolutely sure we didn't > > >> > > > > > > > > > miss something. > > >> > > > > > > > > > > > >> > > > > > > > > > So the first step is an adding TCK 1.1 suite to ou= r > > >> Team City. > > >> > > > > > > > > > I have created sub-task [1] for it and prepared th= e > PR > > >> [2]. > > >> > > > > > > > > > I need someone with access to merge PR and add sui= te > > to > > >> Team City. > > >> > > > > > > > > > It going to be just a clone of the current > jcache-tck > > >> suite, but with > > >> > > > > > > > > > > >> > > > > > > > > using > > >> > > > > > > > > > > > >> > > > > > > > > > the new profile. > > >> > > > > > > > > > You can test new profile locally with the followin= g > > >> command: > > >> > > > > > > > > > > > >> > > > > > > > > > mvn test -P-release,jcache-tck-1.1 -pl :ignite-cor= e > > -am > > >> > > > > > > > > > > > >> > > > > > > > > > > > >> > > > > > > > > > After that, I will start to add sub-task for every > > >> problem we have. > > >> > > > > > > > > > > > >> > > > > > > > > > Nikolay, can you please help me with merging [1] a= nd > > >> adding to the > > >> > > > > > > > > > suite? > > >> > > > > > > > > > > > >> > > > > > > > > > [1]JIRA: https://issues.apache.org/ > > >> jira/browse/IGNITE-8687 > > >> > > > > > > > > > [2]PR: https://github.com/apache/ > > ignite/pull/4114/files > > >> > > > > > > > > > [3]CI: > > >> > > > > > > > > > https://ci.ignite.apache.org/ > > viewType.html?buildTypeId=3D > > >> > > > > > > > > > IgniteTests24Java8_RunAll& > branch_IgniteTests24Java8=3D > > >> pull/4114/head&tab=3D > > >> > > > > > > > > > buildTypeStatusDiv > > >> > > > > > > > > > > > >> > > > > > > > > > 2018-05-23 14:31 GMT+03:00 =D0=90=D0=BB=D0=B5=D0= =BA=D1=81=D0=B0=D0=BD=D0=B4=D1=80 =D0=9C=D0=B5=D0=BD=D1=8C=D1=88=D0=B8=D0= =BA=D0=BE=D0=B2 < > > >> sharplermc@gmail.com>: > > >> > > > > > > > > > > > >> > > > > > > > > > > Thanks, Slava. You are right. > > >> > > > > > > > > > > > > >> > > > > > > > > > > 2018-05-23 14:00 GMT+03:00 Vyacheslav Daradur < > > >> daradurvs@gmail.com>: > > >> > > > > > > > > > > > > >> > > > > > > > > > > > Hi, Alex! > > >> > > > > > > > > > > > > > >> > > > > > > > > > > > Please have a look at maven profile named > > >> "jcache-tck". > > >> > > > > > > > > > > > > > >> > > > > > > > > > > > I believe this is what you are looking for. > > >> > > > > > > > > > > > > > >> > > > > > > > > > > > On Wed, May 23, 2018 at 11:50 AM, =D0=90=D0=BB= =D0=B5=D0=BA=D1=81=D0=B0=D0=BD=D0=B4=D1=80 > > >> =D0=9C=D0=B5=D0=BD=D1=8C=D1=88=D0=B8=D0=BA=D0=BE=D0=B2 > > >> > > > > > > > > > > > wrote: > > >> > > > > > > > > > > > > > > >> > > > > > > > > > > > > Igniters, > > >> > > > > > > > > > > > > I think I can do it. As I see we already hav= e > > >> JCache TCK tests in > > >> > > > > > > > > > > >> > > > > > > > > TC. > > >> > > > > > > > > > > > > > > >> > > > > > > > > > > > > Can I take somewhere settings/script which w= e > > are > > >> using? > > >> > > > > > > > > > > > > > > >> > > > > > > > > > > > > 2018-05-23 2:58 GMT+03:00 Dmitriy Setrakyan = < > > >> dsetrakyan@apache.org > > >> > > > > > > > > > > > >> > > > > > > > > > : > > >> > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > Igniters, > > >> > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > It will be great if someone in the communi= ty > > >> would pick this up. > > >> > > > > > > > > > > >> > > > > > > > > The > > >> > > > > > > > > > > > > > >> > > > > > > > > > > > amount > > >> > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > of changes are minimal and many of them on= ly > > >> have to do with > > >> > > > > > > > > > > > > > >> > > > > > > > > > > > clarifying the > > >> > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > documentation. However, removing JSR 107 > > >> license confusion in 1.1 > > >> > > > > > > > > > > > > > >> > > > > > > > > > > > would be > > >> > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > great for Ignite. > > >> > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > D. > > >> > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > On Tue, May 22, 2018 at 3:04 PM, Denis > Magda < > > >> dmagda@apache.org> > > >> > > > > > > > > > > > > > >> > > > > > > > > > > > wrote: > > >> > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > Here is a list of all changes: > > >> > > > > > > > > > > > > > > https://groups.google.com/ > > >> forum/#!topic/jsr107/BC1qKqknzKU > > >> > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > The primary argument for the migration i= s > a > > >> license. JCache 1.0 > > >> > > > > > > > > > > >> > > > > > > > > is > > >> > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > licensed > > >> > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > by Oracle that causes legal issues for > some > > >> of the users. Once we > > >> > > > > > > > > > > > > > >> > > > > > > > > > > > upgrade > > >> > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > to JCache 1.1 the won't longer be a big > > deal. > > >> > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > However, once we move to 1.1 we need to = be > > >> sure that we comply > > >> > > > > > > > > > > >> > > > > > > > > with > > >> > > > > > > > > > > > > > >> > > > > > > > > > > > the > > >> > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > updated specification. > > >> > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > -- > > >> > > > > > > > > > > > > > > Denis > > >> > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > On Tue, May 22, 2018 at 5:20 AM, Dmitry > > >> Pavlov < > > >> > > > > > > > > > > > > > >> > > > > > > > > > > > dpavlov.spb@gmail.com> > > >> > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > wrote: > > >> > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > Hi Denis, > > >> > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > What was improved in JCache 1.1? > > >> > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > Would it be useful for product to chan= ge > > >> supported spec. > > >> > > > > > > > > > > >> > > > > > > > > version? > > >> > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > Sincerely, > > >> > > > > > > > > > > > > > > > Dmitriy Pavlov > > >> > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > =D0=BF=D0=BD, 21 =D0=BC=D0=B0=D1=8F 20= 18 =D0=B3. =D0=B2 20:12, Denis Magda > < > > >> dmagda@apache.org>: > > >> > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > Igniters, > > >> > > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > Eventually, JCache was relicensed to > > >> Apache 2.0 and released > > >> > > > > > > > > > > > >> > > > > > > > > > 1.1 > > >> > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > version: > > >> > > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > https://groups.google.com/ > > >> forum/#!topic/jsr107/BC1qKqknzKU > > >> > > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > Is there anyone interested in > upgrading > > >> Ignite to the new > > >> > > > > > > > > > > > > > >> > > > > > > > > > > > version for > > >> > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > the > > >> > > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > next release? > > >> > > > > > > > > > > > > > > > > https://issues.apache.org/ > > >> jira/browse/IGNITE-8548 > > >> > > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > -- > > >> > > > > > > > > > > > > > > > > Denis > > >> > > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > >> > > > > > > > > > > > > > >> > > > > > > > > > > > -- > > >> > > > > > > > > > > > Best Regards, Vyacheslav D. > > >> > > > > > > > > > > > > > >> > > > > > > >> > > > > > > >> > > > > > > >> > > > > >> > > > > > > > > > > > --000000000000d3db92056dec0712--