ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dmitriy Govorukhin <dmitriy.govoruk...@gmail.com>
Subject Re: unused or only used in tests methonds
Date Mon, 25 Jun 2018 16:06:25 GMT
Igniters,

If no one objects, then I delete these methods in next refactoring task.

On Fri, Jun 15, 2018 at 6:38 PM Alexey Goncharuk <alexey.goncharuk@gmail.com>
wrote:

> I have no objections to remove these methods.
>
> --AG
>
> чт, 14 июн. 2018 г. в 17:39, Dmitriy Govorukhin <
> dmitriy.govorukhin@gmail.com>:
>
> > Igniters,
> >
> > I found 2 methods,
> >
> > 1. PageStore.pageOffset(long pageId) -  it unused, seem that old
> artifact.
> > 2. IgnitePageStoreManager.pagesAllocated(int grpId) - used only in test,
> > seem that same problem can be solved with
> > IgnitePageStoreManager.pages(grpId,
> > partId).
> >
> > I suggest, remove these methods for the more clear interface.
> >
> > Any reason, why we can not remove them?
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message