ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Александр Меньшиков <sharple...@gmail.com>
Subject Re: Upgrading Ignite to JCache 1.1
Date Thu, 14 Jun 2018 09:38:53 GMT
Igniters,

I've prepared IEP-21 [1] for this JCache updating task.
It will help us to manage the issues and see the progress in one place.
Also, we have finally added tests for TCK 1.1.0 [2] to our TC which can be
run on any branch.
Both tests cases (for 1.0.1 and for 1.1.0) will coexist until IEP-21 finish.

[1] https://cwiki.apache.org/confluence/display/IGNITE/IEP-21:+JCache+1.1
[2]
https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_JCacheTck11

2018-06-06 0:49 GMT+03:00 Denis Magda <dmagda@gridgain.com>:

> Agree, I see zero benefits of being compliant with both specification
> versions. Let’s just focus on the latest one.
>
> Denis
>
> On Tuesday, June 5, 2018, Dmitriy Setrakyan <dsetrakyan@apache.org> wrote:
>
> > Alex,
> >
> > I think it is OK to break TCK 1.0.1 tests in favor of TCK 1.1. Once we
> > finish the migration, I would remove the TCK 1.0.1 test suite altogether.
> >
> > D.
> >
> > On Tue, Jun 5, 2018 at 11:13 AM, Александр Меньшиков <
> sharplermc@gmail.com
> > >
> > wrote:
> >
> > > Okay. There are tests results:
> > >
> > > https://ci.ignite.apache.org/viewLog.html?buildId=1361493&
> > > tab=buildResultsDiv&buildTypeId=IgniteTests24Java8_JCacheTck11
> > >
> > > It's the same as locally.
> > >
> > > Also, I have created sub-tasks for all problems we have:
> > >
> > > 1) CacheManagerTest.getUnsafeTypedCacheRequest failed.
> > > https://issues.apache.org/jira/browse/IGNITE-8704
> > >
> > > 2) CacheMBStatisticsBeanTest.testClear failed.
> > > https://issues.apache.org/jira/browse/IGNITE-8705
> > >
> > > 3) CacheManagerTest.close_cachesEmpty failed.
> > > https://issues.apache.org/jira/browse/IGNITE-8708
> > >
> > > 4) CacheMBStatisticsBeanTest.testPutIfAbsent failed.
> > > https://issues.apache.org/jira/browse/IGNITE-8709
> > >
> > > 5) CacheEntryEvent.getOldValue should be available.
> > > Two tests fail because of it.
> > >
> > > Looks like a bug.
> > >
> > > https://issues.apache.org/jira/browse/IGNITE-8714
> > >
> > > 6) Problems with Closeable objects from Factory
> > >
> > > *98* tests fail because of it.
> > >
> > > https://issues.apache.org/jira/browse/IGNITE-8715
> > >
> > >
> > > For first 4 problems, I already have PRs.
> > > Problems 2) and 3) will break tests for TCK 1.0.1 because these tests
> > work
> > > wrong in 1.0.1,
> > > and were fixed in 1.1.0.
> > >
> > > 2018-06-05 14:37 GMT+03:00 Dmitry Pavlov <dpavlov.spb@gmail.com>:
> > >
> > > > Agree with Nikolay we should create build plan, and we can use this
> > build
> > > > plan in developement branch.
> > > >
> > > > Merge to master is not necessary before issue is ready.
> > > >
> > > > вт, 5 июн. 2018 г. в 14:04, Nikolay Izhikov <nizhikov@apache.org>:
> > > >
> > > >> Alex, please try to run this build plan for your branch
> > > >>
> > > >> https://ci.ignite.apache.org/viewType.html?buildTypeId=
> > > >> IgniteTests24Java8_JCacheTck11
> > > >>
> > > >> В Вт, 05/06/2018 в 13:56 +0300, Nikolay Izhikov пишет:
> > > >> > Guys, we had a private talk with Vyacheslav and Dmitriy Pavlov.
> > > >> > Here are its resulst:
> > > >> >
> > > >> > 1. I will create JCache1.1 build plan.
> > > >> > I will be able to run tests with Alex new profile enabled.
> > > >> >
> > > >> > So, Alex can run and share with community tests results both
for
> > > jcache
> > > >> 1.0 and jcache 1.1.
> > > >> >
> > > >> > 2. Alex, please, create tickets for a JCache 1.1. issues.
> > > >> >
> > > >> >
> > > >> > В Вт, 05/06/2018 в 13:36 +0300, Vyacheslav Daradur пишет:
> > > >> > > AFAIK TeamCity is not able to create such build-plan on
the fly.
> > > >> > > Moreover, we will not be able to test master branch in both
> > profiles
> > > >> > > in this case.
> > > >> > >
> > > >> > > Am I miss something?
> > > >> > >
> > > >> > > On Tue, Jun 5, 2018 at 1:31 PM, Nikolay Izhikov <
> > > nizhikov@apache.org>
> > > >> wrote:
> > > >> > > > Vyacheslav,
> > > >> > > >
> > > >> > > > Let's create build plan on TC for this profile.
> > > >> > > > Why we need to merge it in master now?
> > > >> > > >
> > > >> > > > В Вт, 05/06/2018 в 13:29 +0300, Vyacheslav Daradur
пишет:
> > > >> > > > > Nikolay, there isn't anything broken in PR.
> > > >> > > > >
> > > >> > > > > The PR is needed to add new build-plan on TC.
> > > >> > > > >
> > > >> > > > > We need tools to check that fixes for 1.1 don't
break
> > > >> compatibility with 1.0.
> > > >> > > > >
> > > >> > > > > On Tue, Jun 5, 2018 at 1:21 PM, Кузнецов
Алексей Львович
> > > >> > > > > <alkuznetsov.sb@gmail.com> wrote:
> > > >> > > > > > Hi
> > > >> > > > > >
> > > >> > > > > > After Alexander create separate tickets for
failed tests,
> > > >> everybody is free
> > > >> > > > > > to fix them.
> > > >> > > > > > So we can proceed faster issue resolving.
> > > >> > > > > >
> > > >> > > > > > > Hello, Igniters.
> > > >> > > > > > >
> > > >> > > > > > > Actually, I don't understand why we
should merge in
> master
> > > >> something
> > > >> > > > > > > broken.
> > > >> > > > > > > Currently, Ignite is not ready for JCache
1.1.
> > > >> > > > > > >
> > > >> > > > > > > Only change I see in PR is new profile
[1].
> > > >> > > > > > > Is it required to have it to continue
jcache 1.1 support
> > > >> implementation?
> > > >> > > > > > >
> > > >> > > > > > > I think Alexandex can proceed with current
profile and
> > > change
> > > >> it  to run
> > > >> > > > > > > tests for JCache 1.1 his own branch.
> > > >> > > > > > >
> > > >> > > > > > > Am I miss something?
> > > >> > > > > > >
> > > >> > > > > > > [1] https://github.com/apache/ignite/pull/4114
> > > >> > > > > > >
> > > >> > > > > > > В Вт, 05/06/2018 в 12:50 +0300,
Dmitry Pavlov пишет:
> > > >> > > > > > > >
> > > >> > > > > > > > Hi Alexander,
> > > >> > > > > > > >
> > > >> > > > > > > > https://issues.apache.org/jira/browse/IGNITE-8687
is
> > 'In
> > > >> progress'. Is it
> > > >> > > > > > > > expected?
> > > >> > > > > > > >
> > > >> > > > > > > > Nikolay, have you some time to
apply patch, if it
> passes
> > > >> review?
> > > >> > > > > > > >
> > > >> > > > > > > > Sincerely,
> > > >> > > > > > > > Dmitriy Pavlov
> > > >> > > > > > > >
> > > >> > > > > > > > вт, 5 июн. 2018 г. в 5:09,
Dmitriy Setrakyan <
> > > >> dsetrakyan@apache.org>:
> > > >> > > > > > > >
> > > >> > > > > > > > > Thanks, Alex! Sounds like
a good plan.
> > > >> > > > > > > > >
> > > >> > > > > > > > > On Mon, Jun 4, 2018 at 5:52
AM, Александр Меньшиков
> > > >> > > > > > > > > <sharplermc@gmail.com>
> > > >> > > > > > > > > wrote:
> > > >> > > > > > > > >
> > > >> > > > > > > > > > Hi,
> > > >> > > > > > > > > > Igniters!
> > > >> > > > > > > > > >
> > > >> > > > > > > > > > I have taken a look at
the jcache 1.1 spec and
> TCK.
> > > >> > > > > > > > > > And I can write a brief
summary of my plan to
> solve
> > > the
> > > >> task.
> > > >> > > > > > > > > >
> > > >> > > > > > > > > > I have found 6 problems
in current master with TCK
> > 1.1
> > > >> (104 failed
> > > >> > > > > > > > >
> > > >> > > > > > > > > tests).
> > > >> > > > > > > > > >
> > > >> > > > > > > > > > Of course, we should
run this TCK on CI to be
> > > >> absolutely sure we didn't
> > > >> > > > > > > > > > miss something.
> > > >> > > > > > > > > >
> > > >> > > > > > > > > > So the first step is
an adding TCK 1.1 suite to
> our
> > > >> Team City.
> > > >> > > > > > > > > > I have created sub-task
[1] for it and prepared
> the
> > PR
> > > >> [2].
> > > >> > > > > > > > > > I need someone with access
to merge PR and add
> suite
> > > to
> > > >> Team City.
> > > >> > > > > > > > > > It going to be just a
clone of the current
> > jcache-tck
> > > >> suite, but with
> > > >> > > > > > > > >
> > > >> > > > > > > > > using
> > > >> > > > > > > > > >
> > > >> > > > > > > > > > the new profile.
> > > >> > > > > > > > > > You can test new profile
locally with the
> following
> > > >> command:
> > > >> > > > > > > > > >
> > > >> > > > > > > > > > mvn test -P-release,jcache-tck-1.1
-pl
> :ignite-core
> > > -am
> > > >> > > > > > > > > >
> > > >> > > > > > > > > >
> > > >> > > > > > > > > > After that, I will start
to add sub-task for every
> > > >> problem we have.
> > > >> > > > > > > > > >
> > > >> > > > > > > > > > Nikolay, can you please
help me with merging [1]
> and
> > > >> adding to the
> > > >> > > > > > > > > > suite?
> > > >> > > > > > > > > >
> > > >> > > > > > > > > > [1]JIRA: https://issues.apache.org/
> > > >> jira/browse/IGNITE-8687
> > > >> > > > > > > > > > [2]PR: https://github.com/apache/
> > > ignite/pull/4114/files
> > > >> > > > > > > > > > [3]CI:
> > > >> > > > > > > > > > https://ci.ignite.apache.org/
> > > viewType.html?buildTypeId=
> > > >> > > > > > > > > > IgniteTests24Java8_RunAll&
> > branch_IgniteTests24Java8=
> > > >> pull/4114/head&tab=
> > > >> > > > > > > > > > buildTypeStatusDiv
> > > >> > > > > > > > > >
> > > >> > > > > > > > > > 2018-05-23 14:31 GMT+03:00
Александр Меньшиков <
> > > >> sharplermc@gmail.com>:
> > > >> > > > > > > > > >
> > > >> > > > > > > > > > > Thanks, Slava. You
are right.
> > > >> > > > > > > > > > >
> > > >> > > > > > > > > > > 2018-05-23 14:00
GMT+03:00 Vyacheslav Daradur <
> > > >> daradurvs@gmail.com>:
> > > >> > > > > > > > > > >
> > > >> > > > > > > > > > > > Hi, Alex!
> > > >> > > > > > > > > > > >
> > > >> > > > > > > > > > > > Please have
a look at maven profile named
> > > >> "jcache-tck".
> > > >> > > > > > > > > > > >
> > > >> > > > > > > > > > > > I believe this
is what you are looking for.
> > > >> > > > > > > > > > > >
> > > >> > > > > > > > > > > > On Wed, May
23, 2018 at 11:50 AM, Александр
> > > >> Меньшиков
> > > >> > > > > > > > > > > > <sharplermc@gmail.com>
wrote:
> > > >> > > > > > > > > > > > >
> > > >> > > > > > > > > > > > > Igniters,
> > > >> > > > > > > > > > > > > I think
I can do it. As I see we already
> have
> > > >> JCache TCK tests in
> > > >> > > > > > > > >
> > > >> > > > > > > > > TC.
> > > >> > > > > > > > > > > > >
> > > >> > > > > > > > > > > > > Can I
take somewhere settings/script which
> we
> > > are
> > > >> using?
> > > >> > > > > > > > > > > > >
> > > >> > > > > > > > > > > > > 2018-05-23
2:58 GMT+03:00 Dmitriy Setrakyan
> <
> > > >> dsetrakyan@apache.org
> > > >> > > > > > > > > >
> > > >> > > > > > > > > > :
> > > >> > > > > > > > > > > > > >
> > > >> > > > > > > > > > > > > > Igniters,
> > > >> > > > > > > > > > > > > >
> > > >> > > > > > > > > > > > > > It
will be great if someone in the
> community
> > > >> would pick this up.
> > > >> > > > > > > > >
> > > >> > > > > > > > > The
> > > >> > > > > > > > > > > >
> > > >> > > > > > > > > > > > amount
> > > >> > > > > > > > > > > > > >
> > > >> > > > > > > > > > > > > > of
changes are minimal and many of them
> only
> > > >> have to do with
> > > >> > > > > > > > > > > >
> > > >> > > > > > > > > > > > clarifying
the
> > > >> > > > > > > > > > > > > >
> > > >> > > > > > > > > > > > > > documentation.
However, removing JSR 107
> > > >> license confusion in 1.1
> > > >> > > > > > > > > > > >
> > > >> > > > > > > > > > > > would be
> > > >> > > > > > > > > > > > > >
> > > >> > > > > > > > > > > > > > great
for Ignite.
> > > >> > > > > > > > > > > > > >
> > > >> > > > > > > > > > > > > > D.
> > > >> > > > > > > > > > > > > >
> > > >> > > > > > > > > > > > > > On
Tue, May 22, 2018 at 3:04 PM, Denis
> > Magda <
> > > >> dmagda@apache.org>
> > > >> > > > > > > > > > > >
> > > >> > > > > > > > > > > > wrote:
> > > >> > > > > > > > > > > > > > >
> > > >> > > > > > > > > > > > > > >
Here is a list of all changes:
> > > >> > > > > > > > > > > > > > >
https://groups.google.com/
> > > >> forum/#!topic/jsr107/BC1qKqknzKU
> > > >> > > > > > > > > > > > > > >
> > > >> > > > > > > > > > > > > > >
The primary argument for the migration
> is
> > a
> > > >> license. JCache 1.0
> > > >> > > > > > > > >
> > > >> > > > > > > > > is
> > > >> > > > > > > > > > > > > >
> > > >> > > > > > > > > > > > > > licensed
> > > >> > > > > > > > > > > > > > >
> > > >> > > > > > > > > > > > > > >
by Oracle that causes legal issues for
> > some
> > > >> of the users. Once we
> > > >> > > > > > > > > > > >
> > > >> > > > > > > > > > > > upgrade
> > > >> > > > > > > > > > > > > > >
> > > >> > > > > > > > > > > > > > >
to JCache 1.1 the won't longer be a big
> > > deal.
> > > >> > > > > > > > > > > > > > >
> > > >> > > > > > > > > > > > > > >
However, once we move to 1.1 we need to
> be
> > > >> sure that we comply
> > > >> > > > > > > > >
> > > >> > > > > > > > > with
> > > >> > > > > > > > > > > >
> > > >> > > > > > > > > > > > the
> > > >> > > > > > > > > > > > > > >
> > > >> > > > > > > > > > > > > > >
updated specification.
> > > >> > > > > > > > > > > > > > >
> > > >> > > > > > > > > > > > > > >
--
> > > >> > > > > > > > > > > > > > >
Denis
> > > >> > > > > > > > > > > > > > >
> > > >> > > > > > > > > > > > > > >
On Tue, May 22, 2018 at 5:20 AM, Dmitry
> > > >> Pavlov <
> > > >> > > > > > > > > > > >
> > > >> > > > > > > > > > > > dpavlov.spb@gmail.com>
> > > >> > > > > > > > > > > > > > >
> > > >> > > > > > > > > > > > > > >
wrote:
> > > >> > > > > > > > > > > > > > >
> > > >> > > > > > > > > > > > > > >
> Hi Denis,
> > > >> > > > > > > > > > > > > > >
>
> > > >> > > > > > > > > > > > > > >
> What was improved in JCache 1.1?
> > > >> > > > > > > > > > > > > > >
>
> > > >> > > > > > > > > > > > > > >
> Would it be useful for product to
> change
> > > >> supported spec.
> > > >> > > > > > > > >
> > > >> > > > > > > > > version?
> > > >> > > > > > > > > > > > > > >
>
> > > >> > > > > > > > > > > > > > >
> Sincerely,
> > > >> > > > > > > > > > > > > > >
> Dmitriy Pavlov
> > > >> > > > > > > > > > > > > > >
>
> > > >> > > > > > > > > > > > > > >
> пн, 21 мая 2018 г. в 20:12, Denis
> Magda
> > <
> > > >> dmagda@apache.org>:
> > > >> > > > > > > > > > > > > > >
>
> > > >> > > > > > > > > > > > > > >
> > Igniters,
> > > >> > > > > > > > > > > > > > >
> >
> > > >> > > > > > > > > > > > > > >
> > Eventually, JCache was relicensed to
> > > >> Apache 2.0 and released
> > > >> > > > > > > > > >
> > > >> > > > > > > > > > 1.1
> > > >> > > > > > > > > > > > > > >
> > > >> > > > > > > > > > > > > > >
version:
> > > >> > > > > > > > > > > > > > >
> >
> > > >> > > > > > > > > > > > > > >
> > https://groups.google.com/
> > > >> forum/#!topic/jsr107/BC1qKqknzKU
> > > >> > > > > > > > > > > > > > >
> >
> > > >> > > > > > > > > > > > > > >
> > Is there anyone interested in
> > upgrading
> > > >> Ignite to the new
> > > >> > > > > > > > > > > >
> > > >> > > > > > > > > > > > version for
> > > >> > > > > > > > > > > > > > >
> > > >> > > > > > > > > > > > > > >
the
> > > >> > > > > > > > > > > > > > >
> >
> > > >> > > > > > > > > > > > > > >
> > next release?
> > > >> > > > > > > > > > > > > > >
> > https://issues.apache.org/
> > > >> jira/browse/IGNITE-8548
> > > >> > > > > > > > > > > > > > >
> >
> > > >> > > > > > > > > > > > > > >
> > --
> > > >> > > > > > > > > > > > > > >
> > Denis
> > > >> > > > > > > > > > > > > > >
> >
> > > >> > > > > > > > > > > >
> > > >> > > > > > > > > > > >
> > > >> > > > > > > > > > > > --
> > > >> > > > > > > > > > > > Best Regards,
Vyacheslav D.
> > > >> > > > > > > > > > > >
> > > >> > > > >
> > > >> > > > >
> > > >> > > > >
> > > >> > >
> > > >> > >
> > > >
> > > >
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message