ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anton Vinogradov ...@apache.org>
Subject Re: IGNITE-640: multimap initial implementation
Date Wed, 13 Jun 2018 12:37:58 GMT
Amir,

Thanks for attempt.
As far as I can see you have all changes at this commit:
https://github.com/apache/ignite/pull/3926/commits/cd0e50e05d3860788378ebf1a29dc0525460872a

You can simply apply it to local branch based on master by patch
https://github.com/apache/ignite/commit/cd0e50e05d3860788378ebf1a29dc0525460872a.patch

In case you use IDEA, just apply patch from clipboard, and that's will be
you PR.

BTW, next time you can use easiest way to squash your changes - just to
pull all changes from existing PR with squash
> git pull https://github.com/apache/ignite.git pull/XXX/head --squash



вт, 5 июн. 2018 г. в 19:34, Amir Akhmedov <amir.akhmedov@gmail.com>:

> Dmitry P., Anton V.,
> I made some changes and updated the ticket. Also as was asked I tried to
> squash the commits into one but looks like I screwed up everything and the
> PR now looks completely terrible. Since I'm not an advanced git user, could
> you please check the PR and let me know if anything could be done there? If
> not I will try to create a new PR.
>
> Thanks,
> Amir
>
> On Tue, May 29, 2018 at 10:37 AM, Dmitry Pavlov <dpavlov.spb@gmail.com>
> wrote:
>
> > Hi Amir,
> >
> > As far as I know, several Igniters provided some feedback in ticket. Are
> > you agree?
> >
> > Sincerely,
> > Dmitriy Pavlov
> >
> > чт, 10 мая 2018 г. в 20:01, Dmitry Pavlov <dpavlov.spb@gmail.com>:
> >
> > > Hi Amir,
> > >
> > > This is a very necessary contribution, the patch defenetely will not be
> > > ignored.
> > >
> > > Igniters,
> > >
> > > Who can make a review from the committers?
> > >
> > > Sincerely,
> > > Dmitriy Pavlov
> > >
> > > вт, 8 мая 2018 г. в 5:52, Amir Akhmedov <amir.akhmedov@gmail.com>:
> > >
> > >> Hi Igniters,
> > >>
> > >> Can someone take a look at this PR please?
> > >>
> > >> Thanks,
> > >> Amir
> > >>
> > >> On Mon, Apr 30, 2018 at 5:28 AM, Pavel Tupitsyn <ptupitsyn@apache.org
> >
> > >> wrote:
> > >>
> > >> > Hi Amir,
> > >> >
> > >> > I have filed [1] for multimap in .NET, it will be done later.
> > >> > In order to fix IgniteParityTest failures, please add the following
> to
> > >> > MissingMembers array there:
> > >> >
> > >> > "multimap" // IGNITE-8425
> > >> >
> > >> > Thanks,
> > >> > Pavel
> > >> >
> > >> >
> > >> > [1] https://issues.apache.org/jira/browse/IGNITE-8425
> > >> >
> > >> > On Sun, Apr 29, 2018 at 11:32 PM, Amir Akhmedov <
> > >> amir.akhmedov@gmail.com>
> > >> > wrote:
> > >> >
> > >> > > Hi Igniters,
> > >> > >
> > >> > > I raised a pull request [1] for Ignite multimap [2]. TC run [3]
> > seems
> > >> ok
> > >> > to
> > >> > > me, some tests are failed though. Can someone review it please
and
> > >> let me
> > >> > > know?
> > >> > >
> > >> > > Thanks,
> > >> > > Amir
> > >> > >
> > >> > > [1] https://github.com/apache/ignite/pull/3926
> > >> > > [2] https://issues.apache.org/jira/browse/IGNITE-640
> > >> > > [3]
> > >> > > https://ci.ignite.apache.org/viewLog.html?buildId=1255210&ta
> > >> > > b=buildResultsDiv&buildTypeId=IgniteTests24Java8_RunAll
> > >> > >
> > >> >
> > >>
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message