ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nikolay Izhikov <nizhi...@apache.org>
Subject Re: Upgrading Ignite to JCache 1.1
Date Tue, 05 Jun 2018 10:02:28 GMT
Hello, Igniters.

Actually, I don't understand why we should merge in master something broken.
Currently, Ignite is not ready for JCache 1.1.

Only change I see in PR is new profile [1].
Is it required to have it to continue jcache 1.1 support implementation?

I think Alexandex can proceed with current profile and change it  to run tests for JCache
1.1 his own branch.

Am I miss something?

[1] https://github.com/apache/ignite/pull/4114

В Вт, 05/06/2018 в 12:50 +0300, Dmitry Pavlov пишет:
> Hi Alexander,
> 
> https://issues.apache.org/jira/browse/IGNITE-8687 is 'In progress'. Is it
> expected?
> 
> Nikolay, have you some time to apply patch, if it passes review?
> 
> Sincerely,
> Dmitriy Pavlov
> 
> вт, 5 июн. 2018 г. в 5:09, Dmitriy Setrakyan <dsetrakyan@apache.org>:
> 
> > Thanks, Alex! Sounds like a good plan.
> > 
> > On Mon, Jun 4, 2018 at 5:52 AM, Александр Меньшиков <sharplermc@gmail.com>
> > wrote:
> > 
> > > Hi,
> > > Igniters!
> > > 
> > > I have taken a look at the jcache 1.1 spec and TCK.
> > > And I can write a brief summary of my plan to solve the task.
> > > 
> > > I have found 6 problems in current master with TCK 1.1 (104 failed
> > 
> > tests).
> > > Of course, we should run this TCK on CI to be absolutely sure we didn't
> > > miss something.
> > > 
> > > So the first step is an adding TCK 1.1 suite to our Team City.
> > > I have created sub-task [1] for it and prepared the PR [2].
> > > I need someone with access to merge PR and add suite to Team City.
> > > It going to be just a clone of the current jcache-tck suite, but with
> > 
> > using
> > > the new profile.
> > > You can test new profile locally with the following command:
> > > 
> > > mvn test -P-release,jcache-tck-1.1 -pl :ignite-core -am
> > > 
> > > 
> > > After that, I will start to add sub-task for every problem we have.
> > > 
> > > Nikolay, can you please help me with merging [1] and adding to the suite?
> > > 
> > > [1]JIRA: https://issues.apache.org/jira/browse/IGNITE-8687
> > > [2]PR: https://github.com/apache/ignite/pull/4114/files
> > > [3]CI:
> > > https://ci.ignite.apache.org/viewType.html?buildTypeId=
> > > IgniteTests24Java8_RunAll&branch_IgniteTests24Java8=pull/4114/head&tab=
> > > buildTypeStatusDiv
> > > 
> > > 2018-05-23 14:31 GMT+03:00 Александр Меньшиков <sharplermc@gmail.com>:
> > > 
> > > > Thanks, Slava. You are right.
> > > > 
> > > > 2018-05-23 14:00 GMT+03:00 Vyacheslav Daradur <daradurvs@gmail.com>:
> > > > 
> > > > > Hi, Alex!
> > > > > 
> > > > > Please have a look at maven profile named "jcache-tck".
> > > > > 
> > > > > I believe this is what you are looking for.
> > > > > 
> > > > > On Wed, May 23, 2018 at 11:50 AM, Александр Меньшиков
> > > > > <sharplermc@gmail.com> wrote:
> > > > > > Igniters,
> > > > > > I think I can do it. As I see we already have JCache TCK tests
in
> > 
> > TC.
> > > > > > Can I take somewhere settings/script which we are using?
> > > > > > 
> > > > > > 2018-05-23 2:58 GMT+03:00 Dmitriy Setrakyan <dsetrakyan@apache.org
> > > 
> > > :
> > > > > > 
> > > > > > > Igniters,
> > > > > > > 
> > > > > > > It will be great if someone in the community would pick
this up.
> > 
> > The
> > > > > amount
> > > > > > > of changes are minimal and many of them only have to do
with
> > > > > 
> > > > > clarifying the
> > > > > > > documentation. However, removing JSR 107 license confusion
in 1.1
> > > > > 
> > > > > would be
> > > > > > > great for Ignite.
> > > > > > > 
> > > > > > > D.
> > > > > > > 
> > > > > > > On Tue, May 22, 2018 at 3:04 PM, Denis Magda <dmagda@apache.org>
> > > > > 
> > > > > wrote:
> > > > > > > 
> > > > > > > > Here is a list of all changes:
> > > > > > > > https://groups.google.com/forum/#!topic/jsr107/BC1qKqknzKU
> > > > > > > > 
> > > > > > > > The primary argument for the migration is a license.
JCache 1.0
> > 
> > is
> > > > > > > licensed
> > > > > > > > by Oracle that causes legal issues for some of the
users. Once we
> > > > > 
> > > > > upgrade
> > > > > > > > to JCache 1.1 the won't longer be a big deal.
> > > > > > > > 
> > > > > > > > However, once we move to 1.1 we need to be sure that
we comply
> > 
> > with
> > > > > the
> > > > > > > > updated specification.
> > > > > > > > 
> > > > > > > > --
> > > > > > > > Denis
> > > > > > > > 
> > > > > > > > On Tue, May 22, 2018 at 5:20 AM, Dmitry Pavlov <
> > > > > 
> > > > > dpavlov.spb@gmail.com>
> > > > > > > > wrote:
> > > > > > > > 
> > > > > > > > > Hi Denis,
> > > > > > > > > 
> > > > > > > > > What was improved in JCache 1.1?
> > > > > > > > > 
> > > > > > > > > Would it be useful for product to change supported
spec.
> > 
> > version?
> > > > > > > > > 
> > > > > > > > > Sincerely,
> > > > > > > > > Dmitriy Pavlov
> > > > > > > > > 
> > > > > > > > > пн, 21 мая 2018 г. в 20:12, Denis Magda
<dmagda@apache.org>:
> > > > > > > > > 
> > > > > > > > > > Igniters,
> > > > > > > > > > 
> > > > > > > > > > Eventually, JCache was relicensed to Apache
2.0 and released
> > > 
> > > 1.1
> > > > > > > > version:
> > > > > > > > > > https://groups.google.com/forum/#!topic/jsr107/BC1qKqknzKU
> > > > > > > > > > 
> > > > > > > > > > Is there anyone interested in upgrading
Ignite to the new
> > > > > 
> > > > > version for
> > > > > > > > the
> > > > > > > > > > next release?
> > > > > > > > > > https://issues.apache.org/jira/browse/IGNITE-8548
> > > > > > > > > > 
> > > > > > > > > > --
> > > > > > > > > > Denis
> > > > > > > > > > 
> > > > > 
> > > > > 
> > > > > 
> > > > > --
> > > > > Best Regards, Vyacheslav D.
> > > > > 
> > > > 
> > > > 
Mime
View raw message