From dev-return-34220-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Tue May 8 14:55:31 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 2206618063B for ; Tue, 8 May 2018 14:55:29 +0200 (CEST) Received: (qmail 42825 invoked by uid 500); 8 May 2018 12:55:29 -0000 Mailing-List: contact dev-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list dev@ignite.apache.org Received: (qmail 42809 invoked by uid 99); 8 May 2018 12:55:28 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 May 2018 12:55:28 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id D37531808E8 for ; Tue, 8 May 2018 12:55:27 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.399 X-Spam-Level: ** X-Spam-Status: No, score=2.399 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=2, KAM_NUMSUBJECT=0.5, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id vwRBMUkLkkYI for ; Tue, 8 May 2018 12:55:22 +0000 (UTC) Received: from mail-io0-f181.google.com (mail-io0-f181.google.com [209.85.223.181]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id B79495F24A for ; Tue, 8 May 2018 12:55:21 +0000 (UTC) Received: by mail-io0-f181.google.com with SMTP id g14-v6so34541395ioc.7 for ; Tue, 08 May 2018 05:55:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=w/BYJaTBAKrVswcbLOgH+dhaYwB+9Uw373xLAutCI78=; b=XrarrO3Hpf6Spu12Wfg8UdzGhLv06Trjplv1SB9B1Wa4OqE+ON1mJM776IKPW6UWYB gM+a/5NI3VHspMD8lmiMLp3rXPgZAVMI8H4LkT1RnaAqddnkj3EEk0TMhWTVK2qUa8W2 QcEgEtqbe1VghKgqimjEnp2JpiM3q1DwEHYi1haoAu/WmvUk+bLgdB7KVbEFW2JGyCkB lrJIP0TwTmfbrqc4mYoRNL6FgtqexmG4R4kSBaCb+Ja+qMVCoRJsQHA3B53BNEh/gjz3 o3Se/Xkwr8IqQxHSUixiTZ7rpTBX5Ilp7UAZ7ikgrVfedapj/o0WAEsmNymjagfNt+pn 6ESg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=w/BYJaTBAKrVswcbLOgH+dhaYwB+9Uw373xLAutCI78=; b=N570vMZD6pb0Wa6lZoJ6ew77smhBuxul/0jHF5o8wKEe1Kv85aNJK6z8rg2SCXr69e oyuRK1UkVktU6Gw4dp62u+N3PyYR4D3EGV6mlaH81xivbGPfUFZBi3uvCozHKiE+sLEq sDoAWEoT7WiE2Gy3HLMBSkZ7yYoOFyHCEmSLIa6L/qqXbJNjbhtAuMxSqyh5Lu89S4Nd hDG+mNsGDoFrRR5sA/D8uUE/iI3DJemrCAtxobvaymQf7782KFmbjwa8zt3fScTVoJEv 96E3ZNlwvoDIqDkgZsQVkYRnkvgV7u9Mx8h/kiLyIY7mt69iEr6DCDz4Brwh5ZDirvLd dHog== X-Gm-Message-State: ALQs6tC1je+Lx6NUEGlbMaXoV2N/A5T0rU+ydx9U1XcrBZTX4jkyMYdK UCFTtz2V4emQDUTBAm13S0IYnL43azGvs/dlttY= X-Google-Smtp-Source: AB8JxZrbbfas9N8/JUz3lU4+ekZFZ/TLSYD/Z+chlPH7OV99DQCEWFScDkuPs8zwg70xGYGCWu5+g46wbLv3rp4udRk= X-Received: by 2002:a6b:a390:: with SMTP id m138-v6mr44191974ioe.116.1525784120492; Tue, 08 May 2018 05:55:20 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Dmitry Pavlov Date: Tue, 08 May 2018 12:55:10 +0000 Message-ID: Subject: Re: IGNITE-6879 To: =?UTF-8?B?0KDQvtC80LDQvSDQnNC10LXRgNGB0L7QvQ==?= Cc: dev@ignite.apache.org Content-Type: multipart/alternative; boundary="000000000000818730056bb14c0b" --000000000000818730056bb14c0b Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Roman, now TC passes for 1.0. In the same time new suite is not executed on TC. I've asked Peter Ivanov to assist in TC run set up for Spring Data 2.0. Sincerely, Dmitriy Pavlov =D0=BF=D0=BD, 7 =D0=BC=D0=B0=D1=8F 2018 =D0=B3. =D0=B2 18:23, =D0=A0=D0=BE= =D0=BC=D0=B0=D0=BD =D0=9C=D0=B5=D0=B5=D1=80=D1=81=D0=BE=D0=BD : > Dmitry, I leave comment at issue. As i may see localy problem with tests > was fixed > > =D0=BF=D0=BD, 7 =D0=BC=D0=B0=D1=8F 2018 =D0=B3. =D0=B2 17:24, Dmitry Pavl= ov : > >> Hi, I've replied to ticket, seems old tests are now failing after >> applying patch locally. >> >> I've also added 2 suites to TC >> TEST_SUITE =3DIgniteSpringDataTestSuite,IgniteSpringData2TestSuite >> to >> https://ci.ignite.apache.org/viewType.html?buildTypeId=3DIgniteTests24Ja= va8_SpringData >> >> so this suite will check both integrations. Ideally we could run this >> suite one more time before merge. >> >> Sincerely, >> Dmitriy Pavlov >> >> =D0=BF=D0=BD, 7 =D0=BC=D0=B0=D1=8F 2018 =D0=B3. =D0=B2 15:46, Dmitry Pav= lov : >> >>> Hi Roman, >>> >>> Currently I'm checking the changes. Because of applying idea to copy al= l >>> changes and upsource problem with this branch it is quite complex to lo= cate >>> actual changes. It is now required to check all copied files before mer= ge. >>> >>> Sincerely, >>> Dmitriy Pavlov >>> >>> =D0=BF=D0=BD, 7 =D0=BC=D0=B0=D1=8F 2018 =D0=B3. =D0=B2 11:07, =D0=A0=D0= =BE=D0=BC=D0=B0=D0=BD =D0=9C=D0=B5=D0=B5=D1=80=D1=81=D0=BE=D0=BD : >>> >>>> Hello Dmitry! >>>> >>>> was review successfull? Or there are any points to change? >>>> >>>> =D1=81=D0=B1, 28 =D0=B0=D0=BF=D1=80. 2018 =D0=B3. =D0=B2 19:32, =D0=A0= =D0=BE=D0=BC=D0=B0=D0=BD =D0=9C=D0=B5=D0=B5=D1=80=D1=81=D0=BE=D0=BD : >>>> >>>>> Ok! I believe in community and that things would change! >>>>> Looking forward for news >>>>> =D1=81=D0=B1, 28 =D0=B0=D0=BF=D1=80. 2018 =D0=B3. =D0=B2 19:29, Dmitr= y Pavlov : >>>>> >>>>>> I hope so! >>>>>> >>>>>> There was several posts related to review time, and AI community is >>>>>> now trying to reduce it. Now it is about 70 tickets waiting to be me= rged >>>>>> more than 1month. This defenetely should be changed. And I hope all = Ignite >>>>>> committers and maintainters would continue to assist in this. >>>>>> >>>>>> =D1=81=D0=B1, 28 =D0=B0=D0=BF=D1=80. 2018 =D0=B3. =D0=B2 18:24, =D0= =A0=D0=BE=D0=BC=D0=B0=D0=BD =D0=9C=D0=B5=D0=B5=D1=80=D1=81=D0=BE=D0=BD : >>>>>> >>>>>>> Hi all! >>>>>>> >>>>>>> Soon we'll celebrate 2 months of my PR :) >>>>>>> Maybe it could be merged? >>>>>>> =D0=BF=D0=BD, 23 =D0=B0=D0=BF=D1=80. 2018 =D0=B3. =D0=B2 18:52, Dmi= try Pavlov : >>>>>>> >>>>>>>> No, nothing yet. I'm going to look to new version. >>>>>>>> >>>>>>>> =D0=BF=D0=BD, 23 =D0=B0=D0=BF=D1=80. 2018 =D0=B3. =D0=B2 17:43, = =D0=A0=D0=BE=D0=BC=D0=B0=D0=BD =D0=9C=D0=B5=D0=B5=D1=80=D1=81=D0=BE=D0=BD <= homich1991@gmail.com>: >>>>>>>> >>>>>>>>> Hi all! >>>>>>>>> >>>>>>>>> Are there any news about PR merging? >>>>>>>>> >>>>>>>>> =D0=BF=D0=BD, 16 =D0=B0=D0=BF=D1=80. 2018 =D0=B3. =D0=B2 19:43, = =D0=A0=D0=BE=D0=BC=D0=B0=D0=BD =D0=9C=D0=B5=D0=B5=D1=80=D1=81=D0=BE=D0=BD <= homich1991@gmail.com>: >>>>>>>>> >>>>>>>>>> Denis, >>>>>>>>>> >>>>>>>>>> module naming fixed >>>>>>>>>> >>>>>>>>>> =D0=BF=D0=BD, 16 =D0=B0=D0=BF=D1=80. 2018 =D0=B3. =D0=B2 19:24, = Denis Magda : >>>>>>>>>> >>>>>>>>>>> Roman, >>>>>>>>>>> >>>>>>>>>>> In my last reply, I voted for your approach - using >>>>>>>>>>> "spring-data*_*2.0" for >>>>>>>>>>> the new Spring version. However, please note that we use "_" >>>>>>>>>>> symbol instead >>>>>>>>>>> of "-" to separate a version from the package name. >>>>>>>>>>> >>>>>>>>>>> -- >>>>>>>>>>> Denis >>>>>>>>>>> >>>>>>>>>>> On Sun, Apr 15, 2018 at 8:17 AM, =D0=A0=D0=BE=D0=BC=D0=B0=D0=BD= =D0=9C=D0=B5=D0=B5=D1=80=D1=81=D0=BE=D0=BD < >>>>>>>>>>> homich1991@gmail.com> wrote: >>>>>>>>>>> >>>>>>>>>>> > Hi all! >>>>>>>>>>> > >>>>>>>>>>> > So guys let=E2=80=99s make a decision. We leave code in curre= nt state >>>>>>>>>>> as I suggest >>>>>>>>>>> > or change module naming according Dmitry=E2=80=99s suggestion= . >>>>>>>>>>> > =D1=81=D1=80, 11 =D0=B0=D0=BF=D1=80. 2018 =D0=B3. =D0=B2 1:54= , Denis Magda : >>>>>>>>>>> > >>>>>>>>>>> > > Roman, >>>>>>>>>>> > > >>>>>>>>>>> > > Your suggestion sounds reasonable to me. Backing it up. >>>>>>>>>>> > > >>>>>>>>>>> > > -- >>>>>>>>>>> > > Denis >>>>>>>>>>> > > >>>>>>>>>>> > > On Tue, Apr 10, 2018 at 2:50 PM, =D0=A0=D0=BE=D0=BC=D0=B0= =D0=BD =D0=9C=D0=B5=D0=B5=D1=80=D1=81=D0=BE=D0=BD < >>>>>>>>>>> homich1991@gmail.com> >>>>>>>>>>> > > wrote: >>>>>>>>>>> > > >>>>>>>>>>> > > > Hi all! >>>>>>>>>>> > > > >>>>>>>>>>> > > > IMHO if we do so we'll produce big pain for everybody >>>>>>>>>>> while migrating >>>>>>>>>>> > on >>>>>>>>>>> > > > new version, because ones should change method and others >>>>>>>>>>> should change >>>>>>>>>>> > > > their poms. This change would be backward incompatible so >>>>>>>>>>> it probably >>>>>>>>>>> > > > should follow with major version upgrade, but I'm not sur= e >>>>>>>>>>> about it. >>>>>>>>>>> > > > >>>>>>>>>>> > > > Otherwise if we leave current state( spring-data for old >>>>>>>>>>> and >>>>>>>>>>> > > > spring-data-2.0 for new) we could support old users who >>>>>>>>>>> probably use >>>>>>>>>>> > > spring >>>>>>>>>>> > > > data 1.0 (because spring data 2.0 release was not so long >>>>>>>>>>> ago) and >>>>>>>>>>> > > provide >>>>>>>>>>> > > > new functionality for users who want to use new spring >>>>>>>>>>> data. >>>>>>>>>>> > > > In this case old users wouldn't change any in their code >>>>>>>>>>> except ignite >>>>>>>>>>> > > > version, and new users would include ignite in their Pom >>>>>>>>>>> anyway and >>>>>>>>>>> > could >>>>>>>>>>> > > > choose which module of spring data to bring. >>>>>>>>>>> > > > >>>>>>>>>>> > > > After some time (probably on 3.0 release) we could change >>>>>>>>>>> naming as >>>>>>>>>>> > Denis >>>>>>>>>>> > > > suggested. >>>>>>>>>>> > > > >>>>>>>>>>> > > > Anyway I leave this decision up to you, just tell me what >>>>>>>>>>> is the way to >>>>>>>>>>> > > > finish this PR. >>>>>>>>>>> > > > >>>>>>>>>>> > > > Regards, Roman. >>>>>>>>>>> > > > >>>>>>>>>>> > > > =D1=81=D1=80, 11 =D0=B0=D0=BF=D1=80. 2018 =D0=B3. =D0=B2 = 1:35, Denis Magda >>>>>>>>>> >: >>>>>>>>>>> > > > >>>>>>>>>>> > > > > In our Hibernate integration we define following two >>>>>>>>>>> modules to >>>>>>>>>>> > > > > distinguish incompatible versions: >>>>>>>>>>> > > > > >>>>>>>>>>> > > > > - ignite-hiberbate_4.2 >>>>>>>>>>> > > > > - ignite-hibernate_5.1 >>>>>>>>>>> > > > > >>>>>>>>>>> > > > > In Spark we have: >>>>>>>>>>> > > > > >>>>>>>>>>> > > > > - ignite-spark >>>>>>>>>>> > > > > - ignite-spark_2.10 >>>>>>>>>>> > > > > >>>>>>>>>>> > > > > After thinking this over, I would do the following with >>>>>>>>>>> Spring Data: >>>>>>>>>>> > > > > >>>>>>>>>>> > > > > - ignite-spring-data for the latest Sprind Data 2.0 >>>>>>>>>>> > > > > - ignite-spring-data_1.0 >>>>>>>>>>> > > > > >>>>>>>>>>> > > > > What do you think? >>>>>>>>>>> > > > > >>>>>>>>>>> > > > > -- >>>>>>>>>>> > > > > Denis >>>>>>>>>>> > > > > >>>>>>>>>>> > > > > On Tue, Apr 10, 2018 at 3:50 AM, Dmitry Pavlov < >>>>>>>>>>> > dpavlov.spb@gmail.com> >>>>>>>>>>> > > > > wrote: >>>>>>>>>>> > > > > >>>>>>>>>>> > > > >> Thank you, Roman. >>>>>>>>>>> > > > >> >>>>>>>>>>> > > > >> Igniters, >>>>>>>>>>> > > > >> >>>>>>>>>>> > > > >> IMO we should consider one more alternative - renaming >>>>>>>>>>> of old module >>>>>>>>>>> > > and >>>>>>>>>>> > > > >> package names. Users, which prefer to stay on previous >>>>>>>>>>> version will >>>>>>>>>>> > be >>>>>>>>>>> > > > >> requiered to update their pom's. In the same time user= s >>>>>>>>>>> which are >>>>>>>>>>> > > ready >>>>>>>>>>> > > > to >>>>>>>>>>> > > > >> migrate to spring data 2.0 will need to update methods >>>>>>>>>>> naming. >>>>>>>>>>> > > > >> >>>>>>>>>>> > > > >> Denis M, what would you say? >>>>>>>>>>> > > > >> >>>>>>>>>>> > > > >> Sincerely, >>>>>>>>>>> > > > >> Dmitriy Pavlov >>>>>>>>>>> > > > >> >>>>>>>>>>> > > > >> =D0=B2=D1=82, 10 =D0=B0=D0=BF=D1=80. 2018 =D0=B3. =D0= =B2 11:27, =D0=A0=D0=BE=D0=BC=D0=B0=D0=BD =D0=9C=D0=B5=D0=B5=D1=80=D1=81=D0= =BE=D0=BD < >>>>>>>>>>> homich1991@gmail.com>: >>>>>>>>>>> > > > >> >>>>>>>>>>> > > > >>> Hi Dmitry! >>>>>>>>>>> > > > >>> >>>>>>>>>>> > > > >>> I`ve just commited new fix. I renamed package of new >>>>>>>>>>> module to >>>>>>>>>>> > > > >>> springdata20, it helps us to separate old >>>>>>>>>>> implementation from new >>>>>>>>>>> > and >>>>>>>>>>> > > > also >>>>>>>>>>> > > > >>> should fix all compilation errors. >>>>>>>>>>> > > > >>> >>>>>>>>>>> > > > >>> =D0=BF=D0=BD, 9 =D0=B0=D0=BF=D1=80. 2018 =D0=B3. =D0= =B2 23:54, =D0=A0=D0=BE=D0=BC=D0=B0=D0=BD =D0=9C=D0=B5=D0=B5=D1=80=D1=81=D0= =BE=D0=BD < >>>>>>>>>>> homich1991@gmail.com>: >>>>>>>>>>> > > > >>> >>>>>>>>>>> > > > >>>> Ok, I'll check it, but I haven't face this problem. >>>>>>>>>>> > > > >>>> If I'll find same issue, what is the proper way? >>>>>>>>>>> Renaming to >>>>>>>>>>> > > something >>>>>>>>>>> > > > >>>> like Ignite2QueryGenerator or module removing? >>>>>>>>>>> > > > >>>> =D0=BF=D0=BD, 9 =D0=B0=D0=BF=D1=80. 2018 =D0=B3. =D0= =B2 23:40, Dmitry Pavlov < >>>>>>>>>>> dpavlov.spb@gmail.com >>>>>>>>>>> > >: >>>>>>>>>>> > > > >>>> >>>>>>>>>>> > > > >>>>> There are 2 classes IgniteQueryGenerator with same >>>>>>>>>>> package name. >>>>>>>>>>> > > > >>>>> Ignite in Idea can't compile. >>>>>>>>>>> > > > >>>>> >>>>>>>>>>> > > > >>>>> >>>>>>>>>>> > > > >>>>> =D0=BF=D0=BD, 9 =D0=B0=D0=BF=D1=80. 2018 =D0=B3., 2= 1:38 =D0=A0=D0=BE=D0=BC=D0=B0=D0=BD =D0=9C=D0=B5=D0=B5=D1=80=D1=81=D0=BE=D0= =BD < >>>>>>>>>>> homich1991@gmail.com>: >>>>>>>>>>> > > > >>>>> >>>>>>>>>>> > > > >>>>>> Hi Dmitry! >>>>>>>>>>> > > > >>>>> >>>>>>>>>>> > > > >>>>> >>>>>>>>>>> > > > >>>>>> Could you specify where you find conflict? Because >>>>>>>>>>> I don=E2=80=99t have >>>>>>>>>>> > > any. >>>>>>>>>>> > > > >>>>>> =D0=BF=D0=BD, 9 =D0=B0=D0=BF=D1=80. 2018 =D0=B3. = =D0=B2 21:09, Dmitry Pavlov < >>>>>>>>>>> > dpavlov.spb@gmail.com >>>>>>>>>>> > > >: >>>>>>>>>>> > > > >>>>>> >>>>>>>>>>> > > > >>>>>>> Hi Denis, >>>>>>>>>>> > > > >>>>>>> >>>>>>>>>>> > > > >>>>>>> could we support just one version instead of >>>>>>>>>>> leaving compatible >>>>>>>>>>> > > > >>>>>>> module? >>>>>>>>>>> > > > >>>>>>> >>>>>>>>>>> > > > >>>>>>> Sincerely, >>>>>>>>>>> > > > >>>>>>> Dmitriy Pavlov >>>>>>>>>>> > > > >>>>>>> >>>>>>>>>>> > > > >>>>>>> =D0=BF=D0=BD, 9 =D0=B0=D0=BF=D1=80. 2018 =D0=B3. = =D0=B2 20:08, Dmitry Pavlov < >>>>>>>>>>> > dpavlov.spb@gmail.com >>>>>>>>>>> > > >: >>>>>>>>>>> > > > >>>>>>> >>>>>>>>>>> > > > >>>>>>>> >>>>>>>>>>> > > > >>>>>>>> >>>>>>>>>>> > > > >>>>>>>> =D0=BF=D0=BD, 9 =D0=B0=D0=BF=D1=80. 2018 =D0=B3.= =D0=B2 20:07, Dmitry Pavlov < >>>>>>>>>>> > > dpavlov.spb@gmail.com >>>>>>>>>>> > > > >: >>>>>>>>>>> > > > >>>>>>>> >>>>>>>>>>> > > > >>>>>>>>> Hi Roman, >>>>>>>>>>> > > > >>>>>>>>> >>>>>>>>>>> > > > >>>>>>>>> I've applied PR locally and I have class name >>>>>>>>>>> conflict at >>>>>>>>>>> > least >>>>>>>>>>> > > > >>>>>>>>> for >>>>>>>>>>> > > > >>>>>>>>> org.apache.ignite.springdata.repository.query. >>>>>>>>>>> > > > IgniteQueryGenerator >>>>>>>>>>> > > > >>>>>>>>> >>>>>>>>>>> > > > >>>>>>>>> How could we solve it? Is it better to rename >>>>>>>>>>> class for new >>>>>>>>>>> > > > plugin >>>>>>>>>>> > > > >>>>>>>>> version? >>>>>>>>>>> > > > >>>>>>>>> >>>>>>>>>>> > > > >>>>>>>>> Sincerely, >>>>>>>>>>> > > > >>>>>>>>> Dmitriy Pavlov >>>>>>>>>>> > > > >>>>>>>>> >>>>>>>>>>> > > > >>>>>>>>> =D0=BF=D1=82, 6 =D0=B0=D0=BF=D1=80. 2018 =D0=B3= . =D0=B2 17:38, Dmitry Pavlov < >>>>>>>>>>> > > dpavlov.spb@gmail.com >>>>>>>>>>> > > > >: >>>>>>>>>>> > > > >>>>>>>>> >>>>>>>>>>> > > > >>>>>>>>>> Excellend picture. I remember about this chang= e. >>>>>>>>>>> > > > >>>>>>>>>> >>>>>>>>>>> > > > >>>>>>>>>> If Denis M. would be able to look througt the >>>>>>>>>>> changes faster >>>>>>>>>>> > > > than >>>>>>>>>>> > > > >>>>>>>>>> me, I can merge without detailed review. >>>>>>>>>>> > > > >>>>>>>>>> >>>>>>>>>>> > > > >>>>>>>>>> =D0=BF=D1=82, 6 =D0=B0=D0=BF=D1=80. 2018 =D0= =B3. =D0=B2 16:15, =D0=A0=D0=BE=D0=BC=D0=B0=D0=BD =D0=9C=D0=B5=D0=B5=D1=80= =D1=81=D0=BE=D0=BD < >>>>>>>>>>> > > homich1991@gmail.com >>>>>>>>>>> > > > >: >>>>>>>>>>> > > > >>>>>>>>>> >>>>>>>>>>> > > > >>>>>>>>>>> OK >>>>>>>>>>> > > > >>>>>>>>>>> >>>>>>>>>>> > > > >>>>>>>>>>> [image: 1486924635147168240.jpg] >>>>>>>>>>> > > > >>>>>>>>>>> >>>>>>>>>>> > > > >>>>>>>>>>> >>>>>>>>>>> > > > >>>>>>>>>>> =D0=BF=D1=82, 6 =D0=B0=D0=BF=D1=80. 2018 =D0= =B3. =D0=B2 17:08, Igor Sapego < >>>>>>>>>>> > isapego@apache.org >>>>>>>>>>> > > >: >>>>>>>>>>> > > > >>>>>>>>>>> >>>>>>>>>>> > > > >>>>>>>>>>>> Hi, >>>>>>>>>>> > > > >>>>>>>>>>>> Well, Dmitry has said he's going to merge it >>>>>>>>>>> in 3-4 days 2 >>>>>>>>>>> > > > days >>>>>>>>>>> > > > >>>>>>>>>>>> ago, >>>>>>>>>>> > > > >>>>>>>>>>>> so I guess, the merge is going to happen in >>>>>>>>>>> 1-2 days or >>>>>>>>>>> > so. >>>>>>>>>>> > > > >>>>>>>>>>>> >>>>>>>>>>> > > > >>>>>>>>>>>> >>>>>>>>>>> > > > >>>>>>>>>>>> Best Regards, >>>>>>>>>>> > > > >>>>>>>>>>>> Igor >>>>>>>>>>> > > > >>>>>>>>>>>> >>>>>>>>>>> > > > >>>>>>>>>>>> On Fri, Apr 6, 2018 at 3:48 PM, =D0=A0=D0=BE= =D0=BC=D0=B0=D0=BD =D0=9C=D0=B5=D0=B5=D1=80=D1=81=D0=BE=D0=BD >>>>>>>>>>> < >>>>>>>>>>> > > > >>>>>>>>>>>> homich1991@gmail.com> wrote: >>>>>>>>>>> > > > >>>>>>>>>>>> >>>>>>>>>>> > > > >>>>>>>>>>>> > Hi all! >>>>>>>>>>> > > > >>>>>>>>>>>> > >>>>>>>>>>> > > > >>>>>>>>>>>> > As i see everything is awesome and there i= s >>>>>>>>>>> no >>>>>>>>>>> > objections, >>>>>>>>>>> > > > so >>>>>>>>>>> > > > >>>>>>>>>>>> when my PR >>>>>>>>>>> > > > >>>>>>>>>>>> > would be merged? >>>>>>>>>>> > > > >>>>>>>>>>>> > >>>>>>>>>>> > > > >>>>>>>>>>>> > =D1=87=D1=82, 5 =D0=B0=D0=BF=D1=80. 2018 = =D0=B3. =D0=B2 18:58, =D0=92=D1=8F=D1=87=D0=B5=D1=81=D0=BB=D0=B0=D0=B2 >>>>>>>>>>> =D0=9A=D0=BE=D0=BF=D1=82=D0=B8=D0=BB=D0=B8=D0=BD < >>>>>>>>>>> > > > >>>>>>>>>>>> slava.koptilin@gmail.com>: >>>>>>>>>>> > > > >>>>>>>>>>>> > >>>>>>>>>>> > > > >>>>>>>>>>>> > > Thank you, Roman! >>>>>>>>>>> > > > >>>>>>>>>>>> > > >>>>>>>>>>> > > > >>>>>>>>>>>> > > 2018-04-05 17:49 GMT+03:00 =D0=A0=D0=BE= =D0=BC=D0=B0=D0=BD =D0=9C=D0=B5=D0=B5=D1=80=D1=81=D0=BE=D0=BD < >>>>>>>>>>> > > > >>>>>>>>>>>> homich1991@gmail.com>: >>>>>>>>>>> > > > >>>>>>>>>>>> > > >>>>>>>>>>> > > > >>>>>>>>>>>> > > > Hi Slava, >>>>>>>>>>> > > > >>>>>>>>>>>> > > > >>>>>>>>>>> > > > >>>>>>>>>>>> > > > Fixed >>>>>>>>>>> > > > >>>>>>>>>>>> > > > >>>>>>>>>>> > > > >>>>>>>>>>>> > > > =D1=87=D1=82, 5 =D0=B0=D0=BF=D1=80. 20= 18 =D0=B3. =D0=B2 18:41, =D0=92=D1=8F=D1=87=D0=B5=D1=81=D0=BB=D0=B0=D0=B2 >>>>>>>>>>> =D0=9A=D0=BE=D0=BF=D1=82=D0=B8=D0=BB=D0=B8=D0=BD < >>>>>>>>>>> > > > >>>>>>>>>>>> > slava.koptilin@gmail.com >>>>>>>>>>> > > > >>>>>>>>>>>> > > >: >>>>>>>>>>> > > > >>>>>>>>>>>> > > > >>>>>>>>>>> > > > >>>>>>>>>>>> > > > > Hi Roman, >>>>>>>>>>> > > > >>>>>>>>>>>> > > > > >>>>>>>>>>> > > > >>>>>>>>>>>> > > > > please take into account my comment >>>>>>>>>>> > > > >>>>>>>>>>>> IgniteQueryGenerator.java >>>>>>>>>>> > > > >>>>>>>>>>>> > > > > < >>>>>>>>>>> > > > >>>>>>>>>>>> > > > > >>>>>>>>>>> > > > >>>>>>>>>>>> https://reviews.ignite.apache. >>>>>>>>>>> > org/ignite/review/IGNT-CR-541 >>>>>>>>>>> > > ? >>>>>>>>>>> > > > >>>>>>>>>>>> > > > commentId=3Dde43c65f-9ac7-4080- >>>>>>>>>>> > > > 9904-aec119138c94&filePath=3D/ >>>>>>>>>>> > > > >>>>>>>>>>>> > > > modules/spring-data-2.0/src/ >>>>>>>>>>> > > > main/java/org/apache/ignite/ >>>>>>>>>>> > > > >>>>>>>>>>>> > > > springdata/repository/query/ >>>>>>>>>>> > IgniteQueryGenerator.java >>>>>>>>>>> > > > >>>>>>>>>>>> > > > > > >>>>>>>>>>> > > > >>>>>>>>>>>> > > > > >>>>>>>>>>> > > > >>>>>>>>>>>> > > > > Best regards, >>>>>>>>>>> > > > >>>>>>>>>>>> > > > > Slava. >>>>>>>>>>> > > > >>>>>>>>>>>> > > > > >>>>>>>>>>> > > > >>>>>>>>>>>> > > > > 2018-04-05 14:59 GMT+03:00 =D0=A0=D0= =BE=D0=BC=D0=B0=D0=BD >>>>>>>>>>> =D0=9C=D0=B5=D0=B5=D1=80=D1=81=D0=BE=D0=BD < >>>>>>>>>>> > > > >>>>>>>>>>>> homich1991@gmail.com>: >>>>>>>>>>> > > > >>>>>>>>>>>> > > > > >>>>>>>>>>> > > > >>>>>>>>>>>> > > > > > Ok, so waiting for accept and comm= it >>>>>>>>>>> > > > >>>>>>>>>>>> > > > > > >>>>>>>>>>> > > > >>>>>>>>>>>> > > > > > =D1=87=D1=82, 5 =D0=B0=D0=BF=D1=80= . 2018 =D0=B3. =D0=B2 15:29, Alexey >>>>>>>>>>> Kukushkin < >>>>>>>>>>> > > > >>>>>>>>>>>> > > > kukushkinalexey@gmail.com >>>>>>>>>>> > > > >>>>>>>>>>>> > > > > >: >>>>>>>>>>> > > > >>>>>>>>>>>> > > > > > >>>>>>>>>>> > > > >>>>>>>>>>>> > > > > > > Roman, >>>>>>>>>>> > > > >>>>>>>>>>>> > > > > > > >>>>>>>>>>> > > > >>>>>>>>>>>> > > > > > > Just pay commiter's (Dmitry >>>>>>>>>>> Pavlov will most >>>>>>>>>>> > > > likely >>>>>>>>>>> > > > >>>>>>>>>>>> commit your >>>>>>>>>>> > > > >>>>>>>>>>>> > > code) >>>>>>>>>>> > > > >>>>>>>>>>>> > > > > > > attention to include the new tes= t >>>>>>>>>>> suite to >>>>>>>>>>> > > > TeamCity >>>>>>>>>>> > > > >>>>>>>>>>>> > configuration. >>>>>>>>>>> > > > >>>>>>>>>>>> > > > > > > >>>>>>>>>>> > > > >>>>>>>>>>>> > > > > > >>>>>>>>>>> > > > >>>>>>>>>>>> > > > > >>>>>>>>>>> > > > >>>>>>>>>>>> > > > >>>>>>>>>>> > > > >>>>>>>>>>>> > > >>>>>>>>>>> > > > >>>>>>>>>>>> > >>>>>>>>>>> > > > >>>>>>>>>>>> >>>>>>>>>>> > > > >>>>>>>>>>> >>>>>>>>>>> > > > > >>>>>>>>>>> > > > >>>>>>>>>>> > > >>>>>>>>>>> > >>>>>>>>>>> >>>>>>>>>> --000000000000818730056bb14c0b--