ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Александр Меньшиков <sharple...@gmail.com>
Subject IGNITE-8238
Date Tue, 29 May 2018 16:10:32 GMT
Hi, Andrew.

You suggested continuing the discussion on dev-list about IGNITE-8238 [1]
I have reworked my PR [2]. Have I moved in the right direction?

I see 57 usages of `checkpointReadLock` in the core module (without tests).
And it still unclear for me should I catch all exceptions from
`checkpointReadLock` or not?
Some places look okay like usage inside overrides of `GridWorker#body`.
But for example `GridCacheAdapter#getAllAsync0` makes me worry.

[1] https://issues.apache.org/jira/browse/IGNITE-8238
[2] https://github.com/apache/ignite/pull/3993/files

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message