From dev-return-32876-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Wed Apr 4 12:41:28 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 394B518064F for ; Wed, 4 Apr 2018 12:41:28 +0200 (CEST) Received: (qmail 83342 invoked by uid 500); 4 Apr 2018 10:41:27 -0000 Mailing-List: contact dev-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list dev@ignite.apache.org Received: (qmail 83326 invoked by uid 99); 4 Apr 2018 10:41:26 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Apr 2018 10:41:26 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 1C51E180318 for ; Wed, 4 Apr 2018 10:41:26 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.398 X-Spam-Level: ** X-Spam-Status: No, score=2.398 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=2, KAM_NUMSUBJECT=0.5, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id yRlm5GWbAInU for ; Wed, 4 Apr 2018 10:41:23 +0000 (UTC) Received: from mail-wr0-f171.google.com (mail-wr0-f171.google.com [209.85.128.171]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 2BA275F398 for ; Wed, 4 Apr 2018 10:41:23 +0000 (UTC) Received: by mail-wr0-f171.google.com with SMTP id z73so21832716wrb.0 for ; Wed, 04 Apr 2018 03:41:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=lZeYFir6BKYGxbXGRP3grciJNbRHJ7HIa89jSvL0EiE=; b=MX/VPHJiaAh41rZT7PjYR8l9X1PlKTFEhQdSI7+fFPmc+l4WZpqZdxU586LVKZVm2s 5IYvSqknnVxMVPGuUVmpAkkeQ294YxoEhM1D8p8jPKjkIQifT6Uolz4y0FO/KUNh3/pf oce75Unu3axRH6SMYk+3o2fj+FIGbaIEGkR2DnYHiadz1Rb8oeLCpcGyH968N1GDoD1G sgP9WhI3E7UqWCPRElzPGYpj+/JB9wHZlU48p4OM0YpvpzDgTDYpQnOqfaMrvKfPz0+R /aq2EZSJn0AvRLdxaQ2NnydGrzjW2HdwDbyhQFUuiYqTsBDnNogL4zr1Tcq1ilWXwgRf m/XQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=lZeYFir6BKYGxbXGRP3grciJNbRHJ7HIa89jSvL0EiE=; b=c5x84NHlQizlSReoSUKgIYKTA4IYGPva8w3MclmEHbB0Zme155K1TNgwKFknzP4o5l kL/TOREV6V3MX4rkSJqhSsmyGeMtgQwgsy2oMlBmprGtNQ5X3XvK9d/HnnhrKAsAP1tX B6aXogTU6sbmGgr04vk9KEJOAeVp+cxtLfA6sEft4XMYyF79aHz4a4qbWM1jGETap7zI I7GtXKFyOHM/RRpkDgKdISVZ5JQlFAx8TftvIjLV2aGx06Qnuw8gSEkk3JvMAMJTbOVs 6j/N0u84u/eHHNWf4TEwdotCkHYHOQgGlYyG5AZzu8Tds3l5Xh6tdrJyu6s9L5g04AJ1 aP5A== X-Gm-Message-State: AElRT7Hw4LlK1iDYVCTBWKY9HbF+K7EUdRhWAhUhBqVftJxuweaZusJR Z3dAC9e9BFRgXw8VuByrFULvQifPa7NThqBMaSPW1A== X-Google-Smtp-Source: AIpwx4/cnbD8nUJvvsufPicw438k5dHOh7Gja3D6pb2AFR1P5pQfqFvM/1vZ9aH+36yheutFCG7xAtEsaDgkWfC3fsQ= X-Received: by 10.223.135.83 with SMTP id 19mr11634385wrz.150.1522838476537; Wed, 04 Apr 2018 03:41:16 -0700 (PDT) MIME-Version: 1.0 Received: by 10.223.196.171 with HTTP; Wed, 4 Apr 2018 03:41:15 -0700 (PDT) In-Reply-To: References: From: Alexey Kukushkin Date: Wed, 4 Apr 2018 13:41:15 +0300 Message-ID: Subject: Re: IGNITE-6879 To: dev@ignite.apache.org Content-Type: multipart/alternative; boundary="001a1146c2f871c4800569037694" --001a1146c2f871c4800569037694 Content-Type: text/plain; charset="UTF-8" Roman, Dmitry, I also reviewed the fix and the code looks OK to me. But the fix has significant implication - Ignite no longer can be used with spring-data 1.0 due to no backward compatibility between spring 2.0 and 1.0 APIs. With this approach we must remember to add corresponding spring-data migration instructions to the future ignite 2.5 migration guide. We could keep spring 1 support and backward compatibility by creating a new module "ignite-spring-2-data" and keeping existing ignite-spring-data as is. I do not like this option since to me increased complexity and maintainability costs overweight the benefits of protecting "Ignite-spring-1" users. I suggest you find a committer (see this list ), communicate the implication I mentioned above and say that two people already approved the code providing we are OK with the chosen approach. --001a1146c2f871c4800569037694--