From dev-return-33089-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Mon Apr 9 15:02:00 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 8719B180645 for ; Mon, 9 Apr 2018 15:01:59 +0200 (CEST) Received: (qmail 40542 invoked by uid 500); 9 Apr 2018 13:01:58 -0000 Mailing-List: contact dev-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list dev@ignite.apache.org Received: (qmail 40531 invoked by uid 99); 9 Apr 2018 13:01:58 -0000 Received: from mail-relay.apache.org (HELO mailrelay2-lw-us.apache.org) (207.244.88.137) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 09 Apr 2018 13:01:58 +0000 Received: from mail-ot0-f182.google.com (mail-ot0-f182.google.com [74.125.82.182]) by mailrelay2-lw-us.apache.org (ASF Mail Server at mailrelay2-lw-us.apache.org) with ESMTPSA id 945221D1D for ; Mon, 9 Apr 2018 13:01:57 +0000 (UTC) Received: by mail-ot0-f182.google.com with SMTP id j8-v6so8453193ota.7 for ; Mon, 09 Apr 2018 06:01:57 -0700 (PDT) X-Gm-Message-State: ALQs6tDZaf2+9nRkkEraPNpyf9J9NZ4KBGRX3bt2ngWEfTPG5qNcsYHW IDx6EoAzeX5AQAPnVnv5Kxvkf3JLLLt3mkIPpsWuZg== X-Google-Smtp-Source: AIpwx4/KctBScGceY4TQIbQkfXEZKfmgZTasvwhhVxHr0mUo+D1ZfIjSIQaTLCjAfp2lH5GsA3x8k/V1rASQTmuGM2U= X-Received: by 2002:a9d:481a:: with SMTP id c26-v6mr23863789otf.393.1523278916394; Mon, 09 Apr 2018 06:01:56 -0700 (PDT) MIME-Version: 1.0 Received: by 10.201.118.131 with HTTP; Mon, 9 Apr 2018 06:01:15 -0700 (PDT) In-Reply-To: References: From: Dmitriy Setrakyan Date: Mon, 9 Apr 2018 06:01:15 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: IGNITE-6827 - Review needed. To: dev Content-Type: multipart/alternative; boundary="000000000000b4bfa605696a0288" --000000000000b4bfa605696a0288 Content-Type: text/plain; charset="UTF-8" On Mon, Apr 9, 2018 at 5:42 AM, Alexey Goncharuk wrote: > Guys, > > After the review in Upsource the configuration parameter was renamed > to txTimeoutOnPartMapSync, and it makes sense to me because PME is an > implementation detail and it may change in future, partition map sync is a > more abstract term. For the same reason I like this parameter being placed > on transactions configuration - we do not have any parameters for PME, so > the configuration property goes to an object which affects a user-exposed > API. > AG, are we going to have any other timeouts on PME, like locks? If yes, then I would still vote of adding PmeTimeout property. --000000000000b4bfa605696a0288--