From dev-return-33611-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Wed Apr 18 23:11:40 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 4D99318064E for ; Wed, 18 Apr 2018 23:11:40 +0200 (CEST) Received: (qmail 1793 invoked by uid 500); 18 Apr 2018 21:11:39 -0000 Mailing-List: contact dev-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list dev@ignite.apache.org Received: (qmail 1777 invoked by uid 99); 18 Apr 2018 21:11:38 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Apr 2018 21:11:38 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id E16301A02EB for ; Wed, 18 Apr 2018 21:11:37 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.229 X-Spam-Level: X-Spam-Status: No, score=0.229 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd2-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id o4oDOlAjb4pY for ; Wed, 18 Apr 2018 21:11:36 +0000 (UTC) Received: from mail-lf0-f52.google.com (mail-lf0-f52.google.com [209.85.215.52]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 9BC2C5F19B for ; Wed, 18 Apr 2018 21:11:36 +0000 (UTC) Received: by mail-lf0-f52.google.com with SMTP id v207-v6so4678995lfa.10 for ; Wed, 18 Apr 2018 14:11:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:message-id:subject:to:cc:date:in-reply-to:references :mime-version; bh=fL/NGqZdVhlNwcB4qx2/mpyXTviNzjQybEgSUERbA2c=; b=sxwaDejhyL/C8SzFv7RptzKPjlkdxmiCCWocojYC9J46DS1kfDhu77L7+dBzC51UAf 3Aol13HhhmipFUjIqv11Zk42V7ZN2pQ2depcWgmDvaY1nextsVk0BY6Cawc6dc1yIvDP J27SIMF6PUcY9iLlEDZXQELdNOg/NU/543qr9MjsHh2ol5sdwFHAXTsl5B5C6orCeKm2 MyCJ/JFI/DoH4XcRNVGPREKcOzUsFOliFCPq4COfJmkLwqYj0RHr7LxF9I/YXeY7mCNZ Hl+6oHeIXmMtlRpzsG33hoefyMDpJeK8Wa9gAFiBPuOrh5uizjCQFI/xcNntD7DSHrhg VuPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:message-id:subject:to:cc:date :in-reply-to:references:mime-version; bh=fL/NGqZdVhlNwcB4qx2/mpyXTviNzjQybEgSUERbA2c=; b=joWwrF7VP9kNg/B1qQlrdWEOsIMIRf5CgzpvnwQk8r7iP0ffBMaB9K/PAHvTRB+Zs4 3BV4XQzdCwwTlOaFHKXE4h+v06Ti8/RYluJf7YhOAI/609nV6pLZak2zUviZZ4Awv6I2 eVWhyFMgMnEh5DhRbDqrfcmXwu+I2PtMUluCPzZGZL8psfqRnoze5egUN1/4RYsSF2bC MLE8ZL3EsaG2z31rTVC+WCFMQrR11vsT9hLpFGpsz7NrYQka1QqAYncC/5RRpiV6RABW f1nvLQgJmy3BQe5NlStPmCnvPGSln2cwR4wya7RDrTugkIJrlWgWRPoIkhZYgmfuRgfB 0Rzw== X-Gm-Message-State: ALQs6tBtb610pHOpGvoS3XRixzpuBH4gP6w4HN+5Rc4SzGO5omORERCz dm6S+Byc09qxhES8OxfQIW+tW3bd X-Google-Smtp-Source: AIpwx48Mi1VfC15gQBxR2DUlla0uDvxM3jiijj7rp+BMeyQzySzMcduRuDf3DExaYqh0SfXN3IOrxA== X-Received: by 10.46.0.208 with SMTP id e77mr2554904lji.12.1524085895666; Wed, 18 Apr 2018 14:11:35 -0700 (PDT) Received: from newDragon ([91.210.95.4]) by smtp.googlemail.com with ESMTPSA id g80-v6sm433140lfg.44.2018.04.18.14.11.34 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 18 Apr 2018 14:11:34 -0700 (PDT) Sender: =?UTF-8?B?0J3QuNC60L7Qu9Cw0Lkg0JjQttC40LrQvtCy?= From: Nikolay Izhikov X-Google-Original-From: Nikolay Izhikov Message-ID: <1524085887.26141.39.camel@gmail.com> Subject: Re: [IGNITE-7909]: Java code examples are needed for Spark Data Frames. To: dev@ignite.apache.org Cc: Akmal Chaudhri Date: Thu, 19 Apr 2018 00:11:27 +0300 In-Reply-To: References: Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-xPDOSZfQjy9CDMaRI3rs" X-Mailer: Evolution 3.26.1-1 Mime-Version: 1.0 --=-xPDOSZfQjy9CDMaRI3rs Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello, Akmal. I see 3 pull requests attached to the ticket [1], [2], [3]. I see 3 java files attached to the ticket, also. Which changes you want to be reviewed and merge? Please, clarify. Delete all unnecessary pull requests link from the ticket. Add new examples to the tests so we can test it on the Team City. You can take IgniteDataFrameSelfTest as an example. I also suggest to rename java examples with "Java" prefix. IgniteDataFrameWriteExample.java -> JavaIgniteDataFrameWriteExample.java [1] https://github.com/apache/ignite/pull/3857 [2] https://github.com/apache/ignite/pull/3858I [3] https://github.com/apache/ignite/pull/3859 [4] https://github.com/apache/ignite/blob/master/examples/src/test/spark/or= g/apache/ignite/spark/examples/IgniteDataFrameSelfTest.java =D0=92 =D0=A1=D1=80, 18/04/2018 =D0=B2 17:20 +0100, Akmal Chaudhri =D0=BF= =D0=B8=D1=88=D0=B5=D1=82: > If any community members have time, please review the code. Three Java > files are attached to the Jira ticket: >=20 > https://issues.apache.org/jira/browse/IGNITE-7909 >=20 > The code should be functionally equivalent to the Scala Data Frames code > that was shipped in 2.4. >=20 > Data Frame documentation is here: >=20 > https://apacheignite-fs.readme.io/docs/ignite-data-frame >=20 > Thank you! --=-xPDOSZfQjy9CDMaRI3rs Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQEcBAABCAAGBQJa17R/AAoJEG4mj244PdRlXUIH/jbq7NV6bmehfTbAH7WghV/n EAYL0UYfDWUG3aBIjg0QMxD9jmkKCW67LmQ8RDwz1wSNCKoKWeQ9b3UknmAP3+pb hq0Zf53B2WwPRnUPK8tUIf57hWRZNz9Qmh3CUPIdSg0E6QrRYHSv3eGW/vN+q3/Z QEy5g4AcQthQLvyKxSUUxZTzIqAyUPLBogQIekrGugwfW/7D1C2acNwEjQRjasgq k68ivIddBDTThmo3fCurxZ4O+xt3gxNCVFol9ETyDUe88iN+CVWizxQw4K2QhTkv TNYAiEGg5nK8jtkW4w9b2QeA6vbMvLPuhhLSKqtNBCCV4DBxuC2JoqPl1hJY+Vw= =KeEo -----END PGP SIGNATURE----- --=-xPDOSZfQjy9CDMaRI3rs--