ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Дмитрий Рябов <somefire...@gmail.com>
Subject Re: IGNITE-6879
Date Sun, 01 Apr 2018 08:39:44 GMT
Dmitry, Alexey, code and tests looks good for me.

JIRA: https://issues.apache.org/jira/browse/IGNITE-6879
PR: https://github.com/apache/ignite/pull/3704
Upsource: https://reviews.ignite.apache.org/ignite/review/IGNT-CR-541
TeamCity:
https://ci.ignite.apache.org/viewLog.html?buildId=1170373&tab=buildResultsDiv&buildTypeId=IgniteTests24Java8_RunAll

2018-03-22 21:48 GMT+03:00 Роман Меерсон <homich1991@gmail.com>:

> Hi all!
>
> Dmitriy thank you for review.
>
> I`ve just fixed all your comments.
>
> чт, 22 мар. 2018 г. в 20:36, Dmitry Pavlov <dpavlov.spb@gmail.com>:
>
>> HI Dmitriy, thank you!
>>
>> Roman, could you please address Dmitriy's comments?
>>
>> чт, 22 мар. 2018 г. в 19:18, Дмитрий Рябов <somefireone@gmail.com>:
>>
>>> Hi Dmitriy,
>>>
>>> I took a look for PR, it needs codestyle fixes.
>>>
>>> 2018-03-19 14:22 GMT+03:00 Dmitry Pavlov <dpavlov.spb@gmail.com>:
>>>
>>>> Hi Alexey,
>>>>
>>>> Did you find the patch is looking good and is ready to be merged?
>>>>
>>>> Sincerely,
>>>> Dmitriy Pavlov
>>>>
>>>> чт, 15 мар. 2018 г. в 11:19, Alexey Kukushkin <
>>>> kukushkinalexey@gmail.com>:
>>>>
>>>> > Just found the fix is ready - I will review it today or tomorrow.
>>>> >
>>>>
>>>
>>>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message