ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrey Gura <ag...@apache.org>
Subject Re: IGNITE-6827 - Review needed.
Date Mon, 02 Apr 2018 15:18:06 GMT
Guys,

I've looked at IGNITE-6827 implementation and have comment. I think
that rollbackOnTopologyChangeTimeout parameter isn't related with
implemented functionality. It's responsibility of PME to rollback
transactions that blocks exchange, so rollbackOnTopologyChangeTimeout
should be configured for PME not for transactions.

On Mon, Apr 2, 2018 at 2:53 PM, Dmitry Pavlov <dpavlov.spb@gmail.com> wrote:
> Hi Igniters,
>
> A number of .NET tests failed, it seems it requied to be updated/fixed first
>    Ignite Platform .NET Core Linux [ tests 2 ]
>       dll: TransactionsParityTest.TestTransactions (master fail rate 0,0%)
>       dll: CachePartitionedTest.TestTransactionScopeMultiCache(True)
> (master fail rate 0,0%)
>
>    Ignite Queries [1] [ tests 1 ]
>       IgniteBinaryCacheQueryTestSuite:
> IgniteSqlSplitterSelfTest.testReplicatedTablesUsingPartitionedCacheSegmentedClient
> (master fail rate 0,0%)
>
>    Ignite Platform .NET
>       exe: TransactionsParityTest.TestTransactions (master fail rate 0,0%)
>
>    Ignite Platform .NET Long Running [ tests 4 TIMEOUT ]
>       exe:
> CachePartitionedNearEnabledTest.TestTransactionScopeMultiCache(True)
> (master fail rate 0,0%)
>       exe: CachePartitionedTest.TestTransactionScopeMultiCache(True)
> (master fail rate 0,0%)
>       exe: CacheReplicatedTest.TestTransactionScopeMultiCache(True) (master
> fail rate 0,0%)
>
>
> And I don't have statitsics on test timeouts, but several timeouts still
> ocurred:
>    Cache (Restarts) [1] [ tests 0 TIMEOUT , Exit Code ]
>  GridCachePartitionedNearDisabledOptimisticTxNodeRestartTest.testRestartWithTxTenNodesTwoBackups
> (last started) More >>
>
>    Client Nodes [ tests 0 TIMEOUT , Exit Code warn 1 ]
>  IgniteClientReconnectFailoverTest.testReconnectStreamerApi (last started)
>
>    Ignite PDS Indexing [ tests 0 TIMEOUT , Exit Code warn 9 ]
> IgnitePdsDiskErrorsRecoveringTest.testRecoveringOnWALErrorWithoutMmap (last
> started)
>
> Sincerely,
> Dmitriy Pavlov
>
> пн, 2 апр. 2018 г. в 12:48, Alexey Goncharuk <alexey.goncharuk@gmail.com>:
>
>> Guys, especially Vladimir Ozerov, Yakov Zhanov, Dmitriy Setrakyan,
>>
>> While the technical side of the change is being reviewed, I would also ask
>> you to pay attention to the public API changes here.
>>
>> --AG
>>
>> 2018-03-21 23:43 GMT+03:00 Pavel Tupitsyn <ptupitsyn@apache.org>:
>>
>> > Hi Alexei,
>> >
>> > >  Pavel Tupitsyn, could you lend a hand to help completing .NET part
>> (two
>> > new
>> > public API methods are added as a part of working on [3], java code in
>> > branch [2])
>> >
>> > Please file a separate ticket for .NET changes.
>> > I would like to help, but maybe some time later. No need to delay your
>> > changes because of that.
>> >
>> > Thanks,
>> > Pavel
>> >
>> > On Wed, Mar 21, 2018 at 1:08 PM, Dmitry Pavlov <dpavlov.spb@gmail.com>
>> > wrote:
>> >
>> > > Hi Alexei ,
>> > >
>> > > Thank you for contribution, unfortunately there is too much tests
>> failed
>> > > there:
>> > > .NET is broken
>> > >
>> > >   Ignite Platform .NET Long Running [ tests 3 ]
>> > >
>>  CachePartitionedNearEnabledTest.TestTransactionScopeMultiCache(True)
>> > >     CachePartitionedTest.TestTransactionScopeMultiCache(True)
>> > >     CacheReplicatedTest.TestTransactionScopeMultiCache(True)
>> > >
>> > >    Ignite Platform .NET Core Linux [ tests 2 TC_EXIT_CODE ]
>> > >      TransactionsParityTest.TestTransactions (fail rate 0,0%)
>> > >      CachePartitionedTest.TestTransactionScopeMultiCache(True) (fail
>> > rate
>> > > 0,0%)
>> > >
>> > >    Ignite Platform .NET [ tests 1 ] agoncharuk More info >>
>> > >     Test fail rate less than 1%, probably new failure  exe:
>> > > TransactionsParityTest.TestTransactions (fail rate 0,0%)
>> > >
>> > > Too much timeouts:
>> > >    Ignite Cache Failover [2]
>> > >  with CacheAsyncOperationsFailoverTxTest.testPutAllAsyncFailover (last
>> > > started)
>> > >
>> > >    ~[Obsolete] Ignite Cache Expiry Policy [ tests 1 ]
>> > > with  IgniteCacheExpiryPolicyTestSuite:
>> > > IgniteCacheTtlCleanupSelfTest.testDeferredDeleteTtl
>> > >
>> > >  Ignite Cache Restarts [2]
>> > >   with
>> > > GridCachePutAllFailoverSelfTest.testPutAllFailoverNearDisabled
>> > ThreeBackups
>> > > (last started)
>> > >
>> > >   Ignite Cache Restarts [1]
>> > >    with
>> > > GridCachePartitionedNearDisabledOptimisticTxNodeRestartTest.
>> > > testRestartWithTxTenNodesTwoBackups
>> > > (last started)
>> > >
>> > >  Cache [6]
>> > >    with  WalModeChangeAdvancedSelfTest.testServerRestartNonCoordinator
>> > > (last started)
>> > > it is not all.
>> > >
>> > > Please fix tests before review. Also you could change ticket status to
>> > 'In
>> > > Progress'.
>> > >
>> > > As easy option, you can merge current master to your branch, it is
>> > probably
>> > > that some test were fixed already.
>> > >
>> > > Sincerely,
>> > > Dmitriy Pavlov
>> > >
>> > > ср, 21 мар. 2018 г. в 9:58, Alexei Scherbakov <
>> > > alexey.scherbakoff@gmail.com
>> > > >:
>> > >
>> > > > Igniters,
>> > > >
>> > > > I prepared rather important patch [1] related to grid stability and
>> > need
>> > > a
>> > > > review and some help to finish it.
>> > > >
>> > > > Semyon Boikov, could you please take a look on patch code ? [2]
>> > > >
>> > > > Pavel Tupitsyn, could you lend a hand to help completing .NET part
>> (two
>> > > new
>> > > > public API methods are added as a part of working on [3], java code
>> in
>> > > > branch [2])
>> > > >
>> > > > [1] https://issues.apache.org/jira/browse/IGNITE-6827
>> > > >
>> > > > [2] https://github.com/gridgain/apache-ignite/tree/ignite-6827-2
>> > > >
>> > > > [3] https://issues.apache.org/jira/browse/IGNITE-7910
>> > > >
>> > > > --
>> > > >
>> > > > Best regards,
>> > > > Alexei Scherbakov
>> > > >
>> > >
>> >
>>

Mime
View raw message