ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexey Goncharuk <alexey.goncha...@gmail.com>
Subject Re: IGNITE-6827 - Review needed.
Date Mon, 09 Apr 2018 12:42:43 GMT
Guys,

After the review in Upsource the configuration parameter was renamed
to txTimeoutOnPartMapSync, and it makes sense to me because PME is an
implementation detail and it may change in future, partition map sync is a
more abstract term. For the same reason I like this parameter being placed
on transactions configuration - we do not have any parameters for PME, so
the configuration property goes to an object which affects a user-exposed
API.

2018-04-03 15:13 GMT+03:00 Andrey Gura <agura@apache.org>:

> Alexey,
>
> could you please create code review in Upsource? The PR is huge and it
> would be great to have an ability to discuss changes in more
> convenient way.
>
> Thanks.
>
> On Tue, Apr 3, 2018 at 12:42 AM, Dmitriy Setrakyan
> <dsetrakyan@apache.org> wrote:
> > I looked into the ticket and do not understand this property
> > name: RollbackOnTopologyChangeTimeout
> >
> > I think what we need to configure is a forceful kill of transactions in
> > case of partition map exchange, right? In that case, the timeout should
> be
> > configured for PME, not transactions. The property name should be
> > PartitionMapExchangePreparationTimeout or PartitionMapExchangeTxTimeout.
> >
> > Am I missing something?
> >
> > D.
> >
> > On Mon, Apr 2, 2018 at 2:48 AM, Alexey Goncharuk <
> alexey.goncharuk@gmail.com
> >> wrote:
> >
> >> Guys, especially Vladimir Ozerov, Yakov Zhanov, Dmitriy Setrakyan,
> >>
> >> While the technical side of the change is being reviewed, I would also
> ask
> >> you to pay attention to the public API changes here.
> >>
> >> --AG
> >>
> >> 2018-03-21 23:43 GMT+03:00 Pavel Tupitsyn <ptupitsyn@apache.org>:
> >>
> >> > Hi Alexei,
> >> >
> >> > >  Pavel Tupitsyn, could you lend a hand to help completing .NET part
> >> (two
> >> > new
> >> > public API methods are added as a part of working on [3], java code in
> >> > branch [2])
> >> >
> >> > Please file a separate ticket for .NET changes.
> >> > I would like to help, but maybe some time later. No need to delay your
> >> > changes because of that.
> >> >
> >> > Thanks,
> >> > Pavel
> >> >
> >> > On Wed, Mar 21, 2018 at 1:08 PM, Dmitry Pavlov <dpavlov.spb@gmail.com
> >
> >> > wrote:
> >> >
> >> > > Hi Alexei ,
> >> > >
> >> > > Thank you for contribution, unfortunately there is too much tests
> >> failed
> >> > > there:
> >> > > .NET is broken
> >> > >
> >> > >   Ignite Platform .NET Long Running [ tests 3 ]
> >> > >     CachePartitionedNearEnabledTest.TestTransactionScopeMultiCache
> >> (True)
> >> > >     CachePartitionedTest.TestTransactionScopeMultiCache(True)
> >> > >     CacheReplicatedTest.TestTransactionScopeMultiCache(True)
> >> > >
> >> > >    Ignite Platform .NET Core Linux [ tests 2 TC_EXIT_CODE ]
> >> > >      TransactionsParityTest.TestTransactions (fail rate 0,0%)
> >> > >      CachePartitionedTest.TestTransactionScopeMultiCache(True)
> (fail
> >> > rate
> >> > > 0,0%)
> >> > >
> >> > >    Ignite Platform .NET [ tests 1 ] agoncharuk More info >>
> >> > >     Test fail rate less than 1%, probably new failure  exe:
> >> > > TransactionsParityTest.TestTransactions (fail rate 0,0%)
> >> > >
> >> > > Too much timeouts:
> >> > >    Ignite Cache Failover [2]
> >> > >  with CacheAsyncOperationsFailoverTxTest.testPutAllAsyncFailover
> (last
> >> > > started)
> >> > >
> >> > >    ~[Obsolete] Ignite Cache Expiry Policy [ tests 1 ]
> >> > > with  IgniteCacheExpiryPolicyTestSuite:
> >> > > IgniteCacheTtlCleanupSelfTest.testDeferredDeleteTtl
> >> > >
> >> > >  Ignite Cache Restarts [2]
> >> > >   with
> >> > > GridCachePutAllFailoverSelfTest.testPutAllFailoverNearDisabled
> >> > ThreeBackups
> >> > > (last started)
> >> > >
> >> > >   Ignite Cache Restarts [1]
> >> > >    with
> >> > > GridCachePartitionedNearDisabledOptimisticTxNodeRestartTest.
> >> > > testRestartWithTxTenNodesTwoBackups
> >> > > (last started)
> >> > >
> >> > >  Cache [6]
> >> > >    with  WalModeChangeAdvancedSelfTest.
> testServerRestartNonCoordinator
> >> > > (last started)
> >> > > it is not all.
> >> > >
> >> > > Please fix tests before review. Also you could change ticket status
> to
> >> > 'In
> >> > > Progress'.
> >> > >
> >> > > As easy option, you can merge current master to your branch, it is
> >> > probably
> >> > > that some test were fixed already.
> >> > >
> >> > > Sincerely,
> >> > > Dmitriy Pavlov
> >> > >
> >> > > ср, 21 мар. 2018 г. в 9:58, Alexei Scherbakov <
> >> > > alexey.scherbakoff@gmail.com
> >> > > >:
> >> > >
> >> > > > Igniters,
> >> > > >
> >> > > > I prepared rather important patch [1] related to grid stability
> and
> >> > need
> >> > > a
> >> > > > review and some help to finish it.
> >> > > >
> >> > > > Semyon Boikov, could you please take a look on patch code ? [2]
> >> > > >
> >> > > > Pavel Tupitsyn, could you lend a hand to help completing .NET
part
> >> (two
> >> > > new
> >> > > > public API methods are added as a part of working on [3], java
> code
> >> in
> >> > > > branch [2])
> >> > > >
> >> > > > [1] https://issues.apache.org/jira/browse/IGNITE-6827
> >> > > >
> >> > > > [2] https://github.com/gridgain/apache-ignite/tree/ignite-6827-2
> >> > > >
> >> > > > [3] https://issues.apache.org/jira/browse/IGNITE-7910
> >> > > >
> >> > > > --
> >> > > >
> >> > > > Best regards,
> >> > > > Alexei Scherbakov
> >> > > >
> >> > >
> >> >
> >>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message