ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nikolay Izhikov <nizhi...@apache.org>
Subject Re: [IGNITE-7909]: Java code examples are needed for Spark Data Frames.
Date Wed, 18 Apr 2018 21:11:27 GMT
Hello, Akmal.

I see 3 pull requests attached to the ticket [1], [2], [3].
I see 3 java files attached to the ticket, also.

Which changes you want to be reviewed and merge? Please, clarify.

Delete all unnecessary pull requests link from the ticket.
Add new examples to the tests so we can test it on the Team City.
You can take IgniteDataFrameSelfTest as an example.

I also suggest to rename java examples with "Java" prefix.

IgniteDataFrameWriteExample.java -> JavaIgniteDataFrameWriteExample.java

[1] https://github.com/apache/ignite/pull/3857
[2] https://github.com/apache/ignite/pull/3858I
[3] https://github.com/apache/ignite/pull/3859
[4] https://github.com/apache/ignite/blob/master/examples/src/test/spark/org/apache/ignite/spark/examples/IgniteDataFrameSelfTest.java

В Ср, 18/04/2018 в 17:20 +0100, Akmal Chaudhri пишет:
> If any community members have time, please review the code. Three Java
> files are attached to the Jira ticket:
> https://issues.apache.org/jira/browse/IGNITE-7909
> The code should be functionally equivalent to the Scala Data Frames code
> that was shipped in 2.4.
> Data Frame documentation is here:
> https://apacheignite-fs.readme.io/docs/ignite-data-frame
> Thank you!
View raw message