From dev-return-32243-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Mon Mar 19 13:13:33 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 4E0E1180647 for ; Mon, 19 Mar 2018 13:13:32 +0100 (CET) Received: (qmail 5096 invoked by uid 500); 19 Mar 2018 12:13:31 -0000 Mailing-List: contact dev-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list dev@ignite.apache.org Received: (qmail 5080 invoked by uid 99); 19 Mar 2018 12:13:30 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 19 Mar 2018 12:13:30 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id AA32D18046A for ; Mon, 19 Mar 2018 12:13:29 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.379 X-Spam-Level: ** X-Spam-Status: No, score=2.379 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=2, KAM_NUMSUBJECT=0.5, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id aG6RRAZwmXHj for ; Mon, 19 Mar 2018 12:13:24 +0000 (UTC) Received: from mail-qk0-f169.google.com (mail-qk0-f169.google.com [209.85.220.169]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 143225F343 for ; Mon, 19 Mar 2018 12:13:23 +0000 (UTC) Received: by mail-qk0-f169.google.com with SMTP id z184so17987208qkc.1 for ; Mon, 19 Mar 2018 05:13:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=f985q+979pxzHyAIZ4AQoi/ubJ9VXN8Rx5DpNzKeGH4=; b=cibWxKzzGRbH5MPM3qERDNASfimoR2vF+o8nRw6MGm1Kt1JAoZH6soZUxVVVg8Tpvy /aBV4IgxXoVQ2tAlKbxB/nULz5TFjGmWzIJRvzXJ5axAO0FzI/AOgjZtia+nS3j4bp+c w8EQY4zDUm/0sQUbUp4JrIspcmpg5zVhA2twaJJfUBydsCWUatQGxq3DwYTeNWvblwGs oz5CRHljaikNpAtQ4bcbtNnJ0J258hm0TkNZdHxp0W9VQ8O0qdDtA+emZEzDBklb3BWD CtKEJ2Shapy2aXhDMUDZODI6BFVDzFnfFwFpfMzyOmDZb5dSFoRdXlIU1cLBU02LVRAu W7yQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=f985q+979pxzHyAIZ4AQoi/ubJ9VXN8Rx5DpNzKeGH4=; b=ZDDuVixZg/Hf9qm3fkBmIsVJA+ee8uKD4fx7/J/WyaQNey/Bt3wtdfWp2M2O06/Qks jN1jC+TcFrQRpMqLamUgNJJUOs+Vjwj8EwG3AfMb0xjuLd0MAydUM2sO810zEoNlv+fo 1v+Mh8bg6OJyJSQbFLQVPD+sFTYEaa+UV3ZDmg10jlMMviXsVmBLbiDsCgGyBEpQljr/ WwvUgizhjGFQFvS0cGi3qn+84lPje2NxCKJskYviYI5m7g/e2QN6FkBo1dLR8M2l4zPg c/pcJbqCGQ3igr+lCnB3eWTbHIBU87pS+tUKMludFKShHA9rbGjtcx3r0x/qgE4yRNn9 wdFA== X-Gm-Message-State: AElRT7H+LJ9gDtx3CjtbhS8PDR0/0i9BhAVeR4z8T5zk6ajvOXMvr78I l9LuX0wKp6vxXDWVNCdFq9SbOZB4IvnUhbs6sg0= X-Google-Smtp-Source: AG47ELsi3b1rS5mfNZkau7o5XENDAalCIHomRlgoiMOwdLUN8WMExzA1fmPeKtsuO36bEy2/hGOuRQTfeOP2VMszylw= X-Received: by 10.55.222.20 with SMTP id h20mr17192210qkj.151.1521461600545; Mon, 19 Mar 2018 05:13:20 -0700 (PDT) MIME-Version: 1.0 References: <0B392DA6-09A6-4EDC-B1EE-4F50851BCBBE@apache.org> In-Reply-To: From: Maxim Muzafarov Date: Mon, 19 Mar 2018 12:13:09 +0000 Message-ID: Subject: Re: Stop nodes after test by default - IGNITE-6842 To: dev@ignite.apache.org, Dmitry Pavlov Content-Type: multipart/alternative; boundary="089e082dc2283d6f570567c2e232" --089e082dc2283d6f570567c2e232 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Dmitry and other igniters, Will you have time to review this issue? I've preperated PR and TC for this, also I've fixed all comments made by Andrey Kuznetsov and Vyacheslav Daradur. I think this is important issue and will make test framework more stable and clear. TC: https://ci.ignite.apache.org/viewLog.html?buildId=3D1138151 JIRA: https://issues.apache.org/jira/browse/IGNITE-6842 Upsource: https://reviews.ignite.apache.org/ignite/review/IGNT-CR-502 PR: https://github.com/apache/ignite/pull/3542 =D1=87=D1=82, 15 =D0=BC=D0=B0=D1=80. 2018 =D0=B3. =D0=B2 13:31, Maxim Muzaf= arov : > Dmtry, > > Can we proceed with this change? > I've done with fixing review comments and tests that you mentioned before= . > > TC: https://ci.ignite.apache.org/viewLog.html?buildId=3D1138151 > JIRA: https://issues.apache.org/jira/browse/IGNITE-6842 > Upsource: https://reviews.ignite.apache.org/ignite/review/IGNT-CR-502 > PR: https://github.com/apache/ignite/pull/3542 > > > > =D0=B2=D1=82, 6 =D0=BC=D0=B0=D1=80. 2018 =D0=B3. =D0=B2 20:42, Dmitry Pav= lov : > >> Ok, thank you. >> >> Please let me know when we can proceed with review >> https://reviews.ignite.apache.org/ignite/review/IGNT-CR-502 >> >> >> =D0=B2=D1=82, 6 =D0=BC=D0=B0=D1=80. 2018 =D0=B3. =D0=B2 20:17, Maxim Muz= afarov : >> >> > Hello Dmitry, >> > >> > Yes, I've updated test classes as you metioned before. >> > Now i'm fixing review comments. Within next few days I'll prepare fina= l >> > version of this PR. >> > >> > =D0=B2=D1=82, 6 =D0=BC=D0=B0=D1=80. 2018 =D0=B3. =D0=B2 20:12, Dmitry = Pavlov : >> > >> > > Hi Maxim, >> > > >> > > are there any news on these test fails? >> > > >> > > Is issue ready for review? >> > > >> > > Sincerely, >> > > Dmitiry Pavlov >> > > >> > > =D0=B2=D1=82, 27 =D1=84=D0=B5=D0=B2=D1=80. 2018 =D0=B3. =D0=B2 17:12= , Dmitry Pavlov : >> > > >> > > > Hi, thank you! >> > > > >> > > > I've found several suspicious fails: such test fails have rate les= s >> > than >> > > > 1%, it is probably new failures. >> > > > >> > > > It would be great if we can fix it before merge. Could you address >> this >> > > > fails? >> > > > >> > > > Sincerely, >> > > > Dmitriy Pavlov >> > > > >> > > > IgniteCacheTestSuite5: IgniteCacheStoreCollectionTest.testStoreMap >> > (fail >> > > > rate 0,0%) >> > > > IgniteCacheTestSuite5: >> > > > CacheLateAffinityAssignmentTest.testDelayAssignmentClientJoin (fai= l >> > rate >> > > > 0,0%) >> > > > IgniteCacheWithIndexingTestSuite: >> > > > CacheRandomOperationsMultithreadedTest.testAtomicOffheapEviction >> (fail >> > > rate >> > > > 0,0%) >> > > > IgniteCacheWithIndexingTestSuite: >> > > > >> > CacheRandomOperationsMultithreadedTest.testAtomicOffheapEvictionIndexi= ng >> > > > (fail rate 0,0%) >> > > > IgniteCacheWithIndexingTestSuite: >> > > > CacheRandomOperationsMultithreadedTest.testTxOffheapEviction (fail >> rate >> > > > 0,0%) >> > > > IgniteCacheWithIndexingTestSuite: >> > > > CacheRandomOperationsMultithreadedTest.testTxOffheapEvictionIndexi= ng >> > > (fail >> > > > rate 0,0%) >> > > > >> > > > IgniteBinarySimpleNameMapperCacheFullApiTestSuite: >> > > > >> > > >> > >> GridCachePartitionedNearDisabledMultiNodeWithGroupFullApiSelfTest.testWi= thSkipStoreTx >> > > > (fail rate 0,0%) >> > > > >> > > > =D0=B2=D1=82, 27 =D1=84=D0=B5=D0=B2=D1=80. 2018 =D0=B3. =D0=B2 17:= 04, Maxim Muzafarov : >> > > > >> > > >> Yep, link may not be correct. >> > > >> >> > > >> Here is correct version: >> > > >> TC: * >> > > >> >> > > >> > >> https://ci.ignite.apache.org/project.html?projectId=3DIgniteTests24Java8= &branch_IgniteTests24Java8=3Dpull%2F3542%2Fhead >> > > >> < >> > > >> >> > > >> > >> https://ci.ignite.apache.org/project.html?projectId=3DIgniteTests24Java8= &branch_IgniteTests24Java8=3Dpull%2F3542%2Fhead >> > > >> >* >> > > >> >> > > >> >> > > >> =D0=B2=D1=82, 27 =D1=84=D0=B5=D0=B2=D1=80. 2018 =D0=B3. =D0=B2 16= :41, Dmitry Pavlov > >: >> > > >> >> > > >> > Hi Maxim, >> > > >> > >> > > >> > could you please provide link to TC run on your PR? It seems li= nk >> > > >> provided >> > > >> > points to run of master. In changes field you may select >> > > pull/3542/head >> > > >> > before starting RunAll. >> > > >> > >> > > >> > Igniters, >> > > >> > >> > > >> > this change is related to our test framework, so change may >> affect >> > > your >> > > >> > tests. Please join to review >> > > >> > https://reviews.ignite.apache.org/ignite/review/IGNT-CR-502 >> > > >> > >> > > >> > Sincerely, >> > > >> > Dmitriy Pavlov >> > > >> > >> > > >> > =D0=B2=D1=82, 27 =D1=84=D0=B5=D0=B2=D1=80. 2018 =D0=B3. =D0=B2 = 16:14, Maxim Muzafarov < >> maxmuzaf@gmail.com>: >> > > >> > >> > > >> > > Hi all, >> > > >> > > >> > > >> > > I think, I've done with this issue, what should we do next? >> > > >> > > >> > > >> > > PR: https://github.com/apache/ignite/pull/3542 >> > > >> > > Upsource: >> > > https://reviews.ignite.apache.org/ignite/review/IGNT-CR-502 >> > > >> > > TC: >> > > >> > > >> > > >> > > >> > > >> > >> > > >> >> > > >> > >> https://ci.ignite.apache.org/viewModification.html?modId=3D723895&person= al=3Dfalse&buildTypeId=3D&tab=3DvcsModificationTests >> > > >> > > JIRA: https://issues.apache.org/jira/browse/IGNITE-6842 >> > > >> > > >> > > >> > > >> > > >> > > =D1=87=D1=82, 22 =D1=84=D0=B5=D0=B2=D1=80. 2018 =D0=B3. =D0= =B2 14:12, Dmitry Pavlov < >> > dpavlov.spb@gmail.com >> > > >: >> > > >> > > >> > > >> > > > Hi Maxim, >> > > >> > > > >> > > >> > > > Thank you. >> > > >> > > > >> > > >> > > > To my mind stopAllGrids call should be kept in >> afterTestsStop(). >> > > If >> > > >> > > > developer forgot to call super(), he will see exception fro= m >> > > >> > > > beforeTestsStart() >> > > >> > > > added by you. >> > > >> > > > >> > > >> > > > If you think patch is ready to be reviewed, please change >> JIRA >> > > >> status >> > > >> > to >> > > >> > > > "Patch Available". >> > > >> > > > >> > > >> > > > Optionally you can create Upsource review. It would be easi= er >> > for >> > > >> > > multiple >> > > >> > > > reviewers to handle this patch. This test framework is used >> by >> > all >> > > >> > > Igniters >> > > >> > > > so Upsource would be good option ( >> > > >> https://reviews.ignite.apache.org/ >> > > >> > ). >> > > >> > > > >> > > >> > > > Sincerely, >> > > >> > > > Dmitriy Pavlov >> > > >> > > > >> > > >> > > > =D1=87=D1=82, 22 =D1=84=D0=B5=D0=B2=D1=80. 2018 =D0=B3. =D0= =B2 13:44, Maxim Muzafarov < >> > maxmuzaf@gmail.com >> > > >: >> > > >> > > > >> > > >> > > > > Hi all, >> > > >> > > > > >> > > >> > > > > I've made some changes based on our previous discusstions= , >> > > please >> > > >> see >> > > >> > > PR >> > > >> > > > > [1]: >> > > >> > > > > 1) Remove duplicated code for stopGrid (by index and by >> name); >> > > >> > > > > 2) Add new method that thows exception if not all grids >> > haven't >> > > >> > stopped >> > > >> > > > > correctly; >> > > >> > > > > 3) Change tests that have been affected by this changes; >> > > >> > > > > >> > > >> > > > > Also, I have some thoughts for clarification: >> > > >> > > > > 1) beforeTestsStart() - I expect here in subtests that >> grids >> > are >> > > >> not >> > > >> > > > > started yet. Am I right? >> > > >> > > > > 2) I think we should call stopAllGrids in tearDown method= . >> So, >> > > if >> > > >> in >> > > >> > > some >> > > >> > > > > cases we'll override afterTestsStop in subclasses and >> forgot >> > to >> > > >> call >> > > >> > > > > super() it won't lead us to exception. >> > > >> > > > > >> > > >> > > > > [1] https://github.com/apache/ignite/pull/3542 >> > > >> > > > > [2] >> > > >> https://ci.ignite.apache.org/viewModification.html?modId=3D717275 >> > > >> > > > > [3] https://issues.apache.org/jira/browse/IGNITE-6842 >> > > >> > > > > >> > > >> > > > > >> > > >> > > > > =D1=81=D1=80, 7 =D1=84=D0=B5=D0=B2=D1=80. 2018 =D0=B3. = =D0=B2 18:28, Maxim Muzafarov < >> > > maxmuzaf@gmail.com >> > > >> >: >> > > >> > > > > >> > > >> > > > > > Thank you all, >> > > >> > > > > > >> > > >> > > > > > I'll add this comment's for JIRA ticket, if you don't >> mind. >> > > >> > > > > > >> > > >> > > > > > =D1=81=D1=80, 7 =D1=84=D0=B5=D0=B2=D1=80. 2018 =D0=B3. = =D0=B2 15:16, Dmitry Pavlov < >> > > >> dpavlov.spb@gmail.com >> > > >> > >: >> > > >> > > > > > >> > > >> > > > > >> Yes, this solution allows to cover both cases: >> > > >> > > > > >> a) not stopped node from previous test and >> > > >> > > > > >> b) allows to remove useless code that stops Ignite nod= es >> > from >> > > >> each >> > > >> > > > test. >> > > >> > > > > >> >> > > >> > > > > >> =D1=81=D1=80, 7 =D1=84=D0=B5=D0=B2=D1=80. 2018 =D0=B3.= =D0=B2 15:13, Anton Vinogradov < >> > > >> > > > avinogradov@gridgain.com >> > > >> > > > > >: >> > > >> > > > > >> >> > > >> > > > > >> > Maxim, >> > > >> > > > > >> > >> > > >> > > > > >> > We discussed with Dima privately, and decided >> > > >> > > > > >> > >> > > >> > > > > >> > 1) We have to assert that there is no alive nodes at >> > > >> > > > > GridAbstractTest's >> > > >> > > > > >> > beforeTestsStarted >> > > >> > > > > >> > 2) We have to kill all alive nodes (without force) a= t >> > > >> > > > > GridAbstractTest's >> > > >> > > > > >> > afterTestsStopped >> > > >> > > > > >> > 3) In case of any exceptions at #2 we have to see te= st >> > > error >> > > >> > > > > >> > 4) We can get rid of all useless stopAllGrids at >> > > >> > > GridAbstractTest's >> > > >> > > > > >> > subclasses. >> > > >> > > > > >> > >> > > >> > > > > >> > >> > > >> > > > > >> > >> > > >> > > > > >> > On Wed, Feb 7, 2018 at 2:32 PM, Dmitry Pavlov < >> > > >> > > > dpavlov.spb@gmail.com> >> > > >> > > > > >> > wrote: >> > > >> > > > > >> > >> > > >> > > > > >> > > > Let's just add stopAllGrids(flase) to >> > GridAbstractTest >> > > 's >> > > >> > > > > >> > > afterTestsStopped >> > > >> > > > > >> > > method body. >> > > >> > > > > >> > > >> > > >> > > > > >> > > Can't agree with it becase implicit silent shutdow= n >> of >> > > >> nodes >> > > >> > > from >> > > >> > > > > test >> > > >> > > > > >> > > framework may cause a lot of bugs introduced to >> Ignite. >> > > >> > > > > >> > > >> > > >> > > > > >> > > I think stop+test fail should occur. >> > > >> > > > > >> > > In that case author of incorrect test or not >> consistent >> > > >> Ignite >> > > >> > > > > >> shutdown >> > > >> > > > > >> > > will see problem. >> > > >> > > > > >> > > >> > > >> > > > > >> > > 'Fail fast' if always better than hidding real >> problem >> > > >> under >> > > >> > > > > automatic >> > > >> > > > > >> > > framework feature. >> > > >> > > > > >> > > >> > > >> > > > > >> > > =D1=81=D1=80, 7 =D1=84=D0=B5=D0=B2=D1=80. 2018 =D0= =B3. =D0=B2 14:05, Anton Vinogradov < >> > > >> > > > > >> avinogradov@gridgain.com >> > > >> > > > > >> > >: >> > > >> > > > > >> > > >> > > >> > > > > >> > > > Hi all, >> > > >> > > > > >> > > > >> > > >> > > > > >> > > > > I've made some research about this problem and= i >> > > think >> > > >> > that >> > > >> > > in >> > > >> > > > > >> > general >> > > >> > > > > >> > > we >> > > >> > > > > >> > > > > should move stopAllGrids method in >> GridAbstractTest >> > > >> class >> > > >> > to >> > > >> > > > > >> > > > > afterTestsStopped method with some changes. Am= I >> > > right? >> > > >> > > > > >> > > > Let's just add stopAllGrids(flase) to >> > GridAbstractTest >> > > 's >> > > >> > > > > >> > > > afterTestsStopped method >> > > >> > > > > >> > > > body. >> > > >> > > > > >> > > > >> > > >> > > > > >> > > > > I have a question about stopAllGrids(boolean >> > cancel) >> > > >> this >> > > >> > > > > "cancel" >> > > >> > > > > >> > > > That's just a flag means "do not wait for any >> > > operations >> > > >> > > finish" >> > > >> > > > > >> > > > See no reason to set it true in that case. >> > > >> > > > > >> > > > >> > > >> > > > > >> > > > > If you delegate closing to afterTestsStopped >> this >> > > will >> > > >> > > affect >> > > >> > > > > only >> > > >> > > > > >> > > > > last test (method). >> > > >> > > > > >> > > > The idea is to stop all nodes at last test's >> method >> > > >> finish. >> > > >> > > > > >> > > > >> > > >> > > > > >> > > > > Nodes that survive between tests can affect >> > > successive >> > > >> > > > > >> > > > tests. >> > > >> > > > > >> > > > Thats ok. we have a lot tests where nodes reusab= le >> > > >> between >> > > >> > > > test's >> > > >> > > > > >> > > methods. >> > > >> > > > > >> > > > >> > > >> > > > > >> > > > >> > > >> > > > > >> > > > On Wed, Feb 7, 2018 at 1:20 PM, Dmitry Pavlov < >> > > >> > > > > >> dpavlov.spb@gmail.com> >> > > >> > > > > >> > > > wrote: >> > > >> > > > > >> > > > >> > > >> > > > > >> > > > > Hi Igniters, >> > > >> > > > > >> > > > > >> > > >> > > > > >> > > > > IMO nodes that survive between tests is not >> general >> > > >> > practice >> > > >> > > > and >> > > >> > > > > >> I'm >> > > >> > > > > >> > > not >> > > >> > > > > >> > > > > sure is a best practice. I suggest to mark suc= h >> > tests >> > > >> with >> > > >> > > > some >> > > >> > > > > >> > method >> > > >> > > > > >> > > > > overriden from AbstractTest. >> > > >> > > > > >> > > > > >> > > >> > > > > >> > > > > About cancel flag, please note >> stopAllGrids(boolean >> > > >> > cancel) >> > > >> > > > > >> > > cancel=3Dfalse >> > > >> > > > > >> > > > > allows to wait of checkpoint ends in case >> > persistence >> > > >> > > enabled. >> > > >> > > > > >> > > > > >> > > >> > > > > >> > > > > I still suggest to avoid stopping any nodes by >> > test, >> > > >> but >> > > >> > > > > validate >> > > >> > > > > >> not >> > > >> > > > > >> > > > > stopped node exist and fail test instead of >> siltent >> > > >> > implicit >> > > >> > > > > >> actions. >> > > >> > > > > >> > > > > >> > > >> > > > > >> > > > > Sincerely, >> > > >> > > > > >> > > > > Dmitriy Pavlov >> > > >> > > > > >> > > > > >> > > >> > > > > >> > > > > =D1=81=D1=80, 7 =D1=84=D0=B5=D0=B2=D1=80. 2018= =D0=B3. =D0=B2 13:04, Andrey Kuznetsov < >> > > >> > > > > stkuzma@gmail.com >> > > >> > > > > >> >: >> > > >> > > > > >> > > > > >> > > >> > > > > >> > > > > > Hi Maxim, >> > > >> > > > > >> > > > > > >> > > >> > > > > >> > > > > > Regarding your first question, the use of >> > > >> > > afterTestsStopped >> > > >> > > > is >> > > >> > > > > >> not >> > > >> > > > > >> > > > enough >> > > >> > > > > >> > > > > > to stop all nodes, since each individual tes= t >> > > >> (method) >> > > >> > can >> > > >> > > > > start >> > > >> > > > > >> > > custom >> > > >> > > > > >> > > > > set >> > > >> > > > > >> > > > > > of notes during its operation, and this very >> test >> > > >> should >> > > >> > > > stop >> > > >> > > > > >> all >> > > >> > > > > >> > > those >> > > >> > > > > >> > > > > > nodes. If you delegate closing to >> > afterTestsStopped >> > > >> this >> > > >> > > > will >> > > >> > > > > >> > affect >> > > >> > > > > >> > > > only >> > > >> > > > > >> > > > > > last test (method). Nodes that survive betwe= en >> > > tests >> > > >> can >> > > >> > > > > affect >> > > >> > > > > >> > > > > successive >> > > >> > > > > >> > > > > > tests. >> > > >> > > > > >> > > > > > >> > > >> > > > > >> > > > > > 2018-02-07 1:10 GMT+03:00 Maxim Muzafarov < >> > > >> > > > maxmuzaf@gmail.com >> > > >> > > > > >: >> > > >> > > > > >> > > > > > >> > > >> > > > > >> > > > > > > Hello, >> > > >> > > > > >> > > > > > > >> > > >> > > > > >> > > > > > > I've made some research about this problem >> and >> > i >> > > >> think >> > > >> > > > that >> > > >> > > > > in >> > > >> > > > > >> > > > general >> > > >> > > > > >> > > > > we >> > > >> > > > > >> > > > > > > should move stopAllGrids method in >> > > GridAbstractTest >> > > >> > > class >> > > >> > > > to >> > > >> > > > > >> > > > > > > afterTestsStopped method with some changes= . >> Am >> > I >> > > >> > right? >> > > >> > > > > >> > > > > > > >> > > >> > > > > >> > > > > > > Also, I have a question about >> > > stopAllGrids(boolean >> > > >> > > cancel) >> > > >> > > > > >> this >> > > >> > > > > >> > > > > "cancel" >> > > >> > > > > >> > > > > > > argument. Why in some cases we should >> interrupt >> > > >> > > ComputeJob >> > > >> > > > > >> and in >> > > >> > > > > >> > > > some >> > > >> > > > > >> > > > > > > cases shouldn't? For example here: >> > > >> > > > > >> > > > > > > >> > > >> IgniteBaselineAffinityTopologyActivationTest#afterTest >> > > >> > > > > >> > > > > > > we call method stopAllGrids(false) this wa= y. >> > Why >> > > >> not >> > > >> > > > "true" >> > > >> > > > > >> > > argument >> > > >> > > > > >> > > > > > > instead? >> > > >> > > > > >> > > > > > > >> > > >> > > > > >> > > > > > > >> > > >> > > > > >> > > > > > > -- >> > > >> > > > > >> > > > > > Best regards, >> > > >> > > > > >> > > > > > Andrey Kuznetsov. >> > > >> > > > > >> > > > > > >> > > >> > > > > >> > > > > >> > > >> > > > > >> > > > >> > > >> > > > > >> > > >> > > >> > > > > >> > >> > > >> > > > > >> >> > > >> > > > > > >> > > >> > > > > >> > > >> > > > >> > > >> > > >> > > >> > >> > > >> >> > > > >> > > >> > >> > --089e082dc2283d6f570567c2e232--