From dev-return-32737-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Fri Mar 30 18:15:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id A61AA180647 for ; Fri, 30 Mar 2018 18:15:03 +0200 (CEST) Received: (qmail 31818 invoked by uid 500); 30 Mar 2018 16:15:02 -0000 Mailing-List: contact dev-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list dev@ignite.apache.org Received: (qmail 31806 invoked by uid 99); 30 Mar 2018 16:15:01 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 30 Mar 2018 16:15:01 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 6D52CC08B7 for ; Fri, 30 Mar 2018 16:15:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.211 X-Spam-Level: *** X-Spam-Status: No, score=3.211 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URI_HEX=1.313] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id VYuc7-i0xd8X for ; Fri, 30 Mar 2018 16:14:58 +0000 (UTC) Received: from mail-io0-f196.google.com (mail-io0-f196.google.com [209.85.223.196]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 70C825F24E for ; Fri, 30 Mar 2018 16:14:58 +0000 (UTC) Received: by mail-io0-f196.google.com with SMTP id l3so11549516iog.0 for ; Fri, 30 Mar 2018 09:14:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=BlaseU437UBM3rjpXtOeGFeNTkfKzXzwXFB0L3rPGBA=; b=hFKXM2n1vfvHHnimShNc3vufJqy6njK7IZwIGa3dtNj0gZsq8A9uGApArMA9kvdNDO lUOuRlFtjapdiKj+S+wMCnZBCCjeSDfeUqxhnYp1LweHxiJUj/4huESrfB/n3ZuEsvIi 20as/2rSukQlRALdwfFnbPLkA1oNeoBHRwiswP70hHPs0+n6PeDSakfzN+ODwjjzyYzq g/ycsFykAKfDNjDPtavs3K8cNF265cnmwsqsHUzXz1rrO6QBWFIo0XvECdiT5bWKssbM kY7w8dGeD9r/oL4AnUSaxE8CVp8/vrGWi+QZvgJP8nKEjB14/8Khs8SfwvrD2csgCx8N xakQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=BlaseU437UBM3rjpXtOeGFeNTkfKzXzwXFB0L3rPGBA=; b=e5UzxGkX0z8f7t1W3CqPZt40goq0MCoZ8ZRRf7plUM46oY+xzhr2ixt2r9oI7HGuil 5zGukkHTWm9o28xo144OyvK7yEeIef42XONwuKHV8YTHiyzLQCXqz63ap58BWB9FTg7i B3xhv7EeQOVI1MZu5DlYdqpWES/ClfEQKeZi6WjD1n68kk+rA6pg+41jACW82JhgbuGr yaJaYO+SzPh6wD5cCe7Gsrsqx3oOes3B4jopfUbPYcKCJC47CTsR7in3jZIFGzXaq4Ja lI4hk29Ad8U7GURFbAhw+dDLU5IEJsizFUzztYni1breLfhEWPSFZ48nY02SZGfbFacI tDUA== X-Gm-Message-State: AElRT7F+Kf7kbEUAIfd5PF1Zm7+gMESAvKBpNvVGawWNSksoeR5WOdKJ P1gIwxnlIY3KOlkZLXjpcyxVA97F/lyq3GYw3qe/uQ== X-Google-Smtp-Source: AG47ELuBL7qgHgceBrQthvg+omExN8sKR+BvnPWHi5z/LAK5pDMmzD9KXllwUPd60zTL9BgCkbf/xUtDSxNLxLdvsbo= X-Received: by 10.107.11.204 with SMTP id 73mr56554106iol.25.1522426497253; Fri, 30 Mar 2018 09:14:57 -0700 (PDT) MIME-Version: 1.0 Received: by 10.2.163.150 with HTTP; Fri, 30 Mar 2018 09:14:56 -0700 (PDT) In-Reply-To: References: <1520324217.8785.3.camel@gmail.com> <92B8C822-9A79-4F93-944C-F4530FD8D62C@gmail.com> <17418B5C-6919-4E37-B97D-9723C6D71ED9@gmail.com> <7EE0A2B8-DA5D-4770-B970-9B14A97BE709@gmail.com> <64A33502-2AC5-4ED5-9087-F831127A7F3D@gmail.com> <5F3CC726-A246-4390-8763-58B8A98D3992@gmail.com> From: Andrey Kuznetsov Date: Fri, 30 Mar 2018 19:14:56 +0300 Message-ID: Subject: Re: Code inspection To: dev@ignite.apache.org Content-Type: multipart/alternative; boundary="001a113de7a490c7110568a38a69" --001a113de7a490c7110568a38a69 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, Dmitry! To me, it's better to disable the following: Unnecessary 'this' qualifier -- this will, for example, warn on well-formed constructors. 'if' statement could be replaced with conditional expression -- let's decide on common sense basis whether it's appropriate, forceful refactorings could lead to non-readable code. 2018-03-30 18:57 GMT+03:00 Dmitry Pavlov : > Bumping up. Igniters, please reply and provide feedback on inspections > settings. > > I really prefer that we will merge inspections to codebase with clear > acknowledgment from active community members. > > =D1=87=D1=82, 29 =D0=BC=D0=B0=D1=80. 2018 =D0=B3. =D0=B2 12:03, Alexey Go= ncharuk >: > > > From what I see, it should be rather easy to get a meaningful number of > > inspection failures to get something we can start working with. > > > > Namely, we have: > > Overly strong type cast (206) - mechanical work, easy to fix > > Assignment replaceable with operator assignment (23) - either mechanica= l > > work, or disable inspection > > 'expression.equals("literal")' rather than '"literal".equals(expression= )' > > (49) - mechanical work > > 'size() =3D=3D 0' replaceable with 'isEmpty()' (67) - mechanical work > > Missorted modifiers (121) - mechanical work > > Redundant field initialization (76) - mechanical work or disable > inspection > > Unnecessary 'this' qualifier (543) - mechanical work or disable > inspection > > 'if' statement could be replaced with conditional expression (244) - > > mechanical work or disable inspection > > Redundant throws declaration (100) - mechanical work or disable > inspection > > Redundant suppression (848) - mechanical work > > Missing @Override annotation (289) - mechanical work > > Property key/value delimiter doesn't match code style settings (2183) - > > disable inspection > > Unused Property (2180) - disable inspection > > > > For some of the inspections we have to agree whether we enforce a > > particular code style (for example, unnecessary 'this' qualifier). > > After this is done, the number of failed inspections will drop > dramatically > > and we can start tracking changes and pay more attention to other > > inspection categories. > > > > --AG > > > > 2018-03-28 21:19 GMT+03:00 Peter Ivanov : > > > > > Anton, Dmitry is right. > > > > > > We have to manually add condition when to consider build faulty based > on > > > how many failed inspection are there. > > > > > > For now I see this initiative as follows: > > > - find more or less correct set of inspections (there are lots of typ= os > > and > > > other irrelevant to code execution inspections) looking on the result= s > of > > > core module build, as it has ~85% of target code; > > > - add all modules to composite project and setup schedule at least > once a > > > week. > > > > > > > > > On Wed, 28 Mar 2018 at 19:09, Dmitry Pavlov > > wrote: > > > > > > > Inspection suites should be failed manually by some fail condition. > > > > > > > > This question will become actual in future. How to fail such suite = on > > TC? > > > > > > > > =D1=81=D1=80, 28 =D0=BC=D0=B0=D1=80. 2018 =D0=B3. =D0=B2 18:54, Ant= on Vinogradov : > > > > > > > > > Peter, > > > > > > > > > > Why 44 errors are green? > > > > > > > > > > > > > > > > > > > https://ci.ignite.apache.org/viewLog.html?buildId=3D1145974& > > > tab=3DbuildResultsDiv&buildTypeId=3DIgniteTests24Java8_InspectionsAop > > > > > > > > > > 2018-03-28 16:27 GMT+03:00 Petr Ivanov : > > > > > > > > > > > After several problems, example run on Aleksey=E2=80=99s config= uration is > > > > > > complete: > > https://ci.ignite.apache.org/viewLog.html?buildId=3D1164652 > > > < > > > > > > https://ci.ignite.apache.org/viewLog.html?buildId=3D1164652> > > > > > > > > > > > > > > > > > > > On 28 Mar 2018, at 10:28, Petr Ivanov > > wrote: > > > > > > > > > > > > > > Started > > https://ci.ignite.apache.org/viewLog.html?buildId=3D1164002 > > > < > > > > > > https://ci.ignite.apache.org/viewQueued.html?itemId=3D1163998> > with > > > > > > Aleksey=E2=80=99s inspections profile. > > > > > > > Core (long) and AOP (short) modules will be tested as example= . > > > > > > > > > > > > > > > > > > > > > > > > > > > >> On 27 Mar 2018, at 19:38, Dmitry Pavlov < > dpavlov.spb@gmail.com > > > > > > > > > > dpavlov.spb@gmail.com>> wrote: > > > > > > >> > > > > > > >> Hi Petr, > > > > > > >> > > > > > > >> Could you please take inspections and run it on AI code base > in > > > > > > >> https://ci.ignite.apache.org/viewType.html?buildTypeId=3D > > > > > > > > > > > > IgniteTests24Java8_InspectionsCore&branch_IgniteTests24Java8=3D%3Cdefau= lt% > > > > > > 3E&tab=3DbuildTypeStatusDiv > > > > > > > viewType.html?buildTypeId=3DIgniteTests24Java8_InspectionsCore&branch_ > > > > > > IgniteTests24Java8=3D%3Cdefault%3E&tab=3DbuildTypeStatusDiv> > > > > > > >> ? > > > > > > >> > > > > > > >> Sincerely, > > > > > > >> Dmitriy Pavlov > > > > > > >> > > > > > > >> =D0=B2=D1=82, 27 =D0=BC=D0=B0=D1=80. 2018 =D0=B3. =D0=B2 19:= 27, Dmitry Pavlov < > > dpavlov.spb@gmail.com > > > >: > > > > > > >> > > > > > > >>> Alexey, thank you for bring this topic to top. > > > > > > >>> > > > > > > >>> What do you think about committing this inspections into > Ignite > > > > code > > > > > > base? > > > > > > >>> > > > > > > >>> What can be our next steps after demonstrating CI check is > > > possible > > > > > > >>> https://ci.ignite.apache.org/viewType.html?buildTypeId=3D > > > > > > > > > > > > IgniteTests24Java8_InspectionsCore&branch_IgniteTests24Java8=3D%3Cdefau= lt% > > > > > > 3E&tab=3DbuildTypeStatusDiv > > > > > > >>> ? > > > > > > >>> > > > > > > >>> Sincerely, > > > > > > >>> Dmitriy Pavlov > > > > > > >>> > > > > > > >>> =D0=B2=D1=82, 27 =D0=BC=D0=B0=D1=80. 2018 =D0=B3. =D0=B2 15= :28, Alexey Goncharuk < > > > > > > alexey.goncharuk@gmail.com > > > > > > >>>> : > > > > > > >>> > > > > > > >>>> Bumping up. > > > > > > >>>> > > > > > > >>>> Attached is my local inspections profile exported from Ide= a. > > > Let's > > > > > run > > > > > > >>>> the first iteration and check if it differs significantly > from > > > > other > > > > > > >>>> community members. > > > > > > >>>> > > > > > > >>>> --AG > > > > > > >>>> > > > > > > >>>> 2018-03-19 16:39 GMT+03:00 Petr Ivanov >: > > > > > > >>>> > > > > > > >>>>> Filed https://issues.apache.org/jira/browse/IGNITE-7985 < > > > > > > >>>>> https://issues.apache.org/jira/browse/IGNITE-7985> [1]. > > > > > > >>>> > > > > > > >>>> > > > > > > >>>>> > > > > > > >>>>> > > > > > > >>>>> > > > > > > >>>>>> On 18 Mar 2018, at 00:56, Dmitry Pavlov < > > > dpavlov.spb@gmail.com> > > > > > > wrote: > > > > > > >>>>>> > > > > > > >>>>>> Hello Petr, > > > > > > >>>>>> > > > > > > >>>>>> Many members of the community would appreciate such > > additional > > > > > code > > > > > > >>>>> control, and it's a pity that no one made this happen. > Agree? > > > > > > >>>>>> > > > > > > >>>>>> Could you please pick up this activity? > > > > > > >>>>>> > > > > > > >>>>>> It might be an idea to create 'IDEA Inspections' step to > be > > > run > > > > in > > > > > > >>>>> parallel with 'Build Apache Ignite'. WDYT? Would it work? > > > > > > >>>>>> > > > > > > >>>>>> Sincerely, > > > > > > >>>>>> Dmitriy Pavlov > > > > > > >>>>>> > > > > > > >>>>> > > > > > > >>>>> https://confluence.jetbrains.com/display/TCD10/Inspection= s > < > > > > > > >>>>> https://confluence.jetbrains.com/display/TCD10/Inspection= s > > > > > > > > >>>>>> > > > > > > >>>>>> > > > > > > >>>>>> =D0=BF=D0=BD, 12 =D0=BC=D0=B0=D1=80. 2018 =D0=B3. =D0=B2= 14:37, Dmitry Pavlov < > > > > dpavlov.spb@gmail.com > > > > > > >>>>> >: > > > > > > >>>> > > > > > > >>>> > > > > > > >>>>>> Hi Dmitriy, > > > > > > >>>>>> > > > > > > >>>>>> would you pick up this activity? > > > > > > >>>>>> > > > > > > >>>>>> Sincerely, > > > > > > >>>>>> Dmitriy Pavlov > > > > > > >>>>>> > > > > > > >>>>> > > > > > > >>>>> =D0=B2=D1=82, 6 =D0=BC=D0=B0=D1=80. 2018 =D0=B3. =D0=B2 1= 4:09, Dmitry Pavlov < > > > dpavlov.spb@gmail.com > > > > > > >>>>> >: > > > > > > >>>> > > > > > > >>>> > > > > > > >>>>>> What I can suggest now it is to take XML file with > existing > > as > > > > is > > > > > > from > > > > > > >>>>> previous topic (I remember someone in community already > > > prepared > > > > > > settings) > > > > > > >>>>> and set up TeamCity Run configuration as part of Run All > > Basic > > > > > Tests > > > > > > (per > > > > > > >>>>> commit basis). > > > > > > >>>>>> > > > > > > >>>>>> If we don=E2=80=99t have XML, I suggest to enable build-= in Idea > > > > > inspections > > > > > > >>>>> 'as is' on TeamCity and iteratively improve it according = to > > > found > > > > > > issues. > > > > > > >>>>>> > > > > > > >>>>>> Dmitriy G., would you prepare PR and proof-of-concept TC > run > > > > > > >>>>> configuration? > > > > > > >>>>>> > > > > > > >>>>>> As discussion became really active, I think that means > > > community > > > > > is > > > > > > >>>>> interested in static code checks. > > > > > > >>>>>> > > > > > > >>>>> > > > > > > >>>>> =D0=B2=D1=82, 6 =D0=BC=D0=B0=D1=80. 2018 =D0=B3. =D0=B2 1= 4:08, Dmitry Pavlov < > > > dpavlov.spb@gmail.com > > > > > > >>>>> >: > > > > > > >>>> > > > > > > >>>> > > > > > > >>>>>> I was thinking about some quick check, which will > > > automatically > > > > > > >>>>> require minimum runs. Now, any committer can push changes > to > > > the > > > > > > master, > > > > > > >>>>> which break not only the inspection and style, but even t= he > > > > > > compilation. If > > > > > > >>>>> this control would be automatic, it can allow us make > > codebase > > > > > > better quite > > > > > > >>>>> fast. But I am afraid it is not realistic. > > > > > > >>>>>> > > > > > > >>>>>> > > > > > > >>>>>> > > > > > > >>>>> > > > > > > >>>>> =D0=B2=D1=82, 6 =D0=BC=D0=B0=D1=80. 2018 =D0=B3. =D0=B2 1= 3:42, Petr Ivanov < > mr.weider@gmail.com > > > > > > > > > > > >>>>> mr.weider@gmail.com>>: > > > > > > >>>> > > > > > > >>>> > > > > > > >>>>>> Sonar is powerful, yes, but it=E2=80=99s power in thorou= ghness. > I.e. > > > it > > > > > does > > > > > > >>>>> its job well in cases of leisurely post-build analysis. > > > > > > >>>>>> > > > > > > >>>>>> I=E2=80=99d suggest we use it (if we will use it) in the= following > > > > > > scenarios: > > > > > > >>>>>> =E2=80=94 some basic checks Sonar profile for Blocker bu= gs (it is > > > fast) > > > > =E2=80=94 > > > > > > >>>>> something that cannot be passed to master; > > > > > > >>>>>> =E2=80=94 nightly or even weekly run with Full Sonar pro= file (600+ > > > > checks > > > > > > >>>>> from Firebug, Codestyle, Coverage, etc.) for regression a= nd > > > > overall > > > > > > code > > > > > > >>>>> quality improvement goals. > > > > > > >>>>>> > > > > > > >>>>>> Did not quite get you about push-to-master prohibition. > Can > > > you > > > > > > >>>>> explain scenario in more details? > > > > > > >>>>>> > > > > > > >>>>>> > > > > > > >>>>>>> On 6 Mar 2018, at 13:27, Dmitry Pavlov < > > > dpavlov.spb@gmail.com > > > > > > >>>>> > wrote: > > > > > > >>>>>>> > > > > > > >>>>>>> Petr, I've heard Sonar is powerful tool. > > > > > > >>>>>>> > > > > > > >>>>>>> Would it help us to prohibit commits to master w/o test > > run / > > > > too > > > > > > >>>>> much > > > > > > >>>>>>> failed tests / too much inspection errors appeared? > > > > > > >>>>>>> > > > > > > >>>>> > > > > > > >>>>>> =D0=B2=D1=82, 6 =D0=BC=D0=B0=D1=80. 2018 =D0=B3. =D0=B2 = 13:22, Alexey Goncharuk < > > > > > > >>>>> alexey.goncharuk@gmail.com > alexey.goncharuk@gmail.com > > > >>: > > > > > > >>>> > > > > > > >>>> > > > > > > >>>>>>> > > > > > > >>>>>>>> Dmitriy, > > > > > > >>>>>>>> > > > > > > >>>>>>>> I like this idea a lot. For example, the inspection > > profile > > > > > should > > > > > > >>>>> have > > > > > > >>>>>>>> inspection 'Anonymous class can be converted to lambda= ' > > > > disabled > > > > > > >>>>> because > > > > > > >>>>>>>> quite a lot of such classes can be sent over the netwo= rk > > > > > (although > > > > > > >>>>> even > > > > > > >>>>>>>> anonymous classes are discourage for such purposes). > > > > > > >>>>>>>> > > > > > > >>>>>>>> I believe we can start with sharing somehow one of the > > > > profiles > > > > > > and > > > > > > >>>>> then > > > > > > >>>>>>>> iteratively improving it until the community is > satisfied > > > with > > > > > the > > > > > > >>>>> result. > > > > > > >>>>>>>> > > > > > > >>>>>>>> Thoughts? > > > > > > >>>>>>>> > > > > > > >>>>> > > > > > > >>>>>>> 2018-03-06 12:06 GMT+03:00 Petr Ivanov < > > mr.weider@gmail.com > > > > > > > > > > > >>>>> mr.weider@gmail.com>>: > > > > > > >>>> > > > > > > >>>> > > > > > > >>>>>>>> > > > > > > >>>>>>>>> We can use Sonar as instrument for code analysis and > test > > > > > > coverage > > > > > > >>>>>>>>> inspections. > > > > > > >>>>>>>>> > > > > > > >>>>>>>>> > > > > > > >>>>>>>>> > > > > > > >>>>>>>>>> On 6 Mar 2018, at 11:28, Dmitriy Govorukhin < > > > > > > >>>>>>>>> dmitriy.govorukhin@gmail.com dmitriy.govorukhin@ > > > > > > gmail.com>> > > > > > > >>>>> wrote: > > > > > > >>>>>>>>>> > > > > > > >>>>>>>>>> Dmitriy, > > > > > > >>>>>>>>>> > > > > > > >>>>>>>>>> As I understood, preview topic was of static code > > analysis > > > > in > > > > > > >>>>> general. > > > > > > >>>>>>>>>> In this topic, I want to discuss only idea inspectio= n > > > rule. > > > > > > >>>>>>>>>> In future, of course, we can exp=D0=B0nd this rule t= o the > > > > TeamCity > > > > > > >>>>> build. > > > > > > >>>>>>>>>> > > > > > > >>>>> > > > > > > >>>>>>>>> On Tue, Mar 6, 2018 at 11:16 AM, Nikolay Izhikov < > > > > > > >>>>> nizhikov@apache.org > > > > > > > >>>> > > > > > > >>>> > > > > > > >>>>>>>>>> wrote: > > > > > > >>>>>>>>>> > > > > > > >>>>>>>>>>> Hello, Igniters. > > > > > > >>>>>>>>>>> > > > > > > >>>>>>>>>>> +1 to automatic code style tools. > > > > > > >>>>>>>>>>> > > > > > > >>>>>>>>>>> Let's make it already! > > > > > > >>>>>>>>>>> Do we have a ticket for it? > > > > > > >>>>>>>>>>> > > > > > > >>>>>>>>>>> Related discussion - > > > > > > >>>>> > > > > > > >>>>>>> http://apache-ignite-developers.2346864.n4.nabble < > > > > > > >>>>> http://apache-ignite-developers.2346864.n4.nabble/>. > > > > > > >>>> > > > > > > >>>> > > > > > > >>>>>>>>>>> com/Static-code-analysis-for-Java-td22195.html > > > > > > >>>>>>>>>>> > > > > > > >>>>>>>>>>> =D0=92 =D0=92=D1=82, 06/03/2018 =D0=B2 08:15 +0000,= Dmitry Pavlov =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > > > > > > >>>>>>>>>>>> Hi Dmitriy, > > > > > > >>>>>>>>>>>> > > > > > > >>>>>>>>>>>> I think we should resurrect thread about addition = of > > > code > > > > > > >>>>>>>> inspections, > > > > > > >>>>>>>>>>> and > > > > > > >>>>>>>>>>>> later we can enable automatic control step to > > TeamCity. > > > > > > >>>>>>>>>>>> > > > > > > >>>>>>>>>>>> Could you help me to find it? > > > > > > >>>>>>>>>>>> > > > > > > >>>>>>>>>>>> =D0=B2=D1=82, 6 =D0=BC=D0=B0=D1=80. 2018 =D0=B3. = =D0=B2 11:11, Dmitriy Govorukhin < > > > > > > >>>>> > > > > > > >>>>>>>>>> dmitriy.govorukhin@gmail.com > dmitriy.govorukhin@ > > > > > > gmail.com > > > > > > >>>>>> > > > > > > >>>> > > > > > > >>>> > > > > > > >>>>>>>>>>>>> : > > > > > > >>>>>>>>>>>>> Hi folks, > > > > > > >>>>>>>>>>>>> > > > > > > >>>>>>>>>>>>> Do we have 'inspection' [1] scheme for ignite? > > > > > > >>>>>>>>>>>>> I see a lot of warnings in my code, and I guess i= t > is > > > > > because > > > > > > >>>>>>>> everyone > > > > > > >>>>>>>>>>> uses > > > > > > >>>>>>>>>>>>> different schemes. > > > > > > >>>>>>>>>>>>> > > > > > > >>>>>>>>>>>>> Let's start the discussion. > > > > > > >>>>>>>>>>>>> > > > > > > >>>>>>>>>>>>> [1] IDEA inspection > > > > > > >>>>> > > > > > > >>>>>>>>>>>> > > help/idea/code-inspection.html > > > > < > > > > > > >>>>> https://www.jetbrains.com/help/idea/code-inspection.html>= > > > > > > > >>>>>>>>>>>>> > > > > > > >>>>>>>>>>> > > > > > > >>>>>>>>> > > > > > > >>>>>>>>> > > > > > > >>>>>>>> > > > > > > >>>>>> > > > > > > >>>>> > > > > > > >>>>> > > > > > > >>>> > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > --=20 Best regards, Andrey Kuznetsov. --001a113de7a490c7110568a38a69--