From dev-return-31262-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Tue Feb 20 22:28:20 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 4ECDE180654 for ; Tue, 20 Feb 2018 22:28:20 +0100 (CET) Received: (qmail 41620 invoked by uid 500); 20 Feb 2018 21:28:19 -0000 Mailing-List: contact dev-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list dev@ignite.apache.org Received: (qmail 41604 invoked by uid 99); 20 Feb 2018 21:28:18 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 20 Feb 2018 21:28:18 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 27280C01EE for ; Tue, 20 Feb 2018 21:28:18 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.898 X-Spam-Level: * X-Spam-Status: No, score=1.898 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id qlW8gtXOpvTL for ; Tue, 20 Feb 2018 21:28:17 +0000 (UTC) Received: from mail-io0-f179.google.com (mail-io0-f179.google.com [209.85.223.179]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 0E2845F1B3 for ; Tue, 20 Feb 2018 21:28:17 +0000 (UTC) Received: by mail-io0-f179.google.com with SMTP id z6so16511125iob.11 for ; Tue, 20 Feb 2018 13:28:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=PwgBVf7EzbiFC8l4z9cfufUJcTSWSgslxcGZZ8FZuPI=; b=BRAk/C2gcsfz0tO+Lp7+q3n4aSz/m52ijJEk+5VgHRfa2KtNXp+FYfmA5N/C3cn6dV n5QpyVd8Ehnm/ULsdcXvUWK1FKyTf+lmEIqjx6AVIhNkLrkw+K9REQLrk4RnmqO1yrhB oi6K47ma8lXPbSxS/9OPxRvng1OTVl29SDjuLYfFNqvpEtv+fJJn37z5CdaQ/OC9v1a5 UMr3c+zF11+KcPK8l8y7QwDUD8+AZg1BKXHbhVPvuR8fNQZBB/22PcyS/OaDt/7ZcTxx wIDe3iayi86fU0mbtJhgLHABazfE7lq56vm8xg4b7mlD2GK8JQJYLRTm5Z0gke8wVeFo B1kQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=PwgBVf7EzbiFC8l4z9cfufUJcTSWSgslxcGZZ8FZuPI=; b=rjwM153/BGy9dia4ZhakZeys7JwKJZONuZ3JxlZIDr2T8NOeikgdFsW2kIG5ALd5yh VcCVXeabQdkQTOltllZCWNOVLdTf/qX39hoY52ZA+8jCikBXNnzusKkY08s67GMMuVo8 MLLh9OZgYOjdM9utz2YqrFFp/e6sz5IzEZXDcXwVyztVJXAozz+EdpMuYV43vgJssTLH DOM3R2IUEYpMmU2zSrB5xGL05Z3BpXDi2PKw4EaB/Dd3d2/8moLzMbePK7Utsm1UC5iC tWVhGlj4jiTaoli2OZUIK8Q4RwjmI/JcBzzceKsj5yGbtnnlt3Rd2c/EKmhkwR+6zDBJ RcyA== X-Gm-Message-State: APf1xPCTekSlocJ7fV01VZzEF1qo8eBiddHabNbkyOmy0IY9iRyEjibt hBXJDmYkTDjwJniZ0jbhW6BFbDkXVy4PoFi1O4s= X-Google-Smtp-Source: AH8x226UZCqxG/ckm1vM5z+mOG1sVuv+RGNY10rttvrG/PeFS24f21VIakw4hqmG9qgBjE4hxZPD/VcersY1dmjnBUI= X-Received: by 10.107.14.73 with SMTP id 70mr1398227ioo.258.1519162096343; Tue, 20 Feb 2018 13:28:16 -0800 (PST) MIME-Version: 1.0 References: <1518425105.11738.18.camel@gmail.com> In-Reply-To: From: Dmitry Pavlov Date: Tue, 20 Feb 2018 21:28:05 +0000 Message-ID: Subject: Re: IGNITE-6005 is ready for review To: dev@ignite.apache.org, Alexey Goncharuk , Nikolay Izhikov Content-Type: multipart/alternative; boundary="001a113ff69c1bf7980565ab7d94" --001a113ff69c1bf7980565ab7d94 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Igniters, It seems this issue review process hang up. Andrey Gura had concerns about this implementation. In the same time Ilya L checked this implementation and approves it. I didn't find points to improve and concerns are not clear for me. I didn't managed to get more info in issue https://issues.apache.org/jira/browse/IGNITE-6005 comments. What can be our next step to solve this? Absence of this fix causes 100% timeout in Data Structures suite and wastes agents for a long time. Sincerely, Dmitriy Pavlov =D0=BF=D0=BD, 12 =D1=84=D0=B5=D0=B2=D1=80. 2018 =D0=B3. =D0=B2 17:54, Ilya = Lantukh : > Hi Nikolay, > > Thanks for contribution! > > I will try to review your pull request by tomorrow. > > On Mon, Feb 12, 2018 at 11:45 AM, Nikolay Izhikov > wrote: > > > Hello, Igniters. > > > > I've fix some relatively small issue(100 loc) IGNITE-6005 [1], PR [2] > > The fix in DataStructuresProcessor.java > > > > As far as I can see from git log Ilya Lantukh maintains this piece of > code. > > > > Ilya, can you please take a look at the fix? > > > > [1] https://issues.apache.org/jira/browse/IGNITE-6005 > > > > [2] https://github.com/apache/ignite/pull/2773 > > > > > -- > Best regards, > Ilya > --001a113ff69c1bf7980565ab7d94--