From dev-return-30603-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Thu Feb 1 22:29:05 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 7FE87180652 for ; Thu, 1 Feb 2018 22:29:05 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 6F5DF160C58; Thu, 1 Feb 2018 21:29:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id C715F160C35 for ; Thu, 1 Feb 2018 22:29:04 +0100 (CET) Received: (qmail 98650 invoked by uid 500); 1 Feb 2018 21:29:03 -0000 Mailing-List: contact dev-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list dev@ignite.apache.org Received: (qmail 98586 invoked by uid 99); 1 Feb 2018 21:29:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Feb 2018 21:29:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id ABC59C05F8 for ; Thu, 1 Feb 2018 21:29:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.179 X-Spam-Level: * X-Spam-Status: No, score=1.179 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id uhrMQuo28t-C for ; Thu, 1 Feb 2018 21:29:01 +0000 (UTC) Received: from mail-it0-f53.google.com (mail-it0-f53.google.com [209.85.214.53]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 8A3675F1EE for ; Thu, 1 Feb 2018 21:29:00 +0000 (UTC) Received: by mail-it0-f53.google.com with SMTP id 68so5517364ite.4 for ; Thu, 01 Feb 2018 13:29:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=JX52TWiJiQgFwah5lNpJHx4inYlSDFutcF4m9lNERb4=; b=aKCRV2MxUvKiNOdHQszBhKDHTFNR7xyT41nz0RhlIVshFRHCWEQnX3ewsVDNd7rrDG MJPyenhDVHk4j19cDVmwPFKrCuE2IFvYMZwhu09uVd4y02K9TDu0wr49El6XOn7zidh6 hLcWVrOy3SiprAOzbV2MHARrjRb1QUlTjBifUoj4R13DJnpBiUpaZwqDtS6yyLkfIk9s Ij0uZtuP9BmOEfSiLO1MrjwqgXw8migHX29T+Zz2qgcms1abpN0XUppzQnQLiOkWCOLM xT7hwzqnUuaIvJFd0X9Vqkf8mOUmhMwUFAhZkWSxDhtU+gylBEH7GNzlCd//1TbTWXx7 Iu/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=JX52TWiJiQgFwah5lNpJHx4inYlSDFutcF4m9lNERb4=; b=bmvnwzDqA+B05/sFYzmU8rnot7kZqB1zLtIvK1zrbZuNq2bs9vhrwk5WgttOynasgH yRhz8FlqISkgaHYAGP55lYX8PcmCv+IaqLorpyZe7cKwL+AopBYXUPR4IqY5/RioQqCX j9A13+8QhFiDqbBC1HG3dULuVm6KNL5MZ+SmRCbEHQBFBpMWN2UxF6J8L7hFDTl/7D7J CM9TFXxLKj+mDaTOLqnriggCfiIVi8Zf5cksgf+Cvu+ic3+9Q23iJu+otLdU/hvaxX4T plVYIwUOpEQkbrkK7UcDGmbRZfFWcVoII+iBQ3sST/S5YWdC8TVbRPZWITywxPM/LhdV sVuw== X-Gm-Message-State: AKwxytf6VAipFzJwiuI9ajGDK6TD0cB3ScJsInDFamw3V2d989tkDVIk O2DUE8ElfXIJfTVq0tlE9OLwXGM4IrnDf62DlNM= X-Google-Smtp-Source: AH8x2250F/plLRkkC8Yq45jXsYWtvnMoRlNaZkFj9EoBP2fKyrfFOObVYbrTH2BtU8BxYBcc6nwVDzAlXfsab91ySNg= X-Received: by 10.36.37.2 with SMTP id g2mr40598027itg.129.1517520539098; Thu, 01 Feb 2018 13:28:59 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Dmitry Pavlov Date: Thu, 01 Feb 2018 21:28:48 +0000 Message-ID: Subject: Re: Orphaned, duplicate, and main-class tests! To: dev@ignite.apache.org Content-Type: multipart/alternative; boundary="001a1143d1fcac22aa05642d4856" --001a1143d1fcac22aa05642d4856 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Ilya, Thank you for this research. I think it is useful for community to identify and remove obsolete tests (if any), and include lost test into CI run chain (if applicable). For test with main() methods I suggest to ask authors (git annotate) and if there is no response probably we should remove such code. Since I am not sure all tests in this lost&found suite are quite stable I suggest to create standalone TC Run configuration for such tests. Earlier I've removed most of tests causing timeouts from basic suite. Ideally Basic suite should contain fast run quite stable tests ( and 0 flaky ) because it is included into RunAllBasic sub set to brief commit check ( https://ci.ignite.apache.org/viewType.html?buildTypeId=3DIgniteTests24Java8= _RunBasicTests ). Sincerely, Dmitriy Pavlov =D1=87=D1=82, 1 =D1=84=D0=B5=D0=B2=D1=80. 2018 =D0=B3. =D0=B2 20:22, Ilya K= asnacheev : > Hello! > > While working on Ignite, I have noticed that not all tests are in any tes= t > suite, hence I expect they are ignored. I have also noticed some files in > src/test and named *Test.java are actually runnable main-classes and not > tests. I think they're ignored to. Also I've noticed that 6 tests repeat > twice. > > I have tried to fix it by introducing "lost and found" test suite. Not su= re > what to do with main-classes. I have also renamed abstract test classes t= o > *AbstractTest. > > Please consider pull request https://github.com/apache/ignite/pull/3464 > > I have started this suite on TC but I expect it to hang or worse. > > https://ci.ignite.apache.org/viewLog.html?buildId=3D1071504&tab=3DqueuedB= uildOverviewTab > > Regards, > -- > Ilya Kasnacheev > --001a1143d1fcac22aa05642d4856--