From dev-return-31271-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Wed Feb 21 11:15:10 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 5B8E018061A for ; Wed, 21 Feb 2018 11:15:10 +0100 (CET) Received: (qmail 77841 invoked by uid 500); 21 Feb 2018 10:15:09 -0000 Mailing-List: contact dev-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list dev@ignite.apache.org Received: (qmail 77825 invoked by uid 99); 21 Feb 2018 10:15:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 21 Feb 2018 10:15:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 2AF23180347 for ; Wed, 21 Feb 2018 10:15:08 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.898 X-Spam-Level: * X-Spam-Status: No, score=1.898 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id OQDFzyrA9Zps for ; Wed, 21 Feb 2018 10:15:06 +0000 (UTC) Received: from mail-io0-f173.google.com (mail-io0-f173.google.com [209.85.223.173]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 6A5F45F17F for ; Wed, 21 Feb 2018 10:15:06 +0000 (UTC) Received: by mail-io0-f173.google.com with SMTP id l12so1570795ioc.10 for ; Wed, 21 Feb 2018 02:15:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Y8quQPTvEwxkV9x0ICf7wticqaQKa/xp3ddTeF/xsls=; b=j7Le8sgjpJ5Dzf3m5FmoOWk+Wz2nRg+GoOyG4SU0tEqMVYuaC338z/gwL6yHz/551D bhUdGXm69cwYwpFxephm13XzWd6J4kg48b10n2JGl51HeH2fhbbMHzrPxYYe+b26srGo G0lt2uj87qTxFMWKO+Sc3eVwU4Yi8F/APzbCh9yOAuX7Aj4iRtD+TSJsRuauKssnFzFK shTKxeDvzXpMwdoJ3M1Srg7gy/75stSeQf32YJoi0noMqEIOTs9xan0DlME9HDIhUcPl EqXQSUi+4ASFHEmJv3d3bN8G5XAyskkWTIeugAJIDXlrWV7aHqqMM5FBOBFHxLwqQ/hS Q3OQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Y8quQPTvEwxkV9x0ICf7wticqaQKa/xp3ddTeF/xsls=; b=qQZQ9mLQt0ZxNpjSy6ihG/drzA5B644NzufGR/jk/Rv7tpqVvDVHbinS0oCOpT22kY gqvFTH3EIA5AuCI/9wX/7dgZQYarboaEawPzXUzi4dbvC14LSIEOgqM2ofXqf3HNVVdO +l3VPNoZKCiAZxxNr/rwSngSBaHEpbFEAbDlbCv8Mk80NL9lWCPB5fkWzQz/+G47Kgqz YmuxKlEvZU97yrOOr8FSJZVDCYQQhtyAKTqIZ5pdzuenfEXs80qpP3v47p0upSD7BLd1 3mkGTTGnUtnPfH6kcR2pFTjmhi2iz5YRpnEiv0ZGpkzAtuY+yS+WPvZTellMQsZZhIEg CQXg== X-Gm-Message-State: APf1xPDoEaqKhT5hNU/5BqWMcgEuDqUS/iFrCXeh2T+O+2l7x/XZ0cQF 4SRdVk2mt5q44jZ/L/y2V5JgiV9fgW5xGCY+9j4= X-Google-Smtp-Source: AH8x2244PMqNBO8sVbnFjuhp2UjIEcFox6zn4NIqPkFzy6ZhEoZLL5euwaMw7/FJD3vKWmhsm+Tzu1uh9NXN1Q0zFFA= X-Received: by 10.107.174.27 with SMTP id x27mr3298276ioe.27.1519208105635; Wed, 21 Feb 2018 02:15:05 -0800 (PST) MIME-Version: 1.0 References: <1518425105.11738.18.camel@gmail.com> <1519202910.5792.17.camel@gmail.com> In-Reply-To: <1519202910.5792.17.camel@gmail.com> From: Dmitry Pavlov Date: Wed, 21 Feb 2018 10:14:55 +0000 Message-ID: Subject: Re: IGNITE-6005 is ready for review To: dev@ignite.apache.org Cc: Andrey Gura , Alexey Goncharuk , Nikolay Izhikov Content-Type: multipart/alternative; boundary="001a11449ffc79f3bf0565b633cf" --001a11449ffc79f3bf0565b633cf Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, I didn't find any runs in our new TC suite group (project) for 2.4+: https://ci.ignite.apache.org/viewType.html?buildTypeId=3DIgniteTests24Java8= _RunAll&tab=3DbuildTypeStatusDiv&branch_IgniteTests24Java8=3Dpull%2F2773%2F= head So, Nikolay, I suggest to start RunAll in this suite group. I can check results later in compare with master. =D1=81=D1=80, 21 =D1=84=D0=B5=D0=B2=D1=80. 2018 =D0=B3. =D0=B2 11:48, Nikol= ay Izhikov : > Hello, Andrey. > > Do you run TC by yourself, or I as patch contributor should do it? > > =D0=92 =D0=A1=D1=80, 21/02/2018 =D0=B2 11:42 +0300, Andrey Gura =D0=BF=D0= =B8=D1=88=D0=B5=D1=82: > > I'll merge it if there are no any objections. But, the first, I'll run > TC once again. > > > > 21 =D1=84=D0=B5=D0=B2=D1=80. 2018 =D0=B3. 12:28 AM =D0=BF=D0=BE=D0=BB= =D1=8C=D0=B7=D0=BE=D0=B2=D0=B0=D1=82=D0=B5=D0=BB=D1=8C "Dmitry Pavlov" < > dpavlov.spb@gmail.com> =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB: > > > Hi Igniters, > > > > > > It seems this issue review process hang up. > > > > > > Andrey Gura had concerns about this implementation. In the same time > Ilya L > > > checked this implementation and approves it. > > > > > > I didn't find points to improve and concerns are not clear for me. I > didn't > > > managed to get more info in issue > > > https://issues.apache.org/jira/browse/IGNITE-6005 comments. > > > > > > What can be our next step to solve this? > > > > > > Absence of this fix causes 100% timeout in Data Structures suite and > wastes > > > agents for a long time. > > > > > > Sincerely, > > > Dmitriy Pavlov > > > > > > =D0=BF=D0=BD, 12 =D1=84=D0=B5=D0=B2=D1=80. 2018 =D0=B3. =D0=B2 17:54,= Ilya Lantukh : > > > > > > > Hi Nikolay, > > > > > > > > Thanks for contribution! > > > > > > > > I will try to review your pull request by tomorrow. > > > > > > > > On Mon, Feb 12, 2018 at 11:45 AM, Nikolay Izhikov < > nizhikov@apache.org> > > > > wrote: > > > > > > > > > Hello, Igniters. > > > > > > > > > > I've fix some relatively small issue(100 loc) IGNITE-6005 [1], PR > [2] > > > > > The fix in DataStructuresProcessor.java > > > > > > > > > > As far as I can see from git log Ilya Lantukh maintains this piec= e > of > > > > code. > > > > > > > > > > Ilya, can you please take a look at the fix? > > > > > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-6005 > > > > > > > > > > [2] https://github.com/apache/ignite/pull/2773 > > > > > > > > > > > > > > > > > > > > -- > > > > Best regards, > > > > Ilya > > > > --001a11449ffc79f3bf0565b633cf--