ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dmitry Pavlov <dpavlov....@gmail.com>
Subject Re: Orphaned, duplicate, and main-class tests!
Date Thu, 01 Feb 2018 21:28:48 GMT
Hi Ilya,

Thank you for this research. I think it is useful for community to identify
and remove obsolete tests (if any), and include lost test into CI run chain
(if applicable).

For test with main() methods I suggest to ask authors (git annotate) and if
there is no response probably we should remove such code.

Since I am not sure all tests in this lost&found suite are quite stable I
suggest to create standalone TC Run configuration for such tests.

Earlier I've removed most of tests causing timeouts from basic suite.
Ideally Basic suite should contain fast run quite stable tests ( and 0
flaky ) because it is included into RunAllBasic sub set to brief commit
check  (
https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_RunBasicTests
 ).

Sincerely,
Dmitriy Pavlov

чт, 1 февр. 2018 г. в 20:22, Ilya Kasnacheev <ilya.kasnacheev@gmail.com>:

> Hello!
>
> While working on Ignite, I have noticed that not all tests are in any test
> suite, hence I expect they are ignored. I have also noticed some files in
> src/test and named *Test.java are actually runnable main-classes and not
> tests. I think they're ignored to. Also I've noticed that 6 tests repeat
> twice.
>
> I have tried to fix it by introducing "lost and found" test suite. Not sure
> what to do with main-classes. I have also renamed abstract test classes to
> *AbstractTest.
>
> Please consider pull request https://github.com/apache/ignite/pull/3464
>
> I have started this suite on TC but I expect it to hang or worse.
>
> https://ci.ignite.apache.org/viewLog.html?buildId=1071504&tab=queuedBuildOverviewTab
>
> Regards,
> --
> Ilya Kasnacheev
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message