ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dmitry Pavlov <dpavlov....@gmail.com>
Subject Re: IGNITE-6005 is ready for review
Date Wed, 21 Feb 2018 10:14:55 GMT
Hi, I didn't find any runs in our new TC suite group (project) for 2.4+:
https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_RunAll&tab=buildTypeStatusDiv&branch_IgniteTests24Java8=pull%2F2773%2Fhead

So, Nikolay, I suggest to start RunAll in this suite group.

I can check results later in compare with master.

ср, 21 февр. 2018 г. в 11:48, Nikolay Izhikov <nizhikov@apache.org>:

> Hello, Andrey.
>
> Do you run TC by yourself, or I as patch contributor should do it?
>
> В Ср, 21/02/2018 в 11:42 +0300, Andrey Gura пишет:
> > I'll merge it if there are no any objections. But, the first, I'll run
> TC once again.
> >
> > 21 февр. 2018 г. 12:28 AM пользователь "Dmitry Pavlov" <
> dpavlov.spb@gmail.com> написал:
> > > Hi Igniters,
> > >
> > > It seems this issue review process hang up.
> > >
> > > Andrey Gura had concerns about this implementation. In the same time
> Ilya L
> > > checked this implementation and approves it.
> > >
> > > I didn't find points to improve and concerns are not clear for me. I
> didn't
> > > managed to get more info in issue
> > > https://issues.apache.org/jira/browse/IGNITE-6005 comments.
> > >
> > > What can be our next step to solve this?
> > >
> > > Absence of this fix causes 100% timeout in Data Structures suite and
> wastes
> > > agents for a long time.
> > >
> > > Sincerely,
> > > Dmitriy Pavlov
> > >
> > > пн, 12 февр. 2018 г. в 17:54, Ilya Lantukh <ilantukh@gridgain.com>:
> > >
> > > > Hi Nikolay,
> > > >
> > > > Thanks for contribution!
> > > >
> > > > I will try to review your pull request by tomorrow.
> > > >
> > > > On Mon, Feb 12, 2018 at 11:45 AM, Nikolay Izhikov <
> nizhikov@apache.org>
> > > > wrote:
> > > >
> > > > > Hello, Igniters.
> > > > >
> > > > > I've fix some relatively small issue(100 loc) IGNITE-6005 [1], PR
> [2]
> > > > > The fix in DataStructuresProcessor.java
> > > > >
> > > > > As far as I can see from git log Ilya Lantukh maintains this piece
> of
> > > > code.
> > > > >
> > > > > Ilya, can you please take a look at the fix?
> > > > >
> > > > > [1] https://issues.apache.org/jira/browse/IGNITE-6005
> > > > >
> > > > > [2] https://github.com/apache/ignite/pull/2773
> > > >
> > > >
> > > >
> > > >
> > > > --
> > > > Best regards,
> > > > Ilya
> > > >

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message