ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vyacheslav Daradur <daradu...@gmail.com>
Subject Re: Should we annotate @CacheLocalStore as @Depricated?
Date Tue, 13 Feb 2018 18:59:42 GMT
Valentin, thank you for replying.

The task [1][2] is ready for review. Please have a look.


[1] https://issues.apache.org/jira/browse/IGNITE-5097
[2] https://github.com/apache/ignite/pull/3517/files

On Tue, Feb 13, 2018 at 9:23 PM, Valentin Kulichenko
<valentin.kulichenko@gmail.com> wrote:
> Vyacheslav,
>
> These are test classes, there is not reason to put deprecation on them. We
> need to deprecate anything that is part of public API (in this case I
> believe it's only this annotation, nothing else).
>
> -Val
>
> On Tue, Feb 13, 2018 at 7:09 AM, Vyacheslav Daradur <daradurvs@gmail.com>
> wrote:
>
>> Guys, I need your advice about deprecation rules.
>>
>> Usually, deprecation of annotation doesn't affect on classes which are
>> marked by this annotation.
>>
>> But @CacheLocalStore affect on classes interpretation by Ignite very match.
>> For example:
>> GridCacheStoreManagerDeserializationTest
>> CacheDeploymentTestStoreFactory
>>
>> Should we annotate such classes as deprecated too?
>>
>> On Wed, Jan 31, 2018 at 4:07 PM, Vyacheslav Daradur <daradurvs@gmail.com>
>> wrote:
>> > I filed the ticket [1] and will do it soon.
>> >
>> > [1] https://issues.apache.org/jira/browse/IGNITE-7588
>> >
>> > On Tue, Jan 30, 2018 at 2:27 PM, Anton Vinogradov
>> > <avinogradov@gridgain.com> wrote:
>> >> +1
>> >>
>> >> On Tue, Jan 30, 2018 at 9:02 AM, Yakov Zhdanov <yzhdanov@apache.org>
>> wrote:
>> >>
>> >>> +1 for deprecation
>> >>>
>> >>>
>> >>>
>> >>> --Yakov
>> >>>
>> >>> 2018-01-30 1:06 GMT+03:00 Valentin Kulichenko <
>> >>> valentin.kulichenko@gmail.com
>> >>> >:
>> >>>
>> >>> > +1
>> >>> >
>> >>> > On Mon, Jan 29, 2018 at 8:31 AM, Andrey Mashenkov <
>> >>> > andrey.mashenkov@gmail.com> wrote:
>> >>> >
>> >>> > > Vyacheslav,
>> >>> > >
>> >>> > > +1 for dropping @CacheLocalStore.
>> >>> > > Ignite have no support 2-phase commit for store and public
API
>> provides
>> >>> > no
>> >>> > > methods to users can easily implement it by themselves.
>> >>> > >
>> >>> > >
>> >>> > >
>> >>> > >
>> >>> > > On Mon, Jan 29, 2018 at 7:11 PM, Vyacheslav Daradur <
>> >>> daradurvs@gmail.com
>> >>> > >
>> >>> > > wrote:
>> >>> > >
>> >>> > > > Hi Igniters,
>> >>> > > >
>> >>> > > > I've worked with Apache Ignite 3rd Party Persistent Storage
tools
>> >>> > > recently.
>> >>> > > >
>> >>> > > > I found that use of CacheLocalStore annotation has hidden
>> issues, for
>> >>> > > > example:
>> >>> > > > * rebalancing issues [1]
>> >>> > > > * possible data consistency issues [1]
>> >>> > > > * handling of CacheLocalStore on clients nodes [2]
>> >>> > > >
>> >>> > > > Valentin K. considers it necessary to make @CacheLocalStore
>> >>> deprecated
>> >>> > > > and remove. If we want to have a decentralized persistent
>> storage we
>> >>> > > > should use Apache Ignite Native Persistence.
>> >>> > > >
>> >>> > > > If the community supports this decision I will create
a new Jira
>> >>> issue.
>> >>> > > >
>> >>> > > > Any thoughts?
>> >>> > > >
>> >>> > > > [1] http://apache-ignite-developers.2346864.n4.nabble.
>> >>> > > > com/Losing-data-during-restarting-cluster-with-
>> >>> > > > persistence-enabled-tt24267.html
>> >>> > > > [2] http://apache-ignite-developers.2346864.n4.nabble.
>> >>> > com/How-to-handle-
>> >>> > > > CacheLocalStore-on-clients-node-tt25703.html
>> >>> > > >
>> >>> > > >
>> >>> > > >
>> >>> > > > --
>> >>> > > > Best Regards, Vyacheslav D.
>> >>> > > >
>> >>> > >
>> >>> > >
>> >>> > >
>> >>> > > --
>> >>> > > Best regards,
>> >>> > > Andrey V. Mashenkov
>> >>> > >
>> >>> >
>> >>>
>> >
>> >
>> >
>> > --
>> > Best Regards, Vyacheslav D.
>>
>>
>>
>> --
>> Best Regards, Vyacheslav D.
>>



-- 
Best Regards, Vyacheslav D.

Mime
View raw message