ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nikolay Izhikov <nizhi...@apache.org>
Subject Re: IgniteDataStreamer silently fails on a server node
Date Thu, 22 Feb 2018 18:09:49 GMT

> I set org.apache.ignite.internal.processors.datastreamer.DataStreamerImpl#DFLT_MAX_REMAP_CNT
to zero and see test fails now.

Anton, thank you very much!

I've prepared PR [1] to fix issue [2]. TC looks OK.

Looks like it was introduced by commit 53802d8b46f8ee09d51ba84267f65dc6f7e73a2f [3]

Can, anyone do review of my fix?
It literally consists of 1 LOC.

[1] https://github.com/apache/ignite/pull/3550
[2] https://issues.apache.org/jira/browse/IGNITE-7756
[3] https://github.com/SomeFire/ignite/commit/53802d8b46f8ee09d51ba84267f65dc6f7e73a2f

В Ср, 21/02/2018 в 15:49 +0300, Anton Vinogradov пишет:
> Nikolay,
> 
> I checked your reproducer and it looks like retry helps data streamer to
> solve this.
> I
> set org.apache.ignite.internal.processors.datastreamer.DataStreamerImpl#DFLT_MAX_REMAP_CNT
> to zero and see test fails now.
> 
> Looks like second attempt is successful for such case.
> 
> On Wed, Feb 21, 2018 at 1:36 PM, Dmitriy Setrakyan <dsetrakyan@apache.org>
> wrote:
> 
> > On Wed, Feb 21, 2018 at 12:10 AM, Nikolay Izhikov <nizhikov@apache.org>
> > wrote:
> > 
> > > Hello, Igniters.
> > > 
> > > > Does this exception happen because IgniteUuid class is not correctly
> > > > handled?
> > > 
> > > Yes. I've fixed it.
> > > But story doesn't end :)
> > > 
> > > > As far as propagating exceptions, addData(...) is asynchronous
> > 
> > operation
> > > > and returns IgniteFuture.
> > > 
> > > Thank you, my bad.
> > > 
> > > But, I can't understand when returned future should complete?
> > > 
> > > Javadocs or documentation doesn't explain it.
> > > Also, I can't find any tests that checks future returned from addData.
> > > 
> > > Can someone explan it to me?
> > > 
> > 
> > The returned future should complete either when the data is successfully
> > stored in cache, or whenever the failure occurs.
> > 
Mime
View raw message