From dev-return-29938-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Wed Jan 10 20:32:51 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id BF0B818072F for ; Wed, 10 Jan 2018 20:32:51 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id AEB66160C2E; Wed, 10 Jan 2018 19:32:51 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id F1EED160C1E for ; Wed, 10 Jan 2018 20:32:50 +0100 (CET) Received: (qmail 38294 invoked by uid 500); 10 Jan 2018 19:32:50 -0000 Mailing-List: contact dev-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list dev@ignite.apache.org Received: (qmail 38283 invoked by uid 99); 10 Jan 2018 19:32:50 -0000 Received: from mail-relay.apache.org (HELO mail-relay.apache.org) (140.211.11.15) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Jan 2018 19:32:50 +0000 Received: from mail-qk0-f172.google.com (mail-qk0-f172.google.com [209.85.220.172]) by mail-relay.apache.org (ASF Mail Server at mail-relay.apache.org) with ESMTPSA id ECAEE1A00A0 for ; Wed, 10 Jan 2018 19:32:48 +0000 (UTC) Received: by mail-qk0-f172.google.com with SMTP id u76so255306qku.11 for ; Wed, 10 Jan 2018 11:32:46 -0800 (PST) X-Gm-Message-State: AKwxytcIS1zr34Gq/ElOdlQDficYz7I7AyZzwSPaM8WW/+Qchxj7rSRW dYhBSjqe4gVzD6KMM5nRir3qJ3lhpVtAmAIqEEUxCw== X-Google-Smtp-Source: ACJfBovz39U1u3ige8N1HaiD3A+t5XMJgJ7c0qqfKR6wyHhKAXVDin5pTKt4WuIGT+esk279mszXQBjMbIYL/wCCz58= X-Received: by 10.55.24.16 with SMTP id j16mr27854286qkh.298.1515612766121; Wed, 10 Jan 2018 11:32:46 -0800 (PST) MIME-Version: 1.0 Received: by 10.140.36.133 with HTTP; Wed, 10 Jan 2018 11:32:05 -0800 (PST) In-Reply-To: References: From: Dmitriy Setrakyan Date: Wed, 10 Jan 2018 11:32:05 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Irrelevant data in discovery messages To: dev@ignite.apache.org Content-Type: multipart/alternative; boundary="001a114415e68b31b6056271189c" --001a114415e68b31b6056271189c Content-Type: text/plain; charset="UTF-8" Absolutely agree. I thought we could already filter out system and environment properties on startup via configuration. I think it was implemented by Yakov a long time ago. Yakov Zhdanov, can you please chime in? ( Denis, the information you mention is static and does not change. It would be enough to include it only into Join requests and not regular heartbeats. I hope that it is already happening this way. Can you please confirm? D. On Wed, Jan 10, 2018 at 12:30 AM, Denis Mekhanikov wrote: > Igniters, > > Turns out, that we are sending a lot of irrelevant information in discovery > messages. Some messages contain *TcpDiscoveryNode* objects, which in turn > have such attributes like *PATH, java.class.path, sun.boot.class.path, > java.library.path, org.apache.ignite.jvm.args, *etc. > Some of these attributes may contain huge strings, that can sum up to > megabytes of data. > > It was noticed by a user on our mailing list: > http://apache-ignite-users.70518.x6.nabble.com/Connection-problem-between- > client-and-server-td19243.html > In his case these huge messages make discovery process really slow. > > I think, we should filter-out such attributes, because they are not used > anywhere, but make messages grow enormous and slow down discovery. We could > include only user-defined and internal attributes + a fixed set of > environment variables. > > What do you think? > > Denis > --001a114415e68b31b6056271189c--