ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dmitriy Setrakyan...@gridgain.com>
Subject Re: Suppressing "development" warning
Date Tue, 12 Dec 2017 00:21:01 GMT
I actually like the new WARNING_DEV_ONLY category for logging. If we
provide it in the default logger configuration, then users will not have to
do anything extra unless they want to change it. Moreover, if it is a
category, then it can be turned on and off using standard logger
configuration.

D.

On Mon, Dec 11, 2017 at 3:28 PM, Valentin Kulichenko <
valentin.kulichenko@gmail.com> wrote:

> Igniters,
>
> We have bunch of warnings in the product which are useful only during
> development. One of the examples of is "Class ... cannot be serialized
> using BinaryMarshaller because it either implements Externalizable ...'
> warning - it is very useful when one is writing code as it warns about
> possible mistakes and suggest how to fix them, but once implementation is
> done, it is meaningless. Moreover, in production environments all warnings
> and errors are often automatically monitored, so this introduces an issue
> of false positive alerts generated by this kind of warnings.
>
> I see two possible solutions for this:
> - Add 'devOnly' flag to IgniteLogger#warning method and ignore them if
> special system property is set.
> - Introduce special logger category for such warnings so that user can
> control if they are logged or not.
>
> I think my vote is for the first option as it's more straightforward and
> doesn't require any additional configuration from a user.
>
> Thoughts?
>
> -Val
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message