ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexey Plekhanov <plehanov.a...@gmail.com>
Subject Re: Annoying extra steps for enabling metrics
Date Fri, 29 Dec 2017 11:51:37 GMT
Denis, I start working on the issue
https://issues.apache.org/jira/browse/IGNITE-6925 and now I don't understand
why these properties must be bound to each other?

• If we enable statistics on caches, this does not necessarily mean,  that
we wanted to get some events, we can enable statistics for other reasons.
Conversely, not all events need statistics to be enabled on caches. So we
can’t bind statistics flag to events (subscribe to events when statistics is
enabled or enable statistics, when subscribing to events)
• We can’t set events of interest, when we set not a dummy EventsStorageSpi,
because we don’t know which events are interesting.
• When we set events of interest, it’s not necessary, that these events will
be monitored using EventsStorageSpi, we can also subscribe to events by
events listeners, in this case EventsStorageSpi don’t used.

So, there is no general rule (if ... enabled, then ... must be enabled too).
The only implementation I can propose - is "set MemoryEventStorageSPI
instead of NoopEventStorageSPI when includeEventTypes list is not empty",
but even this implementation may be warranted only in some cases.


Denis Magda-2 wrote
> Let’s simplifying the metrics as a part of this ticket:
> https://issues.apache.org/jira/browse/IGNITE-5796
> &lt;https://issues.apache.org/jira/browse/IGNITE-5796&gt;
> 
> Expanded its scope.
> 
> —
> Denis
> 
>> On Sep 9, 2017, at 2:44 PM, Valentin Kulichenko &lt;

> valentin.kulichenko@

> &gt; wrote:
>> 
>> statisticsEnabled property comes from JCache, BTW.
>> 
>> -Val
>> 
>> On Sat, Sep 9, 2017 at 11:09 AM, Dmitriy Setrakyan &lt;

> dsetrakyan@

> &gt;
>> wrote:
>> 
>>> On Sat, Sep 9, 2017 at 8:56 AM, Denis Magda &lt;

> dmagda@

> &gt; wrote:
>>> 
>>>> Surprise!
>>>> 
>>>> If you want to see cache events then you have to enable one more flag!
>>>> 
>>>> 
> <property name="StatisticsEnabled" value="true"/>
>>> 
>>> 
>>> What is the overhead of this statistics collection?
>>> 
>>> 
>>>> Three flags/beans have to be in the config in total, three! Just to see
>>>> cache events. The API is a mess. Let’s contemplate how to fix it.
>>> 
>>> 
>>> Agree, this is horrible. We need to fix it in 2.3. Is there a ticket?





--
Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/

Mime
View raw message