Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 77047200D19 for ; Fri, 6 Oct 2017 23:51:45 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 7574F1609E1; Fri, 6 Oct 2017 21:51:45 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 6C3721609D0 for ; Fri, 6 Oct 2017 23:51:44 +0200 (CEST) Received: (qmail 46737 invoked by uid 500); 6 Oct 2017 21:51:43 -0000 Mailing-List: contact dev-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list dev@ignite.apache.org Received: (qmail 46721 invoked by uid 99); 6 Oct 2017 21:51:43 -0000 Received: from mail-relay.apache.org (HELO mail-relay.apache.org) (140.211.11.15) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 06 Oct 2017 21:51:43 +0000 Received: from [172.31.168.134] (unknown [216.9.110.3]) by mail-relay.apache.org (ASF Mail Server at mail-relay.apache.org) with ESMTPSA id 7265E1A012B for ; Fri, 6 Oct 2017 21:51:42 +0000 (UTC) From: Denis Magda Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: Re: Adding sqlline tool to Apache Ignite project Date: Fri, 6 Oct 2017 14:51:41 -0700 References: <19BBC834-B22D-4CBF-B6B4-8A1405227959@apache.org> <0CAB33E3-1E6C-48A2-9131-7D9BE3E1FDAB@apache.org> <3ad7522f-60df-4ea6-bafd-c0e336ad702b@apache.org> <8C8201C8-3815-4183-A499-7EBD9ED2B408@apache.org> To: dev@ignite.apache.org In-Reply-To: Message-Id: X-Mailer: Apple Mail (2.3273) archived-at: Fri, 06 Oct 2017 21:51:45 -0000 Thought over 127.0.0.1 as a default host once again. The bad thing about = it is that the user gets a lengthy exception stack trace if Ignite is = not running locally and not a small error message.=20 What are the other opinions on this? Do we want to follow Vladimir=E2=80=99= s suggestion forcing to set the host name/IP (port is optional) for the = sake of usability or leaver 127.0.0.1 as default? =E2=80=94 Denis =20 > On Oct 6, 2017, at 12:21 PM, Denis Magda wrote: >=20 >> But, we need to support =E2=80=9Chelp=E2=80=9D (-h, -help) argument = listing all the parameters accepted by the tools. >=20 > Meant accepted by the ignitesql script only such as host name. >=20 > =E2=80=94 > Denis >=20 >> On Oct 6, 2017, at 12:20 PM, Denis Magda wrote: >>=20 >> Really nice, could click through the getting started [1] in a minute! >>=20 >> +1 to rename the script to =E2=80=9Cignitesql=E2=80=9D. Vladimir=E2=80=99= s point makes total sense. >>=20 >> However, tend to disagree that the host has to be requested all the = times. We never request a configuration or host name for ignite.sh, = visor or web agent scripts. I would follow this approach that=E2=80=99s = excellent for dev time. >>=20 >> But, we need to support =E2=80=9Chelp=E2=80=9D (-h, -help) argument = listing all the parameters accepted by the tools. >>=20 >> Please consider our feedback and share the next build once it=E2=80=99s= ready. >>=20 >>=20 >> [1] https://apacheignite-sql.readme.io/v2.1/docs/getting-started = >>=20 >> =E2=80=94 >> Denis >>=20 >>> On Oct 6, 2017, at 9:04 AM, Anton Vinogradov = wrote: >>>=20 >>> How about sqlconsole.sh or sqlcmd.sh ? >>>=20 >>> On Fri, Oct 6, 2017 at 6:04 PM, wrote: >>>=20 >>>> I like ignitesql. >>>>=20 >>>> =E2=81=A3D.=E2=80=8B >>>>=20 >>>> On Oct 6, 2017, 4:49 PM, at 4:49 PM, Vladimir Ozerov = >>>> wrote: >>>>> Denis, >>>>>=20 >>>>> Setting default host to 127.0.0.1 is bad idea, because it mean = that in >>>>> practice users would have to change the script always. Instead, we >>>>> should >>>>> accept host name as argument. This is perfectly fine from = usability >>>>> perspective, most tools work this way (i.e. throw error when = started >>>>> without arguments). >>>>>=20 >>>>> Also IMO "ignitedb" is misleading name. Users would like think = that it >>>>> is a >>>>> kind of script to start database, rather than to connect to it. We >>>>> should >>>>> think on other names. E.g. "ignitesql". >>>>>=20 >>>>> On Fri, Oct 6, 2017 at 5:23 PM, Sergey Kozlov = >>>>> wrote: >>>>>=20 >>>>>> Denis >>>>>>=20 >>>>>> The link below has included sqlline. Please take a look: >>>>>> https://ci.ignite.apache.org/viewLog.html?buildId=3D875441& >>>>>> buildTypeId=3DIgniteRelease_XxxFromMirrorIgniteRelease3Pre >>>>>> pareVote&tab=3Dartifacts#!1rrb2,-wpvx2aopzexz >>>>>>=20 >>>>>> On Thu, Oct 5, 2017 at 7:48 PM, Denis Magda >>>>> wrote: >>>>>>=20 >>>>>>> Here is the original ticket [1]. Ilya, closed the one created by >>>>> you as a >>>>>>> duplicate. >>>>>>>=20 >>>>>>> In addition to the tool=E2=80=99s jar inclusion in Ignite=E2=80=99= s binary releases >>>>> let=E2=80=99s >>>>>>> create a shell script to simplify the connectivity phase: >>>>>>>=20 >>>>>>> - name the script as ignitedb.sh for Unix and ignitedb.bat for >>>>>> Windows. >>>>>>> - >>>>>>> - the script uses the following connection string by default: >>>>> .sqlline >>>>>>> -d org.apache.ignite.IgniteJdbcThinDriver --color=3Dtrue >>>>> --verbose=3Dtrue >>>>>>> --showWarnings=3Dtrue --showNestedErrs=3Dtrue -u jdbc:ignite: >>>>>>> thin://127.0.0.1/ >>>>>>>=20 >>>>>>>=20 >>>>>>>=20 >>>>>>> - make up parameters list to adjust Ignite specific part of the >>>>>>> connection string: Ignite IP and port, streaming mode, etc. The >>>>> full >>>>>> list >>>>>>> of supported parameters is here: https://apacheignite- >>>>>>> sql.readme.io/docs/jdbc-driver#jdbc-thin-driver >>>>>>>=20 >>>>> = >>>>>>=20 >>>>>>>=20 >>>>>>>=20 >>>>>>>=20 >>>>>>> [1] https://issues.apache.org/jira/browse/IGNITE-5608 >>>>>>>=20 >>>>>>> =E2=80=94 >>>>>>> Denis >>>>>>>=20 >>>>>>> On Oct 5, 2017, at 9:02 AM, Sergey Kozlov >>>>> wrote: >>>>>>>=20 >>>>>>> Dmitriy, Denis >>>>>>>=20 >>>>>>> We're in progress to add sqlline in upcoming 2.3 >>>>>>>=20 >>>>>>> On Thu, Oct 5, 2017 at 5:30 PM, Dmitriy Setrakyan >>>>> >>>>>>> wrote: >>>>>>> Would be nice to get it in 2.3. This is critical functionality = for >>>>> our >>>>>>> users and 2.4 seems too far to give anyone comfort. >>>>>>>=20 >>>>>>> On Thu, Oct 5, 2017 at 11:33 AM, Ilya Suntsov >>>>> >>>>>>> wrote: >>>>>>>=20 >>>>>>>> Guys, >>>>>>>>=20 >>>>>>>> I've created the ticket for 2.4 release: >>>>>>>> https://issues.apache.org/jira/browse/IGNITE-6561 >>>>>>>>=20 >>>>>>>> 2017-08-30 22:21 GMT+03:00 Julian Hyde : >>>>>>>>=20 >>>>>>>>> Denis, >>>>>>>>>=20 >>>>>>>>> I=E2=80=99m glad you=E2=80=99re thinking of using SQLLine. = Under the BSD >>>>> license, you >>>>>>>>> don=E2=80=99t need my permission to distribute, but I grant = that >>>>> permission. >>>>>>>>>=20 >>>>>>>>> Drill, Phoenix and Calcite already distribute SQLLine, so >>>>> Ignite is >>>>>> in >>>>>>>>> good company. >>>>>>>>>=20 >>>>>>>>> If you need extensions, please discuss on the dev list, or = open >>>>> a >>>>>>> GitHub >>>>>>>>> case or pull request. SQLLine operates in the usual way for a >>>>> GitHub >>>>>>>>> project. It=E2=80=99s unlikely that you=E2=80=99ll need = Ignite-specific >>>>> extensions =E2=80=94 >>>>>>>>> SQLLine just exposes what comes through the JDBC driver =E2=80=94= but >>>>> we can >>>>>>>>> discuss if the need arises. The Hive project forked SQLLine >>>>> into its >>>>>>> own >>>>>>>>> Beeline module and I=E2=80=99d like to avoid a repeat of that. >>>>>>>>>=20 >>>>>>>>> Julian >>>>>>>>>=20 >>>>>>>>>> On Aug 29, 2017, at 6:35 PM, Denis Magda >>>>>> wrote: >>>>>>>>>>=20 >>>>>>>>>> Igniters, >>>>>>>>>>=20 >>>>>>>>>> Let me introduce Julian Hyde [1], creator of SQLLine tool and >>>>> our >>>>>>>> Apache >>>>>>>>> mate, >>>>>>>>>>=20 >>>>>>>>>> Julian, >>>>>>>>>>=20 >>>>>>>>>> Please grant that Apache Ignite community a permission to >>>>> include >>>>>>>>> SQLLine [2] it in every Ignite deliverable (source, binary). >>>>> It=E2=80=99s >>>>>>> planned >>>>>>>>> to suggest the tool as a default command line SQL utility for >>>>> Ignite >>>>>>>>> clusters. SQLLite and Ignite usage will also be documented on >>>>>> Ignite=E2=80=99s >>>>>>>>> technical documentation. >>>>>>>>>>=20 >>>>>>>>>> [1] https://people.apache.org/~jhyde/ < >>>>>> https://people.apache.org/~jh >>>>>>>> yde/ >>>>>>>>>>=20 >>>>>>>>>> [2] https://github.com/julianhyde/sqlline >>>>> >>>>>>>> julianhyde/sqlline> >>>>>>>>>>=20 >>>>>>>>>> =E2=80=94 >>>>>>>>>> Denis >>>>>>>>>>=20 >>>>>>>>>>> On Aug 25, 2017, at 9:17 AM, Denis Magda >>>>>> >>>>>>>> dmagda@apache.org>> wrote: >>>>>>>>>>>=20 >>>>>>>>>>> Hi Ilya, >>>>>>>>>>>=20 >>>>>>>>>>> Thanks for the clarification! Referring to the page shared >>>>> by you >>>>>>> [1] >>>>>>>>> if we need to get author=E2=80=99s consent in a written form: >>>>>>>>>>>=20 >>>>>>>>>>> A permissive license similar to the BSD 2-Clause License, >>>>> but >>>>>> with a >>>>>>>>> 3rd clause that prohibits others from using the name of the >>>>> project >>>>>> or >>>>>>>> its >>>>>>>>> contributors to promote derived products without written >>>>> consent. >>>>>>>>>>>=20 >>>>>>>>>>> [1] >>>>> https://github.com/julianhyde/sqlline/blob/master/LICENSE < >>>>>>>>> https://github.com/julianhyde/sqlline/blob/master/LICENSE> < >>>>>>>>> https://github.com/julianhyde/sqlline/blob/master/LICENSE < >>>>>>>>> https://github.com/julianhyde/sqlline/blob/master/LICENSE>> >>>>>>>>>>>=20 >>>>>>>>>>> I=E2=80=99ll reach out the author requesting the permit. >>>>>>>>>>>=20 >>>>>>>>>>> =E2=80=94 >>>>>>>>>>> Denis >>>>>>>>>>>=20 >>>>>>>>>>>> On Aug 25, 2017, at 9:12 AM, Ilya Kasnacheev < >>>>>>>>> ilya.kasnacheev@gmail.com > >>>>> wrote: >>>>>>>>>>>>=20 >>>>>>>>>>>> Hi Denis, >>>>>>>>>>>>=20 >>>>>>>>>>>> There are two kinds of BSD license, 3-clause and 4-clause. >>>>> The >>>>>>>>> difference >>>>>>>>>>>> between them is advertising clause: >>>>>>>>>>>>=20 >>>>>>>>>>>> "3. All advertising materials mentioning features or use of >>>>> this >>>>>>>>> software >>>>>>>>>>>> must display the following acknowledgement: This product >>>>> includes >>>>>>>>> software >>>>>>>>>>>> developed by the University of California, Berkeley and its >>>>>>>>> contributors." >>>>>>>>>>>>=20 >>>>>>>>>>>> which is causing problems with other licenses and which >>>>> sqlline's >>>>>>>>> license >>>>>>>>>>>> doesn't contain: >>>>>>>>>>>> https://github.com/julianhyde/sqlline/blob/master/LICENSE < >>>>>>>>> https://github.com/julianhyde/sqlline/blob/master/LICENSE> >>>>>>>>>>>> So it should be all good for inclusion. >>>>>>>>>>>>=20 >>>>>>>>>>>> -- >>>>>>>>>>>> Ilya Kasnacheev. >>>>>>>>>>>>=20 >>>>>>>>>>>> 2017-08-25 18:48 GMT+03:00 Denis Magda : >>>>>>>>>>>>=20 >>>>>>>>>>>>> Hi Ilya, >>>>>>>>>>>>>=20 >>>>>>>>>>>>> It will be a useful addition to Ignite. I would include >>>>> the tool >>>>>>> in >>>>>>>>> one of >>>>>>>>>>>>> the nearest releases. It=E2=80=99s license is BSD-3 which = is >>>>> compatible >>>>>>> with >>>>>>>>> ours. >>>>>>>>>>>>> However, there is a note on ASF side saying that BSD >>>>> licenses >>>>>> can >>>>>>> be >>>>>>>>>>>>> included without advertising clause [1]. What does it mean >>>>> for >>>>>> us? >>>>>>>>> Can we >>>>>>>>>>>>> document the tool and mention on our site? >>>>>>>>>>>>>=20 >>>>>>>>>>>>> [1] https://www.apache.org/legal/resolved.html#category-a >>>>> < >>>>>>>>>>>>> https://www.apache.org/legal/resolved.html#category-a> >>>>>>>>>>>>>=20 >>>>>>>>>>>>> =E2=80=94 >>>>>>>>>>>>> Denis >>>>>>>>>>>>>=20 >>>>>>>>>>>>>> On Aug 25, 2017, at 8:32 AM, Ilya Suntsov < >>>>>> isuntsov@gridgain.com >>>>>>>>=20 >>>>>>>>> wrote: >>>>>>>>>>>>>>=20 >>>>>>>>>>>>>> Hi Igniters, >>>>>>>>>>>>>>=20 >>>>>>>>>>>>>> I've found one command line tool that can be used for >>>>> execute >>>>>>>> queries >>>>>>>>>>>>>> (DDL/DML) with data from Apache Ignite grid via >>>>>>>>>>>>>> *org.apache.ignite.IgniteJdbcThinDriver*. >>>>>>>>>>>>>>=20 >>>>>>>>>>>>>> Here you can find overview of internal commands of this >>>>> tool: >>>>>>>>>>>>>> https://cwiki.apache.org/confluence/display/IGNITE/ >>>>>>>>> Overview+sqlline+tool >>>>>>>>>>>>>>=20 >>>>>>>>>>>>>> The most problems with sqlline relate with some issues >>>>> from our >>>>>>>> side >>>>>>>>> or >>>>>>>>>>>>>> some unsupported features. >>>>>>>>>>>>>>=20 >>>>>>>>>>>>>> Would be nice to add tool like this (sqlline or something >>>>> else) >>>>>>> in >>>>>>>>> our >>>>>>>>>>>>>> project. >>>>>>>>>>>>>>=20 >>>>>>>>>>>>>> Have you any objections or other thoughts? >>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>=20 >>>>>>>>>>>>>> -- >>>>>>>>>>>>>> Ilya Suntsov >>>>>>>>>>>>>=20 >>>>>>>>>>>>>=20 >>>>>>>>>>>=20 >>>>>>>>>>=20 >>>>>>>>>=20 >>>>>>>>>=20 >>>>>>>>=20 >>>>>>>>=20 >>>>>>>> -- >>>>>>>> Ilya Suntsov >>>>>>>>=20 >>>>>>>=20 >>>>>>>=20 >>>>>>>=20 >>>>>>> -- >>>>>>> Sergey Kozlov >>>>>>> GridGain Systems >>>>>>> www.gridgain.com >>>>>>>=20 >>>>>>>=20 >>>>>>>=20 >>>>>>=20 >>>>>>=20 >>>>>> -- >>>>>> Sergey Kozlov >>>>>> GridGain Systems >>>>>> www.gridgain.com >>>>>>=20 >>>>=20 >>=20 >=20