Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D1202200D2D for ; Fri, 13 Oct 2017 04:01:46 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id CF8BB160BE4; Fri, 13 Oct 2017 02:01:46 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 9EE341609E8 for ; Fri, 13 Oct 2017 04:01:45 +0200 (CEST) Received: (qmail 20132 invoked by uid 500); 13 Oct 2017 02:01:44 -0000 Mailing-List: contact dev-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list dev@ignite.apache.org Received: (qmail 20120 invoked by uid 99); 13 Oct 2017 02:01:44 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 13 Oct 2017 02:01:44 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 542D318329D for ; Fri, 13 Oct 2017 02:01:43 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.3 X-Spam-Level: X-Spam-Status: No, score=-0.3 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-2.8, RCVD_IN_SORBS_SPAM=0.5, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gridgain-com.20150623.gappssmtp.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id QaN6xs4sm2HH for ; Fri, 13 Oct 2017 02:01:37 +0000 (UTC) Received: from mail-qk0-f176.google.com (mail-qk0-f176.google.com [209.85.220.176]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 95CB55F239 for ; Fri, 13 Oct 2017 02:01:36 +0000 (UTC) Received: by mail-qk0-f176.google.com with SMTP id q83so315664qke.6 for ; Thu, 12 Oct 2017 19:01:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gridgain-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=Le8PfHAPukERrFAIM8Q4EHvhhKFbeO5nySxiFRcFiz4=; b=XPAioPVrYAWAcTnxFkWLLL8+XDudIyHUC/PvAnXLoprmxZGPkXojA+tVcpB7xjc4iL ISsaTvpQQOdZ/y/WJRszfrEbUJB4KFP2T6To1nWUfea16OviiBFarfvku30PtxvYFXYv lH4HW/RUwC+PcHGiaVBzkAPM0EvIkUIJ3azJ80dHHNLmBVeS/fr8ROAob42Y8IC54Zs+ TSYxloRzAQH5QeRMtEuGmTQw3XmxcOFGtB14R8G/EJK7UUeD8S3SE8XjXHBT8/vnGa+P uzTGlwxcnmnmCNRCv7f3KaN3VpIBEMRvwq+eTEH6HEUzQJ4vuV0XPlZPb8NB0LlcMe+a 6Puw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=Le8PfHAPukERrFAIM8Q4EHvhhKFbeO5nySxiFRcFiz4=; b=U8DUf4DZVVbqGrkBw/dDa4s6P+FYrz5hpkNqEUGI2MSYhW9SaRbu+hBUiVOo+DFrxe p2Vz8R2AcL5D3RuOLqkfJ78jxUAVSnm7tmqJyvN7WFGOYBF7Y2OcZsOVcm49+bDGvl9+ uQ/7MPg1RaVPtAqqUrTE9byFavHiIBd3s4fR9f5OQJjJfqwxMq+CFGH4IdyeTv1Og840 V4pF1m83qKkFqEfUEGOav9iyt4zfFAeGHYOBINyuq5oF6E8gz6P0F9Gh1AaRMqpbztra jZ8drFN6kjMq2Gh+y3sZkVY1/mQyKUzNyXFsmrLoTZ9vG5Qw+cuXEbeGIxqBtmJSErX2 pbig== X-Gm-Message-State: AMCzsaW9vAftkrW3ERTJSXFeX2FGzd38c0Ip6WLlOUKZwPOVVjVIiPV0 X0FMxGtca1q3RMpYvCVnF85rHdPl4kCVscI6qTTznK41 X-Google-Smtp-Source: ABhQp+Q6LUfwa37V4ujFgNeb3X6R0rnRDz++DX0ZWIYArImkNhn07XOmlr23vwYWNyk1UK5l6qEgI7SClfPlE9sdhps= X-Received: by 10.55.116.5 with SMTP id p5mr3308909qkc.151.1507860095049; Thu, 12 Oct 2017 19:01:35 -0700 (PDT) MIME-Version: 1.0 Received: by 10.12.187.152 with HTTP; Thu, 12 Oct 2017 19:01:34 -0700 (PDT) In-Reply-To: References: <2e3f37db-4cd3-f595-2506-3c3db408fc61@gmail.com> <3C43D7EC-F109-480D-A71B-197F5A407DA0@apache.org> <5a1980fa-184c-d77d-9d1d-9a02ae6ce281@gmail.com> <70089e9a-caa9-9236-24ed-1daa6e1f9810@gmail.com> <605757bd-751f-5954-be26-be044c4244ce@gmail.com> <14cd3d61-daba-d2c1-8ef9-646c03a64b35@gmail.com> <768792ac-478a-16b1-c11d-22072804b2e8@gmail.com> <245AE873-0BAD-4ABA-BB37-D4949ED58530@apache.org> From: Denis Magda Date: Thu, 12 Oct 2017 19:01:34 -0700 Message-ID: Subject: Re: Persistence per memory policy configuration To: "dev@ignite.apache.org" Content-Type: multipart/alternative; boundary="001a114fde9c563948055b6409f0" archived-at: Fri, 13 Oct 2017 02:01:47 -0000 --001a114fde9c563948055b6409f0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable From what I see after running an example they are under the same root folder and in different subdirectories. The root folder should be defined by setPersistencePath as I guess. Denis On Thursday, October 12, 2017, Dmitriy Setrakyan wrote: > On Thu, Oct 12, 2017 at 4:05 PM, Denis Magda > wrote: > > > Both terms =E2=80=9Cpersistence=E2=80=9D and =E2=80=9Cstorage=E2=80=9D = mean same to me. If to choose > > between them I would go for =E2=80=9Cpersistence=E2=80=9D because this = is how > > we name the feature - =E2=80=9CIgnite Persistence=E2=80=9D [1] > > > > Furthermore, by default WAL files, the archive and data/index files are > > located under the same root which is =E2=80=9CsetPersistencePath=E2=80= =9D directory. > > > > Denis, to my knowledge, WAL can span multiple caches, no? How can it end = up > in the same folder with data and indexes, if those are per cache? > > > > > > [1] https://ignite.apache.org/features/persistence.html < > > https://ignite.apache.org/features/persistence.html> > > > > =E2=80=94 > > Denis > > > > > On Oct 12, 2017, at 12:00 AM, Ivan Rakov > wrote: > > > > > > Name *setPersistencePath* looks confusing to me because both WAL and > > index/partition files storage provide persistence. That's why we > separated > > API methods as *setWalPath* and *setStoragePath*. > > > I think, *setStoragePath* is good enough as long as it's supported by > > explaining javadoc.* > > > * > > > > > > Best Regards, > > > Ivan Rakov > > > > > > On 12.10.2017 8:05, Dmitriy Setrakyan wrote: > > >> Is the storage path the root folder for the persistence or only the > root > > >> path for the main storage? > > >> > > >> On Wed, Oct 11, 2017 at 3:54 PM, Denis Magda > wrote: > > >> > > >>> Ivan, > > >>> > > >>> Instead of =E2=80=9CsetStoragePath=E2=80=9D I would suggest =E2=80= =9CsetPersistencePath=E2=80=9D. > Left > > >>> some extra notes in the ticket. > > >>> > > >> > > >>> =E2=80=94 > > >>> Denis > > >>> > > >>>> On Oct 11, 2017, at 4:30 AM, Ivan Rakov > > > wrote: > > >>>> > > >>>> Vladimir, > > >>>> > > >>>> Thanks for focusing on existing namings. Most of your suggestions > > really > > >>> sound better. I've posted my thoughts under your comment. > > >>>> By the way, we should decide two things: > > >>>> > > >>>> 1) Naming for methods for configuring store path. I suggest the > > >>> following: > > >>>> *setStoragePath* - for partition and index files > > >>>> *setWalPath* - for WAL files > > >>>> *walArchivePath* - for WAL archive files > > >>>> > > >>>> 2) Renaming *checkpointingFrequency* to *checkpointFrequency* (sam= e > > with > > >>> *checkpointingPageBufferSize* and *checkpointingThreads*). Both > options > > >>> sounds ok to me, let's see what community thinks. > > >>>> Best Regards, > > >>>> Ivan Rakov > > >>>> > > >>>> On 11.10.2017 14:05, Vladimir Ozerov wrote: > > >>>>> Ivan, > > >>>>> > > >>>>> I left some comments in the ticket [1], please take a look. > > >>>>> > > >>>>> [1] > > >>>>> https://issues.apache.org/jira/browse/IGNITE-6030? > > >>> focusedCommentId=3D16200050&page=3Dcom.atlassian.jira. > > >>> plugin.system.issuetabpanels:comment-tabpanel#comment-16200050 > > >>>>> On Wed, Oct 11, 2017 at 12:04 PM, Ivan Rakov < > ivan.glukos@gmail.com > > > >>> wrote: > > >>>>>> Igniters, > > >>>>>> > > >>>>>> https://issues.apache.org/jira/browse/IGNITE-6030 is ready and > > >>> enqueued > > >>>>>> for TC run. > > >>>>>> PR: https://github.com/apache/ignite/pull/2828 > > >>>>>> > > >>>>>> Everyone interested in new data storage configuration API, pleas= e > > pay > > >>>>>> attention and review. > > >>>>>> > > >>>>>> > > >>>>>> Best Regards, > > >>>>>> Ivan Rakov > > >>>>>> > > >>>>>> > > >>>>>> On 09.10.2017 12:40, Pavel Tupitsyn wrote: > > >>>>>> > > >>>>>>> Sounds good to me. > > >>>>>>> > > >>>>>>> On Mon, Oct 9, 2017 at 12:35 PM, Ivan Rakov < > ivan.glukos@gmail.com > > > > > >>>>>>> wrote: > > >>>>>>> > > >>>>>>> Pavel, > > >>>>>>>> Sounds reasonable. > > >>>>>>>> I suggest to include both "data" and "configuration" to make i= t > > even > > >>> more > > >>>>>>>> obvious: > > >>>>>>>> > > >>>>>>>> set/getDefaultDataRegionConfiguration > > >>>>>>>> set/getDataRegionConfigurations > > >>>>>>>> > > >>>>>>>> Best Regards, > > >>>>>>>> Ivan Rakov > > >>>>>>>> > > >>>>>>>> > > >>>>>>>> On 09.10.2017 10:51, Pavel Tupitsyn wrote: > > >>>>>>>> > > >>>>>>>> Sorry that I'm late to the party, but this looks inconsistent: > > >>>>>>>>> DataStorageConfiguration defaultRegionConfiguration > > >>>>>>>>> DataRegionConfiguration[] getDataRegions > > >>>>>>>>> > > >>>>>>>>> defaultRegionConfiguration + getRegionConfigurations > > >>>>>>>>> - or - > > >>>>>>>>> defaultDataRegion + getDataRegions > > >>>>>>>>> > > >>>>>>>>> Thoughts? > > >>>>>>>>> > > >>>>>>>>> On Mon, Oct 2, 2017 at 9:10 PM, Ivan Rakov < > > ivan.glukos@gmail.com > > > >>>>>>>>> wrote: > > >>>>>>>>> > > >>>>>>>>> Denis, > > >>>>>>>>> > > >>>>>>>>>> Yes, you're right. All cache groups without specific data > region > > >>>>>>>>>> configured will be persistent. > > >>>>>>>>>> And if you want to add another persistent data region, you > > should > > >>> set > > >>>>>>>>>> *isPeristenceEnabled* flag in its *DataRegionConfiguration* > > >>> explictly. > > >>>>>>>>>> Best Regards, > > >>>>>>>>>> Ivan Rakov > > >>>>>>>>>> > > >>>>>>>>>> > > >>>>>>>>>> On 02.10.2017 21:01, Denis Magda wrote: > > >>>>>>>>>> > > >>>>>>>>>> Missed the point with defaults. Makes sense to me now. So to > > wrap > > >>> this > > >>>>>>>>>>> up, if I want to enable the persistence globally and don=E2= =80=99t > have > > >>> any > > >>>>>>>>>>> regions > > >>>>>>>>>>> configured explicitly I need to take the default region and > > >>> switch the > > >>>>>>>>>>> persistence on for it. Is my understanding correct? > > >>>>>>>>>>> > > >>>>>>>>>>> =E2=80=94 > > >>>>>>>>>>> Denis > > >>>>>>>>>>> > > >>>>>>>>>>> On Oct 2, 2017, at 10:57 AM, Ivan Rakov < > ivan.glukos@gmail.com > > > > > >>>>>>>>>>> wrote: > > >>>>>>>>>>> > > >>>>>>>>>>> Denis, why do you need to access an instance of the default > > region > > >>>>>>>>>>>> bean? > > >>>>>>>>>>>> If you want to set any parameter, just instantiate new bea= n > > with > > >>> this > > >>>>>>>>>>>> parameter set (like in XML snipped below). Other parameter= s > > will > > >>> be > > >>>>>>>>>>>> automatically initialized with their default values. > > >>>>>>>>>>>> > > >>>>>>>>>>>> Best Regards, > > >>>>>>>>>>>> Ivan Rakov > > >>>>>>>>>>>> > > >>>>>>>>>>>> On 02.10.2017 19:28, Denis Magda wrote: > > >>>>>>>>>>>> > > >>>>>>>>>>>> > > >>>>>>>>>>>> > > >>>>>>>>>>>>> > >>>>>>>>>>>>>>> guration.DataStorageConfiguration"> > > >>>>>>>>>>>>>>> > >>>>>>>>>>>>>>> value=3D"#{100 > > >>>>>>>>>>>>>>> * > > >>>>>>>>>>>>>>> 1024 * 1024}"/> > > >>>>>>>>>>>>>>> > defaultRegionConfiguration"> > > >>>>>>>>>>>>>>> > >>>>>>>>>>>>>>> guration.DataRegionConfiguration"> > > >>>>>>>>>>>>>>> > value=3D"#{5 * > > >>>>>>>>>>>>>>> 1024 * > > >>>>>>>>>>>>>>> 102 * 1024}"/> > > >>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>> In other data regions persistence will be disabled by > > default. > > >>>>>>>>>>>>>>> > > >>>>>>>>>>>>>> Ivan, how to get an instance to the default region bean > and > > >>> change > > >>>>>>>>>>>>>> a > > >>>>>>>>>>>>>> > > >>>>>>>>>>>>> parameter? Obviously, if the goal is to enable the > > persistence I > > >>>>>>>>>>>>> don=E2=80=99t want > > >>>>>>>>>>>>> to create the default region bean from scratch. > > >>>>>>>>>>>>> > > >>>>>>>>>>>>> =E2=80=94 > > >>>>>>>>>>>>> Denis > > >>>>>>>>>>>>> > > >>>>>>>>>>>>> On Oct 2, 2017, at 9:11 AM, Ivan Rakov < > > ivan.glukos@gmail.com > > > >>>>>>>>>>>>> wrote: > > >>>>>>>>>>>>> > > >>>>>>>>>>>>> Agree with Alexey. > > >>>>>>>>>>>>>> Properties like *defaultDataRegionSize*, > > >>>>>>>>>>>>>> *isDefaultPersistenceEnabled* > > >>>>>>>>>>>>>> can confuse users who don't know that there's such thing > as > > >>> default > > >>>>>>>>>>>>>> data > > >>>>>>>>>>>>>> region. They can decide they are inherited by all data > > regions > > >>>>>>>>>>>>>> where > > >>>>>>>>>>>>>> size > > >>>>>>>>>>>>>> and persistence flag are not explicitly set. > > >>>>>>>>>>>>>> > > >>>>>>>>>>>>>> Let's get rid of these properties and add > > >>>>>>>>>>>>>> *defaultRegionConfiguration* > > >>>>>>>>>>>>>> property with explicit configuration of default data > region. > > >>>>>>>>>>>>>> > > >>>>>>>>>>>>>> Regarding XML configuration, changing size or persistenc= e > > flag > > >>> of > > >>>>>>>>>>>>>> default data region will be just two lines longer (for > bean > > >>>>>>>>>>>>>> description): > > >>>>>>>>>>>>>> > > >>>>>>>>>>>>>> > > >>>>>>>>>>>>>> > > >>>>>>>>>>>>>> > >>>>>>>>>>>>>>> guration.DataStorageConfiguration"> > > >>>>>>>>>>>>>>> > >>>>>>>>>>>>>>> value=3D"#{100 > > >>>>>>>>>>>>>>> * > > >>>>>>>>>>>>>>> 1024 * 1024}"/> > > >>>>>>>>>>>>>>> > defaultRegionConfiguration"> > > >>>>>>>>>>>>>>> > >>>>>>>>>>>>>>> guration.DataRegionConfiguration"> > > >>>>>>>>>>>>>>> > value=3D"#{5 * > > >>>>>>>>>>>>>>> 1024 * > > >>>>>>>>>>>>>>> 102 * 1024}"/> > > >>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>> In other data regions persistence will be disabled by > > default. > > >>>>>>>>>>>>>>> > > >>>>>>>>>>>>>> I've updated draft in https://issues.apache.org/jira > > >>>>>>>>>>>>>> /browse/IGNITE-6030 with these changes. > > >>>>>>>>>>>>>> > > >>>>>>>>>>>>>> Best Regards, > > >>>>>>>>>>>>>> Ivan Rakov > > >>>>>>>>>>>>>> > > >>>>>>>>>>>>>> On 02.10.2017 18:35, Denis Magda wrote: > > >>>>>>>>>>>>>> > > >>>>>>>>>>>>>> To resolve this, I suggest to > > >>>>>>>>>>>>>> > > >>>>>>>>>>>>>>> introduce just another field defaultRegionConfiguration > and > > >>> get > > >>>>>>>>>>>>>>>> rid > > >>>>>>>>>>>>>>>> of > > >>>>>>>>>>>>>>>> other defaults in DataStorageConfiguration. > > >>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>> Won=E2=80=99t it complicate the configuration from a S= pring XML > > >>> file? I=E2=80=99m > > >>>>>>>>>>>>>>> not > > >>>>>>>>>>>>>>> an expert in Spring so how do I get > > defaultRegionConfiguration > > >>>>>>>>>>>>>>> bean > > >>>>>>>>>>>>>>> first > > >>>>>>>>>>>>>>> to change any parameter? > > >>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>> =E2=80=94 > > >>>>>>>>>>>>>>> Denis > > >>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>> On Oct 2, 2017, at 8:30 AM, Alexey Goncharuk < > > >>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>> alexey.goncharuk@gmail.com > wrote: > > >>>>>>>>>>>>>>>> Agree with Vladimir. If we are to implement this, we > would > > >>> either > > >>>>>>>>>>>>>>>> need to > > >>>>>>>>>>>>>>>> have a Boolean (non-primitive) for persistenceEnabled = on > > >>>>>>>>>>>>>>>> DataRegionConfiguration, or introduce an enum for this > > field > > >>>>>>>>>>>>>>>> which > > >>>>>>>>>>>>>>>> is also > > >>>>>>>>>>>>>>>> an overkill. On the other hand, one can assume that th= e > > >>> defaults > > >>>>>>>>>>>>>>>> we > > >>>>>>>>>>>>>>>> are > > >>>>>>>>>>>>>>>> talking about are actually inherited. To resolve this,= I > > >>> suggest > > >>>>>>>>>>>>>>>> to > > >>>>>>>>>>>>>>>> introduce just another field defaultRegionConfiguratio= n > > and > > >>> get > > >>>>>>>>>>>>>>>> rid > > >>>>>>>>>>>>>>>> of > > >>>>>>>>>>>>>>>> other defaults in DataStorageConfiguration. > > >>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>> Thoughts? > > >>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>> 2017-10-02 15:19 GMT+03:00 Ivan Rakov < > > ivan.glukos@gmail.com > > >>>> : > > >>>>>>>>>>>>>>>> Vladimir, > > >>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>> I like your approach because it's easier to implement. > > >>>>>>>>>>>>>>>>> However, user may be confused by setting > > >>>>>>>>>>>>>>>>> *isDefaultPersistenceEnabled* > > >>>>>>>>>>>>>>>>> flag and seeing that persistence is not enabled by > > default > > >>> in > > >>>>>>>>>>>>>>>>> custom memory > > >>>>>>>>>>>>>>>>> region. I'll add clarifying Javadoc at this place. > > >>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>> Best Regards, > > >>>>>>>>>>>>>>>>> Ivan Rakov > > >>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>> On 02.10.2017 11:28, Vladimir Ozerov wrote: > > >>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>> Ivan, > > >>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>> I do not think this is correct approach, because it > will > > be > > >>> hard > > >>>>>>>>>>>>>>>>>> to > > >>>>>>>>>>>>>>>>>> explain, and you will have to use "Boolean" instead = of > > >>>>>>>>>>>>>>>>>> "boolean" > > >>>>>>>>>>>>>>>>>> for > > >>>>>>>>>>>>>>>>>> DataRegionConfiguration. I do not think we need > default > > >>>>>>>>>>>>>>>>>> "persistence > > >>>>>>>>>>>>>>>>>> enabled" for all regions. Instead, we should have > > >>> "persistence > > >>>>>>>>>>>>>>>>>> enabled" > > >>>>>>>>>>>>>>>>>> flag for default region only. It should not be > > propagated > > >>> to > > >>>>>>>>>>>>>>>>>> custom > > >>>>>>>>>>>>>>>>>> regions. > > >>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>> On Mon, Oct 2, 2017 at 11:14 AM, Ivan Rakov < > > >>>>>>>>>>>>>>>>>> ivan.glukos@gmail.com > > >>>>>>>>>>>>>>>>>> wrote: > > >>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>> Guys, I think I got the point now. > > >>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>> Let's check the final design: > > >>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>> *DataStorageConfiguration* will have > > >>>>>>>>>>>>>>>>>>> *isDefaultPersistenceEnabled* > > >>>>>>>>>>>>>>>>>>> property (default =3D false), which will be used fo= r > > >>> enabling > > >>>>>>>>>>>>>>>>>>> persistence > > >>>>>>>>>>>>>>>>>>> in > > >>>>>>>>>>>>>>>>>>> default data region. > > >>>>>>>>>>>>>>>>>>> *DataRegionConfiguration* will have > > *isPersistenceEnabled* > > >>>>>>>>>>>>>>>>>>> property, > > >>>>>>>>>>>>>>>>>>> which > > >>>>>>>>>>>>>>>>>>> will be used for enabling persistence in > corresponding > > >>> data > > >>>>>>>>>>>>>>>>>>> region. If > > >>>>>>>>>>>>>>>>>>> value is not set, value of > > *DataStorageConfiguration::isD > > >>>>>>>>>>>>>>>>>>> efaultPersistenceEnabled* > > >>>>>>>>>>>>>>>>>>> will be used by default. > > >>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>> Best Regards, > > >>>>>>>>>>>>>>>>>>> Ivan Rakov > > >>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>> On 02.10.2017 7:49, Dmitriy Setrakyan wrote: > > >>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>> On Mon, Oct 2, 2017 at 7:46 AM, Denis Magda < > > >>>>>>>>>>>>>>>>>>> dmagda@apache.org > > > >>>>>>>>>>>>>>>>>>> wrote: > > >>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>> On Oct 1, 2017, at 4:41 AM, Ivan Rakov < > > >>> ivan.glukos@gmail.com > > >>>>>>>>>>>>>>>>>>>> wrote: > > >>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>> 1) You're right. I forgot to include the main flag > in > > >>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>> DataRegionConfiguration - *isPersistenceEnabled*. > > >>> Persistence > > >>>>>>>>>>>>>>>>>>>>>> will be > > >>>>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>>>> enabled globally if at least one memory region h= as > > this > > >>>>>>>>>>>>>>>>>>>>>> flag > > >>>>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>>> set. > > >>>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>>> I=E2=80=99m confused. Why the persistence should = be enabled > > >>>>>>>>>>>>>>>>>>>>> *globally* > > >>>>>>>>>>>>>>>>>>>>> if the > > >>>>>>>>>>>>>>>>>>>>> purpose is to have it set for a specific region? = If > > it=E2=80=99s > > >>>>>>>>>>>>>>>>>>>>> enabled for > > >>>>>>>>>>>>>>>>>>>>> region > > >>>>>>>>>>>>>>>>>>>>> A only, I don=E2=80=99t want to have it activated= for > region > > B. > > >>>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>>> Yes, you are right. By default the persistence wi= ll > > be > > >>>>>>>>>>>>>>>>>>>>> disabled > > >>>>>>>>>>>>>>>>>>>>> globally. > > >>>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>>> But we should also give users a way to switch the > > >>> default > > >>>>>>>>>>>>>>>>>>>>> behavior from > > >>>>>>>>>>>>>>>>>>>> in-memory only (no-persistence) to persistence. > > >>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>> > > >>> > > > > > > > > --001a114fde9c563948055b6409f0--