Mailing-List: contact dev-help@ignite.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ignite.apache.org
MIME-Version: 1.0
In-Reply-To: <CAGt6o8=as4pHkdF49rVRf9-_haDrn+FDvEStEoiqNQ-baiR-YA@mail.gmail.com>
References: <CABDss3idR5Y6dgDHr7aKaVUkrOmJn391Q9KE6-hyNw3oVQtsSA@mail.gmail.com>
 <70089e9a-caa9-9236-24ed-1daa6e1f9810@gmail.com> <CAK2_iMO0TrcP-h4eyu=ywu4GnehW3Tv7yieXMOvUna81gdqxew@mail.gmail.com>
 <605757bd-751f-5954-be26-be044c4244ce@gmail.com> <CAGt6o8=bHMH6WgsFdFRLKT3L941deTJARyB7_0dPnP=EDri3+A@mail.gmail.com>
 <14cd3d61-daba-d2c1-8ef9-646c03a64b35@gmail.com> <DCBDEA39-38F7-490F-8C19-CC539209C419@apache.org>
 <CA+0=VoVWhf0DaGJVw0wXfE_AZ=HMan9qG8r-PwvY1_Pfq=E31g@mail.gmail.com>
 <768792ac-478a-16b1-c11d-22072804b2e8@gmail.com> <245AE873-0BAD-4ABA-BB37-D4949ED58530@apache.org>
 <CA+0=VoXQ3h8Xdzz--DYAk2T6hBAXuZzLAhQXc2tvsj49G6BMOA@mail.gmail.com>
 <CAK0qHnqfxyg8_ndeXZwDENNAm0QVOanLLms6XGVRQ4jkemfNUw@mail.gmail.com>
 <CA+0=VoXZ5=k97dPj4mf9vKurgsBbSN7ME=7sU9s1W0zsY-02zg@mail.gmail.com>
 <70e5e134-cf04-7812-23e4-0383226f529f@gmail.com> <8D3F9EBD-7821-4088-B86E-A0339B6AFFBA@apache.org>
 <CAK2_iMNPOGSiGdHshGyDYza1g6iGJgogcGUe+sT4JoLMBGypJA@mail.gmail.com>
 <a4e6be54-1357-d668-d5af-8a8570068d4e@gmail.com> <CAGt6o8=as4pHkdF49rVRf9-_haDrn+FDvEStEoiqNQ-baiR-YA@mail.gmail.com>
From: Dmitriy Setrakyan <dsetrakyan@apache.org>
Date: Mon, 16 Oct 2017 18:17:19 -0700
Message-ID: <CA+0=VoXchnV-v3eTeWApi4UOgS8H-byzrPFuUtJ3ydYpUufjxw@mail.gmail.com>
Subject: Re: Persistence per memory policy configuration
To: dev@ignite.apache.org
Content-Type: multipart/alternative; boundary="001a11450c7ce331af055bb3e447"
archived-at: Tue, 17 Oct 2017 01:18:04 -0000

--001a11450c7ce331af055bb3e447
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Igniters, we should not have Swap in the property names. Swap is something
that behaves completely differently from Ignite persistence, and I don't
think it should be present within Ignite altogether.

D.

On Mon, Oct 16, 2017 at 11:17 AM, Vladimir Ozerov <vozerov@gridgain.com>
wrote:

> +1 to Ivan's suggestion.
>
> =D0=BF=D0=BD, 16 =D0=BE=D0=BA=D1=82. 2017 =D0=B3. =D0=B2 21:00, Ivan Rako=
v <ivan.glukos@gmail.com>:
>
> > *swapPath* is ok for me. It is also consistent with *walPath* and
> > *walArchivePath*.
> >
> > Regarding persistencePath/storagePath, I don't like the idea when path
> > for WAL is implicitly changed, especially when we have separate option
> > for it.
> > WAL and storage files are already located under same $IGNITE_HOME root.
> >  From user perspective, there's no need to change root for all
> > persistence-related directories as long as $IGNITE_HOME points to the
> > correct disk.
> >  From developer perspective, this change breaks backwards compatibility=
.
> > Maintaining backwards compatibility in fail-safe way (checking both
> > old-style and new-style paths) is complex and hard to maintain in the
> > codebase.
> >
> > Best Regards,
> > Ivan Rakov
> >
> > My vote is for *storagePath* and keeping behavior as is.
> >
> > On 16.10.2017 16:53, Pavel Tupitsyn wrote:
> > > Igniters, another thing to consider:
> > >
> > > DataRegionConfiguration.SwapFilePath should be SwapPath,
> > > since this is actually not a single file, but a directory path.
> > >
> > > On Fri, Oct 13, 2017 at 7:53 PM, Denis Magda <dmagda@apache.org>
> wrote:
> > >
> > >> Seems I've got what you=E2=80=99re talking about.
> > >>
> > >> I=E2=80=99ve tried to change the root directory (*persistencePath*) =
and saw
> that
> > >> only data/indexes were placed to it while wal stayed somewhere in my
> > work
> > >> dir. It works counterintuitive and causes non productive discussions
> > like
> > >> we are in arguing about *persistencePath* or *storagePath*. Neither
> name
> > >> fits this behavior.
> > >>
> > >> My suggestion will be the following:
> > >> - *persistencePath* refers to the path of all storage files
> > (data/indexes,
> > >> wal, archive). If the path is changed *all the files* will be under
> the
> > new
> > >> directory unless *setWalPath* and *setWalArchivePath* are set
> > *explicitly*.
> > >> - *setWalPath* overrides the default location of WAL (which is
> > >> setPersistencePath)
> > >> - *setWalArchivePath* overrides the default location of the archive
> > (which
> > >> is again has to be setPersistencePath).
> > >>
> > >> If we follow this approach the configuration and behavior becomes
> vivid.
> > >> Thoughts?
> > >>
> > >> =E2=80=94
> > >> Denis
> > >>
> > >>> On Oct 13, 2017, at 1:21 AM, Ivan Rakov <ivan.glukos@gmail.com>
> wrote:
> > >>>
> > >>> Denis,
> > >>>
> > >>> Data/index storage and WAL are located under the same root by
> default.
> > >>> However, this is not mandatory: *storagePath* and *walPath*
> properties
> > >> can contain both absolute and relative paths. If paths are absolute,
> > >> storage and WAL can reside on different devices, like this:
> > >>>> storagePath: /storage1/NMVe_drive/storage
> > >>>> walPath: /storage2/Big_SSD_drive/wal
> > >>> We even recommend this in tuning guide: https://apacheignite.readme=
.
> > >> io/docs/durable-memory-tuning
> > >>> That's why I think *persistencePath* is misleading.
> > >>>
> > >>> Best Regards,
> > >>> Ivan Rakov
> > >>>
> > >>> On 13.10.2017 5:03, Dmitriy Setrakyan wrote:
> > >>>> On Thu, Oct 12, 2017 at 7:01 PM, Denis Magda <dmagda@gridgain.com>
> > >> wrote:
> > >>>>>  From what I see after running an example they are under the same
> > root
> > >>>>> folder and in different subdirectories. The root folder should be
> > >> defined
> > >>>>> by setPersistencePath as I guess.
> > >>>>>
> > >>>> If that is the case, then you are right. Then we should not have
> > >>>> storagePath or WalPath, and store them both under "persistencePath=
"
> > >> root.
> > >>>> However, I would need Alexey Goncharuk or Ivan Rakov to confirm
> this.
> > >>>>
> > >>
> >
> >
>

--001a11450c7ce331af055bb3e447--