Mailing-List: contact dev-help@ignite.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ignite.apache.org
MIME-Version: 1.0
In-Reply-To: <6ea0c1d3-23cb-fad8-caee-df457942fde4@gmail.com>
References: <CABDss3idR5Y6dgDHr7aKaVUkrOmJn391Q9KE6-hyNw3oVQtsSA@mail.gmail.com>
 <CALUCNEsvR-QmSsPiQEyBN1Xmc_8rTpjmNRK7BA3GWx9d-LdAtg@mail.gmail.com>
 <CAGt6o8=D4eucb6VjLUyT_C4im5BSou7h2zWKkhe+hFTfGTvBvA@mail.gmail.com>
 <CALUCNEv1q0zfVExiCW_eGw6y60k4jk2pw-tVsV=iYDYfNigvMw@mail.gmail.com>
 <CA+0=VoWd9FsjLba4zO3hcBbSURY2x4MgEVUy1KbPh-9LC8AyNg@mail.gmail.com>
 <CALUCNEs2JBaac+eJXyLHtk_ZnXpRDYgUA5LvkJV14AOZPGZFBA@mail.gmail.com>
 <CA+0=VoVEYbOzJn7LQzk_3bWB1KXD3eTV4dtCCS0TkdceJaU0kg@mail.gmail.com>
 <CAGt6o8=wfvK8kstJGYhDVQa5CiR545FHGk3RePPTrueK+xP87Q@mail.gmail.com>
 <2140C776-05E0-4B92-9D4D-D9DAB55BDE57@apache.org> <CABDss3i1_fr53jbEEQ4UrRBnA0sp7Ube6Odp1aRUc_ZDbgN_ww@mail.gmail.com>
 <CAGcMBHg+W+KRqYxG5MNzP7hd1ao2scdwnSThKk0Qc6pS=T4=+g@mail.gmail.com>
 <CAGt6o8nnid3sHFxhHWLSYeHm9KgQWuEvPSb-LAZq8u=MK7N_4Q@mail.gmail.com>
 <CA+0=VoUTbz3fTvviPYJjLaKtUw9sZLxScFz55WVniwF3zGymtA@mail.gmail.com>
 <78d72402-756c-2f0e-57ec-8a8a364b97e9@gmail.com> <19756338-9DF2-4860-819C-BC2CF463BDCF@apache.org>
 <6ea0c1d3-23cb-fad8-caee-df457942fde4@gmail.com>
From: Dmitriy Setrakyan <dsetrakyan@apache.org>
Date: Mon, 2 Oct 2017 07:14:09 +0300
Message-ID: <CA+0=VoWx1d7cU+icKXdQ+_G4hBgi5DVV6586JMFENBtYuLjkLw@mail.gmail.com>
Subject: Re: Persistence per memory policy configuration
To: dev@ignite.apache.org
Content-Type: multipart/alternative; boundary="94eb2c08515c9d7afb055a889df1"
archived-at: Mon, 02 Oct 2017 04:14:54 -0000

--94eb2c08515c9d7afb055a889df1
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

I am not sure I like the name "isDefaultDataRegionPersistenceEnabled" - too
long. Can we just call it "isDefaultPersistenceEnabled"?

D.

On Sun, Oct 1, 2017 at 2:41 PM, Ivan Rakov <ivan.glukos@gmail.com> wrote:

> Denis,
>
> 1) You're right. I forgot to include the main flag in
> DataRegionConfiguration - *isPersistenceEnabled*. Persistence will be
> enabled globally if at least one memory region has this flag set.
> Regarding default data region, I've added *isDefaultDataRegionPersistence=
Enabled
> *to the DataStorageConfiguration. Check the design draft again.
>
> 2) Of course, we have to maintain API compatibility. Deprecating old
> classes and introducing new is just what I meant.
>
> 3) We can't do that - MemoryMetrics are calculated per memory policy and
> PersistenceMetrics are calculated globally. It's a major change to
> implement it another way.
>
> By the way, let's assure the namings for new metrics classes.
> DataRegionMetrics instead of MemoryMetrics looks fine.
> About PersistenceMetrics - name "*DataStorageMetrics*" is not fair enough
> as it will contain only metrics of persistent storage. Probably
> *DataStoragePersistenceMetrics*,*PersistentDataStorageMetrics *or even
> keeping *PersistenceMetrics* are better.
>
> What do you think?
>
> Best Regards,
> Ivan Rakov
>
>
> On 29.09.2017 21:12, Denis Magda wrote:
>
>> Ivan,
>>
>> Several questions/concerns:
>>
>> 1. Looking at the new API I can=E2=80=99t grasp how to enable the persis=
tence.
>> First, how can I enable it globally if there is only one default data
>> region defined. Second, how do I enable it per data region. Can=E2=80=99=
t find any
>> related switches in the draft.
>>
>> 2. We cannot renamed anything like you=E2=80=99re suggesting to do for
>> MemoryMetrics and their beans. We have to deprecate old and introduce ne=
w.
>>
>> 3. I think we should merge Memory and Persistence Metrics into
>> DataStorageMetrics for clarity.
>>
>> =E2=80=94
>> Denis
>>
>>
>> On Sep 29, 2017, at 6:29 AM, Ivan Rakov <ivan.glukos@gmail.com> wrote:
>>>
>>> Guys,
>>>
>>> I've attached new configuration design draft to the ticket description:
>>> https://issues.apache.org/jira/browse/IGNITE-6030
>>> Please, take a look. Right now is the best time to change name of any
>>> property.
>>>
>>> And question about metrics: are we going to rename MemoryMetrics and
>>> PersistenceMetrics respectively (along with their MBeans)?
>>> It's not a problem to implement it at all. The only thing that concerns
>>> me is that we have to keep deprecated old classes in the codebase. Perh=
aps,
>>> MemoryMetrics/PersistenceMetrics are intuitive enough.
>>>
>>> On 29.09.2017 3:16, Dmitriy Setrakyan wrote:
>>>
>>>> StorageRegion sounds like bad English to me.
>>>>
>>>> I would go with DataStorageConfiguration and DataRegionConfiguration.
>>>>
>>>> D.
>>>>
>>>> On Thu, Sep 28, 2017 at 7:24 AM, Vladimir Ozerov <vozerov@gridgain.com=
>
>>>> wrote:
>>>>
>>>> Guys,
>>>>>
>>>>> But what is exact desicion? :-) I saw two final options:
>>>>>
>>>>> 1) StorageConfiguration + StorageRegionConfiguration
>>>>> 2) DataStorageConfiguration + DataRegionConfiguration
>>>>>
>>>>> Which one we choose?
>>>>>
>>>>> On Thu, Sep 28, 2017 at 5:10 PM, Yakov Zhdanov <yzhdanov@apache.org>
>>>>> wrote:
>>>>>
>>>>> I guess it is safe to assume that at this point we came to a consensu=
s?
>>>>>>>
>>>>>> Alex, I think so. Let's carve it in stone (code).
>>>>>>
>>>>>> --Yakov
>>>>>>
>>>>>>
>

--94eb2c08515c9d7afb055a889df1--