ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Denis Magda <dma...@apache.org>
Subject Re: Adding sqlline tool to Apache Ignite project
Date Fri, 06 Oct 2017 19:20:38 GMT
Really nice, could click through the getting started [1] in a minute!

+1 to rename the script to “ignitesql”. Vladimir’s point makes total sense.

However, tend to disagree that the host has to be requested all the times. We never request
a configuration or host name for ignite.sh, visor or web agent scripts. I would follow this
approach that’s excellent for dev time.

But, we need to support “help” (-h, -help) argument listing all the parameters accepted
by the tools.

Please consider our feedback and share the next build once it’s ready.


[1] https://apacheignite-sql.readme.io/v2.1/docs/getting-started <https://apacheignite-sql.readme.io/v2.1/docs/getting-started>

—
Denis

> On Oct 6, 2017, at 9:04 AM, Anton Vinogradov <avinogradov@gridgain.com> wrote:
> 
> How about sqlconsole.sh or sqlcmd.sh ?
> 
> On Fri, Oct 6, 2017 at 6:04 PM, <dsetrakyan@apache.org> wrote:
> 
>> I like ignitesql.
>> 
>> ⁣D.​
>> 
>> On Oct 6, 2017, 4:49 PM, at 4:49 PM, Vladimir Ozerov <vozerov@gridgain.com>
>> wrote:
>>> Denis,
>>> 
>>> Setting default host to 127.0.0.1 is bad idea, because it mean that in
>>> practice users would have to change the script always. Instead, we
>>> should
>>> accept host name as argument. This is perfectly fine from usability
>>> perspective, most tools work this way (i.e. throw error when started
>>> without arguments).
>>> 
>>> Also IMO "ignitedb" is misleading name. Users would like think that it
>>> is a
>>> kind of script to start database, rather than to connect to it. We
>>> should
>>> think on other names. E.g. "ignitesql".
>>> 
>>> On Fri, Oct 6, 2017 at 5:23 PM, Sergey Kozlov <skozlov@gridgain.com>
>>> wrote:
>>> 
>>>> Denis
>>>> 
>>>> The link below has included sqlline. Please take a look:
>>>> https://ci.ignite.apache.org/viewLog.html?buildId=875441&
>>>> buildTypeId=IgniteRelease_XxxFromMirrorIgniteRelease3Pre
>>>> pareVote&tab=artifacts#!1rrb2,-wpvx2aopzexz
>>>> 
>>>> On Thu, Oct 5, 2017 at 7:48 PM, Denis Magda <dmagda@apache.org>
>>> wrote:
>>>> 
>>>>> Here is the original ticket [1]. Ilya, closed the one created by
>>> you as a
>>>>> duplicate.
>>>>> 
>>>>> In addition to the tool’s jar inclusion in Ignite’s binary releases
>>> let’s
>>>>> create a shell script to simplify the connectivity phase:
>>>>> 
>>>>>   - name the script as ignitedb.sh for Unix and ignitedb.bat for
>>>> Windows.
>>>>>   -
>>>>>   - the script uses the following connection string by default:
>>> .sqlline
>>>>>   -d org.apache.ignite.IgniteJdbcThinDriver --color=true
>>> --verbose=true
>>>>>   --showWarnings=true --showNestedErrs=true -u jdbc:ignite:
>>>>>   thin://127.0.0.1/
>>>>> 
>>>>> 
>>>>> 
>>>>>   - make up parameters list to adjust Ignite specific part of the
>>>>>   connection string: Ignite IP and port, streaming mode, etc. The
>>> full
>>>> list
>>>>>   of supported parameters is here: https://apacheignite-
>>>>>   sql.readme.io/docs/jdbc-driver#jdbc-thin-driver
>>>>> 
>>> <https://apacheignite-sql.readme.io/docs/jdbc-driver#jdbc-thin-driver
>>>>> 
>>>>> 
>>>>> 
>>>>> 
>>>>> [1] https://issues.apache.org/jira/browse/IGNITE-5608
>>>>> 
>>>>> —
>>>>> Denis
>>>>> 
>>>>> On Oct 5, 2017, at 9:02 AM, Sergey Kozlov <skozlov@gridgain.com>
>>> wrote:
>>>>> 
>>>>> Dmitriy, Denis
>>>>> 
>>>>> We're in progress to add sqlline in upcoming 2.3
>>>>> 
>>>>> On Thu, Oct 5, 2017 at 5:30 PM, Dmitriy Setrakyan
>>> <dsetrakyan@apache.org
>>>>>> wrote:
>>>>> Would be nice to get it in 2.3. This is critical functionality for
>>> our
>>>>> users and 2.4 seems too far to give anyone comfort.
>>>>> 
>>>>> On Thu, Oct 5, 2017 at 11:33 AM, Ilya Suntsov
>>> <isuntsov@gridgain.com>
>>>>> wrote:
>>>>> 
>>>>>> Guys,
>>>>>> 
>>>>>> I've created the ticket for 2.4 release:
>>>>>> https://issues.apache.org/jira/browse/IGNITE-6561
>>>>>> 
>>>>>> 2017-08-30 22:21 GMT+03:00 Julian Hyde <jhyde@apache.org>:
>>>>>> 
>>>>>>> Denis,
>>>>>>> 
>>>>>>> I’m glad you’re thinking of using SQLLine. Under the BSD
>>> license, you
>>>>>>> don’t need my permission to distribute, but I grant that
>>> permission.
>>>>>>> 
>>>>>>> Drill, Phoenix and Calcite already distribute SQLLine, so
>>> Ignite is
>>>> in
>>>>>>> good company.
>>>>>>> 
>>>>>>> If you need extensions, please discuss on the dev list, or open
>>> a
>>>>> GitHub
>>>>>>> case or pull request. SQLLine operates in the usual way for a
>>> GitHub
>>>>>>> project. It’s unlikely that you’ll need Ignite-specific
>>> extensions —
>>>>>>> SQLLine just exposes what comes through the JDBC driver — but
>>> we can
>>>>>>> discuss if the need arises. The Hive project forked SQLLine
>>> into its
>>>>> own
>>>>>>> Beeline module and I’d like to avoid a repeat of that.
>>>>>>> 
>>>>>>> Julian
>>>>>>> 
>>>>>>>> On Aug 29, 2017, at 6:35 PM, Denis Magda <dmagda@apache.org>
>>>> wrote:
>>>>>>>> 
>>>>>>>> Igniters,
>>>>>>>> 
>>>>>>>> Let me introduce Julian Hyde [1], creator of SQLLine tool
and
>>> our
>>>>>> Apache
>>>>>>> mate,
>>>>>>>> 
>>>>>>>> Julian,
>>>>>>>> 
>>>>>>>> Please grant that Apache Ignite community a permission to
>>> include
>>>>>>> SQLLine [2] it in every Ignite deliverable (source, binary).
>>> It’s
>>>>> planned
>>>>>>> to suggest the tool as a default command line SQL utility for
>>> Ignite
>>>>>>> clusters. SQLLite and Ignite usage will also be documented on
>>>> Ignite’s
>>>>>>> technical documentation.
>>>>>>>> 
>>>>>>>> [1] https://people.apache.org/~jhyde/ <
>>>> https://people.apache.org/~jh
>>>>>> yde/
>>>>>>>> 
>>>>>>>> [2] https://github.com/julianhyde/sqlline
>>> <https://github.com/
>>>>>>> julianhyde/sqlline>
>>>>>>>> 
>>>>>>>> —
>>>>>>>> Denis
>>>>>>>> 
>>>>>>>>> On Aug 25, 2017, at 9:17 AM, Denis Magda <dmagda@apache.org
>>>>> <mailto:
>>>>>>> dmagda@apache.org>> wrote:
>>>>>>>>> 
>>>>>>>>> Hi Ilya,
>>>>>>>>> 
>>>>>>>>> Thanks for the clarification! Referring to the page shared
>>> by you
>>>>> [1]
>>>>>>> if we need to get author’s consent in a written form:
>>>>>>>>> 
>>>>>>>>> A permissive license similar to the BSD 2-Clause License,
>>> but
>>>> with a
>>>>>>> 3rd clause that prohibits others from using the name of the
>>> project
>>>> or
>>>>>> its
>>>>>>> contributors to promote derived products without written
>>> consent.
>>>>>>>>> 
>>>>>>>>> [1]
>>> https://github.com/julianhyde/sqlline/blob/master/LICENSE <
>>>>>>> https://github.com/julianhyde/sqlline/blob/master/LICENSE>
<
>>>>>>> https://github.com/julianhyde/sqlline/blob/master/LICENSE <
>>>>>>> https://github.com/julianhyde/sqlline/blob/master/LICENSE>>
>>>>>>>>> 
>>>>>>>>> I’ll reach out the author requesting the permit.
>>>>>>>>> 
>>>>>>>>> —
>>>>>>>>> Denis
>>>>>>>>> 
>>>>>>>>>> On Aug 25, 2017, at 9:12 AM, Ilya Kasnacheev <
>>>>>>> ilya.kasnacheev@gmail.com <mailto:ilya.kasnacheev@gmail.com>>
>>> wrote:
>>>>>>>>>> 
>>>>>>>>>> Hi Denis,
>>>>>>>>>> 
>>>>>>>>>> There are two kinds of BSD license, 3-clause and
4-clause.
>>> The
>>>>>>> difference
>>>>>>>>>> between them is advertising clause:
>>>>>>>>>> 
>>>>>>>>>> "3. All advertising materials mentioning features
or use of
>>> this
>>>>>>> software
>>>>>>>>>> must display the following acknowledgement: This
product
>>> includes
>>>>>>> software
>>>>>>>>>> developed by the University of California, Berkeley
and its
>>>>>>> contributors."
>>>>>>>>>> 
>>>>>>>>>> which is causing problems with other licenses and
which
>>> sqlline's
>>>>>>> license
>>>>>>>>>> doesn't contain:
>>>>>>>>>> https://github.com/julianhyde/sqlline/blob/master/LICENSE
<
>>>>>>> https://github.com/julianhyde/sqlline/blob/master/LICENSE>
>>>>>>>>>> So it should be all good for inclusion.
>>>>>>>>>> 
>>>>>>>>>> --
>>>>>>>>>> Ilya Kasnacheev.
>>>>>>>>>> 
>>>>>>>>>> 2017-08-25 18:48 GMT+03:00 Denis Magda <dmagda@apache.org>:
>>>>>>>>>> 
>>>>>>>>>>> Hi Ilya,
>>>>>>>>>>> 
>>>>>>>>>>> It will be a useful addition to Ignite. I would
include
>>> the tool
>>>>> in
>>>>>>> one of
>>>>>>>>>>> the nearest releases. It’s license is BSD-3
which is
>>> compatible
>>>>> with
>>>>>>> ours.
>>>>>>>>>>> However, there is a note on ASF side saying that
BSD
>>> licenses
>>>> can
>>>>> be
>>>>>>>>>>> included without advertising clause [1]. What
does it mean
>>> for
>>>> us?
>>>>>>> Can we
>>>>>>>>>>> document the tool and mention on our site?
>>>>>>>>>>> 
>>>>>>>>>>> [1] https://www.apache.org/legal/resolved.html#category-a
>>> <
>>>>>>>>>>> https://www.apache.org/legal/resolved.html#category-a>
>>>>>>>>>>> 
>>>>>>>>>>> —
>>>>>>>>>>> Denis
>>>>>>>>>>> 
>>>>>>>>>>>> On Aug 25, 2017, at 8:32 AM, Ilya Suntsov
<
>>>> isuntsov@gridgain.com
>>>>>> 
>>>>>>> wrote:
>>>>>>>>>>>> 
>>>>>>>>>>>> Hi Igniters,
>>>>>>>>>>>> 
>>>>>>>>>>>> I've found one command line tool that can
be used for
>>> execute
>>>>>> queries
>>>>>>>>>>>> (DDL/DML) with data from Apache Ignite grid
via
>>>>>>>>>>>> *org.apache.ignite.IgniteJdbcThinDriver*.
>>>>>>>>>>>> 
>>>>>>>>>>>> Here you can find overview of internal commands
of this
>>> tool:
>>>>>>>>>>>> https://cwiki.apache.org/confluence/display/IGNITE/
>>>>>>> Overview+sqlline+tool
>>>>>>>>>>>> 
>>>>>>>>>>>> The most problems with sqlline relate with
some issues
>>> from our
>>>>>> side
>>>>>>> or
>>>>>>>>>>>> some unsupported features.
>>>>>>>>>>>> 
>>>>>>>>>>>> Would be nice to add tool like this (sqlline
or something
>>> else)
>>>>> in
>>>>>>> our
>>>>>>>>>>>> project.
>>>>>>>>>>>> 
>>>>>>>>>>>> Have you any objections or other thoughts?
>>>>>>>>>>>> 
>>>>>>>>>>>> 
>>>>>>>>>>>> --
>>>>>>>>>>>> Ilya Suntsov
>>>>>>>>>>> 
>>>>>>>>>>> 
>>>>>>>>> 
>>>>>>>> 
>>>>>>> 
>>>>>>> 
>>>>>> 
>>>>>> 
>>>>>> --
>>>>>> Ilya Suntsov
>>>>>> 
>>>>> 
>>>>> 
>>>>> 
>>>>> --
>>>>> Sergey Kozlov
>>>>> GridGain Systems
>>>>> www.gridgain.com
>>>>> 
>>>>> 
>>>>> 
>>>> 
>>>> 
>>>> --
>>>> Sergey Kozlov
>>>> GridGain Systems
>>>> www.gridgain.com
>>>> 
>> 


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message