Mailing-List: contact dev-help@ignite.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ignite.apache.org
MIME-Version: 1.0
In-Reply-To: <CAGcMBHhtF7k-eDGJ+gWfiBH9iA_O-UMFW00EZF61U=GckDEn6A@mail.gmail.com>
References: <CAA-MoLgbVdfuUhp8=NNNQz2mDCYXrQR-RMR6K0BppmAYSnhwvg@mail.gmail.com>
 <CAGcMBHhB_cxsFe1dJcTZhjWmBvfbzRzac=DEmBgLx8vCnWkK0A@mail.gmail.com>
 <CAA-MoLgoiixMEumqS4B7-HbaB_4Qb7u6Ym5F0_q-5gastvutvA@mail.gmail.com> <CAGcMBHhtF7k-eDGJ+gWfiBH9iA_O-UMFW00EZF61U=GckDEn6A@mail.gmail.com>
From: Ilya Kasnacheev <ilya.kasnacheev@gmail.com>
Date: Fri, 1 Sep 2017 18:39:50 +0300
Message-ID: <CAA-MoLiwd6KfWu0aRXvC9kbRzQmsH66p68KRaPR8Fpg9z=o8cA@mail.gmail.com>
Subject: Re: Hopeless looping in TcpCommunicationSpi
To: dev@ignite.apache.org
Content-Type: multipart/alternative; boundary="001a11397df65453a805582292bb"
archived-at: Fri, 01 Sep 2017 15:40:05 -0000

--001a11397df65453a805582292bb
Content-Type: text/plain; charset="UTF-8"

Yes, the same problem is possible with server-server communication. I've
amended my pull request to include a test for that.

There are already Thread.sleeps() in this look so I propose to add a
countdown to maxConnectionAttempts instead of while(true)

Ideally we should find a way to log last error, such issues are hard to
debug otherwise.

-- 
Ilya Kasnacheev

2017-09-01 15:27 GMT+03:00 Yakov Zhdanov <yzhdanov@apache.org>:

> Ilya, I reviewed your test and I now see the point.
>
> Is the same possible with server-server? Or failure process will be
> initiated for remote node by local one?
>
> Will the following work for client? If connection fails then client takes a
> pause for 1 sec with Thread.sleep() and takes another attempt. If
> maxConnectionAttempts (3 by default) fails then client stops and restart
> itself.
>
> --Yakov
>

--001a11397df65453a805582292bb--