ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ilya Kasnacheev <ilya.kasnach...@gmail.com>
Subject Re: guard() and checkClusterState() checks in Ignite Kernal
Date Tue, 12 Sep 2017 11:25:42 GMT
Rehi,

After some discussions https://github.com/apache/ignite/pull/2526 seems to
have correct changeset that covers two methods which seem to have been
overlooked before.
It's already reviewed by another contributor, please merge it into master
you seem fit.

Regards,
Ilya.

-- 
Ilya Kasnacheev

2017-08-29 15:42 GMT+03:00 Ilya Kasnacheev <ilya.kasnacheev@gmail.com>:

> Dear Igniters,
>
> I would like to know if guard() and checkClusterState() methods are always
> called consistently in IgniteKernal.
>
> Let's look at the list:
> Out of cluster(), localNode(), compute(), message(), events(),
> executorService(), services() only the last one is guarded by
> checkClusterState()
> Is this correct?
>
> pingNode() is not checked or guarded, but pingNodeByAddress() is guarded.
> Is this correct?
>
> undeployTaskFromGrid() and executeTask() are neither checked nor guarded.
>
> eventUserRecordable() and allEventsUserRecordable() are guarded but not
> cheked. Is this correct?
>
> getOrCreateCaches() and destroyCachesAsync() are guarded but not checked -
> am I correct in trying to fix that in https://github.com/apache/
> ignite/pull/2526 ?
>
> destroyCache() and destroyCaches() are neither guarded nor checked, but
> destroyCacheAsync() both guarded and checked. What's the reason for that?
>
> binary() and affinity() are checked but not guarded.
>
> active(), resetLostPartitions(), memoryMetrics(),
> persistentStoreMetrics(), atomicSequence() are guarded but not checked.
>
> I appreciate your support.
>
> --
> Ilya Kasnacheev
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message